{"id":814551,"url":"http://patchwork.ozlabs.org/api/1.2/patches/814551/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170916212331.170463-5-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170916212331.170463-5-sjg@chromium.org>","list_archive_url":null,"date":"2017-09-16T21:23:17","name":"[U-Boot,04/13] mtdparts: Correct use of debug()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"453b3bd54658983b0998cd8dfc9c528b65f90a43","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/1.2/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/1.2/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170916212331.170463-5-sjg@chromium.org/mbox/","series":[{"id":3473,"url":"http://patchwork.ozlabs.org/api/1.2/series/3473/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=3473","date":"2017-09-16T21:23:14","name":"log: Add a new logging feature","version":1,"mbox":"http://patchwork.ozlabs.org/series/3473/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814551/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814551/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"kCWwSHV4\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvlfd2VtNz9sPr\n\tfor ;\n\tSun, 17 Sep 2017 07:25:11 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 4D716C21E26; Sat, 16 Sep 2017 21:24:50 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 19E8BC21DDA;\n\tSat, 16 Sep 2017 21:24:14 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 585A4C21E00; Sat, 16 Sep 2017 21:24:01 +0000 (UTC)","from mail-oi0-f48.google.com (mail-oi0-f48.google.com\n\t[209.85.218.48])\n\tby lists.denx.de (Postfix) with ESMTPS id 70F64C21D82\n\tfor ; Sat, 16 Sep 2017 21:23:57 +0000 (UTC)","by mail-oi0-f48.google.com with SMTP id i6so2366455oih.8\n\tfor ; Sat, 16 Sep 2017 14:23:57 -0700 (PDT)","from kiwi.bld.corp.google.com ([100.101.164.89])\n\tby smtp.gmail.com with ESMTPSA id\n\ta199sm3874145oii.37.2017.09.16.14.23.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 16 Sep 2017 14:23:55 -0700 (PDT)","by kiwi.bld.corp.google.com (Postfix, from userid 121222)\n\tid B11B4140A54; Sat, 16 Sep 2017 15:23:54 -0600 (MDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=g/A5FwKd3LIXmjG1kFIuQ65fa4N7Tmut77g7wgMqZes=;\n\tb=kCWwSHV4Q5gqffyL7bPuooItnjlPZa73Ag3LYnOh9PnEVCD+ZQDQZhaCnSYZwTQb4b\n\tiugJX3okGSGP970ZZt8JI/r5oS4h3tdVlLuCjjeIJ+ABrSmEzOR1EnVZHk7f7qME+/1i\n\tn3Hp1GXugWxReqOpYDfH8cAyk+5k9UqbQpJk9LqIV1+elwCsp0TyQe2UqwKLeM/5Fc4t\n\tzccbu+YfmkaRn5NH27c71zsspXVWYqw6JsPaU9fhO7OxgJt/0uqL23KT4E09w03th+Yh\n\tHONasCmeQ+UX+K81RXrdMMgWMvaHbFkuYk00QwoKcdrZV9rLCI8ra/iACKDqm4ord12B\n\tHVwQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=g/A5FwKd3LIXmjG1kFIuQ65fa4N7Tmut77g7wgMqZes=;\n\tb=nR2ARmOxNpM9z/AEEPaS2brAuTFb48S1Kq9BAHvjM98THxuX3wubJD7V8LDTwtWKB9\n\t74guZVL47Uak0LPN81WJjezIUNrH31gB2q8OlO94FFowwSscfGAElxCkBKgBoVEvmQOb\n\tDyXo5zkPCr7+J/a3pa66SfUtUatXQYccZtXxKe/iaV3NsZGQAC8I7xiKoOsvCSx9zXru\n\tSStkI8gbOd2GKS9NlVIhYKojbvnjtpHP9iJfpZeaR2HB1QQFTBIbl36HJ4GBkd4lLIvV\n\tOdVmexQSQ0+h6e2pIYXCc5QTaBU/64EAVUPoFPkhEHtKYZWpkiQi1eWseoUNBzpuqiF4\n\t++wQ==","X-Gm-Message-State":"AHPjjUipYJHOsSdy31lD2ONoxEVBUjr8QamRng52WvUx6izX9aMzdOo1\n\t5EuTg/Jf8p5ziHs7","X-Google-Smtp-Source":"AOwi7QAbPDixXyrbAp4vXYOjpaImwYE2njKubnN8DDovDQEpS9QxRlxlXDkJxc/mLPcKyRIqlcWc8w==","X-Received":"by 10.202.105.1 with SMTP id e1mr18668887oic.153.1505597036020; \n\tSat, 16 Sep 2017 14:23:56 -0700 (PDT)","From":"Simon Glass ","To":"U-Boot Mailing List ","Date":"Sat, 16 Sep 2017 15:23:17 -0600","Message-Id":"<20170916212331.170463-5-sjg@chromium.org>","X-Mailer":"git-send-email 2.14.1.690.gbb1197296e-goog","In-Reply-To":"<20170916212331.170463-1-sjg@chromium.org>","References":"<20170916212331.170463-1-sjg@chromium.org>","Cc":"Tom Rini ,\n\tMaxime Ripard ,\n\tJagan Teki ","Subject":"[U-Boot] [PATCH 04/13] mtdparts: Correct use of debug()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"The debug() macro now evaluates its expression so does not need #ifdef\nprotection. In fact the current code causes a warning with the new log\nimplementation. Adjust the code to fix this.\n\nSigned-off-by: Simon Glass \n---\n\n cmd/mtdparts.c | 3 ---\n 1 file changed, 3 deletions(-)","diff":"diff --git a/cmd/mtdparts.c b/cmd/mtdparts.c\nindex 3275eb919b..13677faf4b 100644\n--- a/cmd/mtdparts.c\n+++ b/cmd/mtdparts.c\n@@ -873,15 +873,12 @@ static int device_parse(const char *const mtd_dev, const char **ret, struct mtd_\n \t\treturn 1;\n \t}\n \n-#ifdef DEBUG\n \tpend = strchr(p, ';');\n-#endif\n \tdebug(\"dev type = %d (%s), dev num = %d, mtd-id = %s\\n\",\n \t\t\tid->type, MTD_DEV_TYPE(id->type),\n \t\t\tid->num, id->mtd_id);\n \tdebug(\"parsing partitions %.*s\\n\", (int)(pend ? pend - p : strlen(p)), p);\n \n-\n \t/* parse partitions */\n \tnum_parts = 0;\n \n","prefixes":["U-Boot","04/13"]}