{"id":814550,"url":"http://patchwork.ozlabs.org/api/1.2/patches/814550/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170916212331.170463-3-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170916212331.170463-3-sjg@chromium.org>","list_archive_url":null,"date":"2017-09-16T21:23:15","name":"[U-Boot,02/13] Revert \"sandbox: Drop special case console code for sandbox\"","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8a523815a4c22bc5ad07c459c9b0ce1eb26d181b","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/1.2/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/1.2/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170916212331.170463-3-sjg@chromium.org/mbox/","series":[{"id":3473,"url":"http://patchwork.ozlabs.org/api/1.2/series/3473/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=3473","date":"2017-09-16T21:23:14","name":"log: Add a new logging feature","version":1,"mbox":"http://patchwork.ozlabs.org/series/3473/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814550/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814550/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"KLKQpSyL\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvldd3v0Yz9sPr\n\tfor ;\n\tSun, 17 Sep 2017 07:24:21 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 16B9EC21DC5; Sat, 16 Sep 2017 21:24:12 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 67DAEC21DE5;\n\tSat, 16 Sep 2017 21:24:01 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 85380C21DD9; Sat, 16 Sep 2017 21:23:57 +0000 (UTC)","from mail-oi0-f45.google.com (mail-oi0-f45.google.com\n\t[209.85.218.45])\n\tby lists.denx.de (Postfix) with ESMTPS id 68833C21C39\n\tfor ; Sat, 16 Sep 2017 21:23:54 +0000 (UTC)","by mail-oi0-f45.google.com with SMTP id y195so2373046oia.13\n\tfor ; Sat, 16 Sep 2017 14:23:54 -0700 (PDT)","from kiwi.bld.corp.google.com ([2620:0:10f2:0:b470:b7b0:9c28:669e])\n\tby smtp.gmail.com with ESMTPSA id\n\tx137sm3887501oia.13.2017.09.16.14.23.52\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 16 Sep 2017 14:23:52 -0700 (PDT)","by kiwi.bld.corp.google.com (Postfix, from userid 121222)\n\tid 94B02140A54; Sat, 16 Sep 2017 15:23:51 -0600 (MDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=P4K2Jsa0n5/L7ahp0uDF7YSM4SKJQvUqCPR+GcEU38o=;\n\tb=KLKQpSyLDgtyhyhdLTbhW/di6GkGNOuc2VjXv2vrmne4M316++n9jY5gXBCgtYzLXB\n\t4y0fq5mdBn0Sp7WOtDZGi0wcrtxheKeInfDqnsYF5Q4YGT8EqHLMPc+WeEzwvnmyQOg+\n\twv51BLhIBPyfnEg8W2sI5JqbT3YrdpeLNw+9isIRrjLC7o2iqU79vcNBS0wktmUObw1i\n\tYt/q+qtt5C1spmgm57M2ctcq/R44TdKFsNouTEU4bhXwEuAC83JOewPV7Ub+CJwaqvar\n\t7lHTsCtyxR3VNfRf3FOf6ykM4Gvwsgjz+AN+vp9HeJZD4U7Z/cV9r8ZE/3apCMvUhskM\n\t66TQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=P4K2Jsa0n5/L7ahp0uDF7YSM4SKJQvUqCPR+GcEU38o=;\n\tb=BZ3PSR10Xfzrz2/FJh1QnoJ6KY7rtnmWAoICzLJG5yu/Wyy9wZ0LSoYkQF4WxZkja6\n\tvaVGmI5MpLfOb2bGXvia3bCaOOgsnQby6ZbrBmku+E5p3+1JJQl0o+tdHQS62CVKlYZY\n\tZeZQQ8pI3YlIuuuvY2vme1gsa2NwTnaWjrYgtW9to/RGlSPSja/rIaYh9irGqbfspYew\n\trXpBZuswQhni2Zh92tc0CKY8JGAsJv1qLP3lhzDwSW4PoKLmLpvFB898xYkyPp8/j2FD\n\tTYujll9vCpZRTc+oSbYv+R4vpTyhp5Cw3fGv+TbuYfFpWiwRwVJ3RckrK9REmEMhIpKd\n\tzOcw==","X-Gm-Message-State":"AHPjjUhVyC5uafOtqyfSBx+qvk4lnXJ0a0HVxvWDSxkWAX7iDFKne/8I\n\tYVYVSZzHhoEs8syM","X-Google-Smtp-Source":"AOwi7QDH0MfLzLHKtbw5E85j2RD16UaX3qsF8aYmcoAvs4LSvr6gKK0zpCtHsDlpvEQ8nlqBH/UO+g==","X-Received":"by 10.202.105.16 with SMTP id e16mr7072329oic.104.1505597032967; \n\tSat, 16 Sep 2017 14:23:52 -0700 (PDT)","From":"Simon Glass ","To":"U-Boot Mailing List ","Date":"Sat, 16 Sep 2017 15:23:15 -0600","Message-Id":"<20170916212331.170463-3-sjg@chromium.org>","X-Mailer":"git-send-email 2.14.1.690.gbb1197296e-goog","In-Reply-To":"<20170916212331.170463-1-sjg@chromium.org>","References":"<20170916212331.170463-1-sjg@chromium.org>","Cc":"Tom Rini , Jan Kiszka ,\n\t\"Andreas J. Reichel\" ,\n\tWilson Lee , Jagan Teki ,\n\tChris Packham ","Subject":"[U-Boot] [PATCH 02/13] Revert \"sandbox: Drop special case console\n\tcode for sandbox\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"While sandbox works OK without the special-case code, it does result in\nconsole output being stored in the pre-console buffer while sandbox starts\nup. If there is a crash or a problem then there is no indication of what\nis going on.\n\nFor ease of debugging it seems better to revert this change also.\n\nThis reverts commit d8c6fb8cedbc35eee27730a7fa544e499b3c81cc.\n\nSigned-off-by: Simon Glass \n---\n\n common/console.c | 7 +++++++\n configs/sandbox_defconfig | 2 +-\n 2 files changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/common/console.c b/common/console.c\nindex f83528ca60..18457aab3c 100644\n--- a/common/console.c\n+++ b/common/console.c\n@@ -482,6 +482,13 @@ static inline void print_pre_console_buffer(int flushpoint) {}\n \n void putc(const char c)\n {\n+#ifdef CONFIG_SANDBOX\n+\t/* sandbox can send characters to stdout before it has a console */\n+\tif (!gd || !(gd->flags & GD_FLG_SERIAL_READY)) {\n+\t\tos_putc(c);\n+\t\treturn;\n+\t}\n+#endif\n #ifdef CONFIG_DEBUG_UART\n \t/* if we don't have a console yet, use the debug UART */\n \tif (!gd || !(gd->flags & GD_FLG_SERIAL_READY)) {\ndiff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig\nindex e7a61bd61a..88ae98d312 100644\n--- a/configs/sandbox_defconfig\n+++ b/configs/sandbox_defconfig\n@@ -16,7 +16,7 @@ CONFIG_CONSOLE_RECORD=y\n CONFIG_CONSOLE_RECORD_OUT_SIZE=0x1000\n CONFIG_SILENT_CONSOLE=y\n CONFIG_PRE_CONSOLE_BUFFER=y\n-CONFIG_PRE_CON_BUF_ADDR=0\n+CONFIG_PRE_CON_BUF_ADDR=0x100000\n CONFIG_CMD_CPU=y\n CONFIG_CMD_LICENSE=y\n CONFIG_CMD_BOOTZ=y\n","prefixes":["U-Boot","02/13"]}