{"id":814549,"url":"http://patchwork.ozlabs.org/api/1.2/patches/814549/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170916212331.170463-2-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170916212331.170463-2-sjg@chromium.org>","list_archive_url":null,"date":"2017-09-16T21:23:14","name":"[U-Boot,01/13] Revert \"sandbox: remove os_putc() and os_puts()\"","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2532e1aad56ac51a17e1c17d490b7241c5d2363d","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/1.2/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/1.2/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170916212331.170463-2-sjg@chromium.org/mbox/","series":[{"id":3473,"url":"http://patchwork.ozlabs.org/api/1.2/series/3473/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=3473","date":"2017-09-16T21:23:14","name":"log: Add a new logging feature","version":1,"mbox":"http://patchwork.ozlabs.org/series/3473/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814549/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814549/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"Ch8sS9JZ\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvldN6Tt3z9sPr\n\tfor ;\n\tSun, 17 Sep 2017 07:24:06 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 48C98C21D19; Sat, 16 Sep 2017 21:23:56 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 73994C21C4E;\n\tSat, 16 Sep 2017 21:23:54 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 2F814C21C39; Sat, 16 Sep 2017 21:23:53 +0000 (UTC)","from mail-oi0-f42.google.com (mail-oi0-f42.google.com\n\t[209.85.218.42])\n\tby lists.denx.de (Postfix) with ESMTPS id 9BDCAC21C26\n\tfor ; Sat, 16 Sep 2017 21:23:52 +0000 (UTC)","by mail-oi0-f42.google.com with SMTP id r20so2368374oie.0\n\tfor ; Sat, 16 Sep 2017 14:23:52 -0700 (PDT)","from kiwi.bld.corp.google.com ([100.101.164.89])\n\tby smtp.gmail.com with ESMTPSA id\n\tx18sm4350212oix.8.2017.09.16.14.23.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 16 Sep 2017 14:23:50 -0700 (PDT)","by kiwi.bld.corp.google.com (Postfix, from userid 121222)\n\tid F00BD140A54; Sat, 16 Sep 2017 15:23:49 -0600 (MDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=BQZ1Z9bhyAlt/GNr78xGdXSFB6cs9fdNzZog199lPds=;\n\tb=Ch8sS9JZ7CtfhO6eSdLELr9ETwasL1mAwFNNXNoyPIRdGKwkX0m7n7J6cpiMKF6Prw\n\tlhZXi1TKcIPMMJ9xDIk3CnXyEnuEwN/42B+EaeBEEGTfunbrrrAqTDJMkzv4H3eIRotR\n\tLU/jTX9OFI6J7oPG82VWei5qd2fygXTG1PJpSP0BpQDnKpjGqIFtOIhOeP9dDCu1/Z0b\n\tRvM9iWb9d4IYcIx/S5F8q66lkvdyT1w0wg5Fq7E4A7s6/YESNhzhyIZNpflc4gS8Edgz\n\tHBYNXPRXqoO4U/9ugohSe0LqazSk8RbCorssXzR/ItvW1qo0YjppqoOW2yD63FtrJZIY\n\tbG3Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=BQZ1Z9bhyAlt/GNr78xGdXSFB6cs9fdNzZog199lPds=;\n\tb=K/uFalPK7fu0yZ+Yxcwn1CxILQiFRBiJBydFNJcvjqyNNeajL5WGIZXlceGa+a5gqR\n\tXoEpxiRDG085VqNJ4dTFLzqrgUXiKGmVpkna8g3DXdwZZb+jJP9ihafMjnYvGL8qZM8N\n\ts+o4h2oaiHhn000/oZiFN5jnd3fPhnhFfc4Di/26u1VqZ6Zos8pm5KMi9nVwoG//ik7V\n\tDBr1JiHr3iFfMWJJqasjuDMEyGoe4jiIe3ZhBt2K4DuruQ/rxxCdApDU3ETut2vy+hcp\n\tg8vWXAznI17DTFx0GEd7hmsHUdOR93oDhXp828LGPBUiMb2uxHQjw36/jAJdQmekHA3R\n\tl7bQ==","X-Gm-Message-State":"AHPjjUhjKszfaSjF43KG1iz0eAIjNRUNFAbdFLp/zgtsdFO9WHgTsmB/\n\tW5zmuAYMxxfNf1OC","X-Google-Smtp-Source":"AOwi7QDt+npgVHuLwJq9WuJ7+PKdUtBe60+0NAS9xo9VhxyzirbVZoTvSNlzk/H8xXbkNSdgl9KdPQ==","X-Received":"by 10.202.104.27 with SMTP id d27mr689886oic.201.1505597031206; \n\tSat, 16 Sep 2017 14:23:51 -0700 (PDT)","From":"Simon Glass ","To":"U-Boot Mailing List ","Date":"Sat, 16 Sep 2017 15:23:14 -0600","Message-Id":"<20170916212331.170463-2-sjg@chromium.org>","X-Mailer":"git-send-email 2.14.1.690.gbb1197296e-goog","In-Reply-To":"<20170916212331.170463-1-sjg@chromium.org>","References":"<20170916212331.170463-1-sjg@chromium.org>","Cc":"Tom Rini , =?utf-8?q?Stefan_Br=C3=BCns?=\n\t","Subject":"[U-Boot] [PATCH 01/13] Revert \"sandbox: remove os_putc() and\n\tos_puts()\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"While sandbox works OK without the special-case code, it does result in\nconsole output being stored in the pre-console buffer while sandbox starts\nup. If there is a crash or a problem then there is no indication of what\nis going on.\n\nFor ease of debugging it seems better to revert this change.\n\nThis reverts commit 47b98ad0f6779485d0f0c14f337c3eece273eb54.\n\nSigned-off-by: Simon Glass \n---\n\n arch/sandbox/cpu/os.c | 11 +++++++++++\n include/os.h | 20 ++++++++++++++++++++\n 2 files changed, 31 insertions(+)","diff":"diff --git a/arch/sandbox/cpu/os.c b/arch/sandbox/cpu/os.c\nindex 22d6aab534..7243bfc1b1 100644\n--- a/arch/sandbox/cpu/os.c\n+++ b/arch/sandbox/cpu/os.c\n@@ -413,6 +413,17 @@ int os_get_filesize(const char *fname, loff_t *size)\n \treturn 0;\n }\n \n+void os_putc(int ch)\n+{\n+\tputchar(ch);\n+}\n+\n+void os_puts(const char *str)\n+{\n+\twhile (*str)\n+\t\tos_putc(*str++);\n+}\n+\n int os_write_ram_buf(const char *fname)\n {\n \tstruct sandbox_state *state = state_get_current();\ndiff --git a/include/os.h b/include/os.h\nindex 2bf4bdb1b8..049b248c5b 100644\n--- a/include/os.h\n+++ b/include/os.h\n@@ -240,6 +240,26 @@ const char *os_dirent_get_typename(enum os_dirent_t type);\n */\n int os_get_filesize(const char *fname, loff_t *size);\n \n+/**\n+ * Write a character to the controlling OS terminal\n+ *\n+ * This bypasses the U-Boot console support and writes directly to the OS\n+ * stdout file descriptor.\n+ *\n+ * @param ch\tCharacter to write\n+ */\n+void os_putc(int ch);\n+\n+/**\n+ * Write a string to the controlling OS terminal\n+ *\n+ * This bypasses the U-Boot console support and writes directly to the OS\n+ * stdout file descriptor.\n+ *\n+ * @param str\tString to write (note that \\n is not appended)\n+ */\n+void os_puts(const char *str);\n+\n /**\n * Write the sandbox RAM buffer to a existing file\n *\n","prefixes":["U-Boot","01/13"]}