{"id":814547,"url":"http://patchwork.ozlabs.org/api/1.2/patches/814547/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20170916204234.725130-1-arnd@arndb.de/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.2/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170916204234.725130-1-arnd@arndb.de>","list_archive_url":null,"date":"2017-09-16T20:42:21","name":"gpio: omap: omap_gpio_show_rev is not __init","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3ad9d8d68f02201bc38eb746ce923aff592cb3ce","submitter":{"id":30,"url":"http://patchwork.ozlabs.org/api/1.2/people/30/?format=json","name":"Arnd Bergmann","email":"arnd@arndb.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20170916204234.725130-1-arnd@arndb.de/mbox/","series":[{"id":3471,"url":"http://patchwork.ozlabs.org/api/1.2/series/3471/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=3471","date":"2017-09-16T20:42:21","name":"gpio: omap: omap_gpio_show_rev is not __init","version":1,"mbox":"http://patchwork.ozlabs.org/series/3471/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814547/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814547/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvkjf4Ghmz9sRm\n\tfor ;\n\tSun, 17 Sep 2017 06:42:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751274AbdIPUmo (ORCPT );\n\tSat, 16 Sep 2017 16:42:44 -0400","from mout.kundenserver.de ([212.227.17.24]:61614 \"EHLO\n\tmout.kundenserver.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750937AbdIPUmn (ORCPT\n\t); Sat, 16 Sep 2017 16:42:43 -0400","from wuerfel.lan ([95.208.190.237]) by mrelayeu.kundenserver.de\n\t(mreue103 [212.227.15.145]) with ESMTPA (Nemesis) id\n\t0LyBrp-1dN7uA0rbh-015WME; Sat, 16 Sep 2017 22:42:35 +0200"],"From":"Arnd Bergmann ","To":"Grygorii Strashko ,\n\tSantosh Shilimkar ,\n\tKevin Hilman ,\n\tLinus Walleij ","Cc":"Arnd Bergmann , linux-omap@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"[PATCH] gpio: omap: omap_gpio_show_rev is not __init","Date":"Sat, 16 Sep 2017 22:42:21 +0200","Message-Id":"<20170916204234.725130-1-arnd@arndb.de>","X-Mailer":"git-send-email 2.9.0","X-Provags-ID":"V03:K0:AIUbWyQ2ijZBOMaRjiJ4t3oaYJCDptmZlV8LnlCoFAlpZTNW5b3\n\tEDJVhW3vAk1DmIWo1Nj3L0khtb/wD+tDFqfDbQwrI8blLasR4lP/adFNT/q5YYlt3exiMX1\n\tFe1TGCv5DiHJXEzXhg8ybysAupIboUA6s+gtB3mgIjlTNLfaZbnstLU4xU0m9ndykcnLW69\n\tpxUypNUFMuqAGKsC/2wAA==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:iqebl3/GIeQ=:nwINSMw5QIkA3LC1IoKXTp\n\txUcnG9xIsr6FpdtDM7SNNRUUCFukU9etDORC4efB66iF6Wxsz07BfUGiVT/pw5FVQ9k6XZt6B\n\tjcgVjQdr2A0WzmpmBMe8QBLKx0PEF0KAy6+V3DfnbtgI3Vzq1agh0aXKk1qNfTRBSarVjeWPb\n\tnHsVwygdrLbgjmiFakJDeFPhrqVLJYNFAOQXwNBCaEoKBpBebTyzXWgEoMP3NGFW1LqtDVLTe\n\tw/wA8Cm4dqigD/9aWfAQ2ebOvdxdcowxFdGDiOBDzQRPZZG1pR3ZOaGH56kixOAM2Crr08H9R\n\t5Q/xgAdQbHJmoxOjabTTw4eSNW97EZ/lmDMdxTcBLr2CbBdW+QDfK6+xiyzuK13ClgmDqRiOa\n\tluhEmcAyefgHG4ibf96H4qXTN3KuyaEUNuG7rSVDcJBNJQrFRkhkR3Su1WNORWi+tTkwbtzXq\n\trS0/PVxsvSww8JUmfTMi46XtJEZCKjOtf9Js5gGwz2HG1ndgZtSUO72Fy4PSqvjCzKl2ud410\n\taJTd4XjxOWtxQQmlj6uE8O63+kOtRgarcZlsPooDRGCTNN6lD0edfFJwHVNbmGrxK5WzaQ0ad\n\tcCTEnq+w++HP1xGZXQHCF5J23Y7OFIPKygOdsjGH2tiGyvX+c0dVlZdkRll33rqpluJV3oQ6r\n\tEkifUrDUSE/H4cdvrOLCP+qVjQgs/pDGJZnD4gfKwl0uzDYixw5KaOGn6OK0ZvSJO4LHKkfO7\n\t0p3W3xwKVkzRijWENCimKYkNV5IVZWSH3x5shw==","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"},"content":"The probe function calls omap_gpio_show_rev(), which on most\ncompilers is inlined, but on the old gcc-4.6 is not, causing\na valid warning about the incorrect __init annotation:\n\nWARNING: vmlinux.o(.text+0x40f614): Section mismatch in reference from the function omap_gpio_probe() to the function .init.text:omap_gpio_show_rev()\nThe function omap_gpio_probe() references\nthe function __init omap_gpio_show_rev().\nThis is often because omap_gpio_probe lacks a __init\nannotation or the annotation of omap_gpio_show_rev is wrong.\n\nThis removes the __init.\n\nSigned-off-by: Arnd Bergmann \n---\n drivers/gpio/gpio-omap.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c\nindex dbf869fb63ce..22d7d4838265 100644\n--- a/drivers/gpio/gpio-omap.c\n+++ b/drivers/gpio/gpio-omap.c\n@@ -1010,7 +1010,7 @@ static void omap_gpio_set(struct gpio_chip *chip, unsigned offset, int value)\n \n /*---------------------------------------------------------------------*/\n \n-static void __init omap_gpio_show_rev(struct gpio_bank *bank)\n+static void omap_gpio_show_rev(struct gpio_bank *bank)\n {\n \tstatic bool called;\n \tu32 rev;\n","prefixes":[]}