{"id":814476,"url":"http://patchwork.ozlabs.org/api/1.2/patches/814476/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1505543667-4670-1-git-send-email-srishtishar@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505543667-4670-1-git-send-email-srishtishar@gmail.com>","list_archive_url":null,"date":"2017-09-16T06:34:27","name":"Staging: irda: Use !x instead of NULL comparison","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"724a174dc1995f902a43f34d71b4f7449f9bfa6e","submitter":{"id":72376,"url":"http://patchwork.ozlabs.org/api/1.2/people/72376/?format=json","name":"Srishti Sharma","email":"srishtishar@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1505543667-4670-1-git-send-email-srishtishar@gmail.com/mbox/","series":[{"id":3419,"url":"http://patchwork.ozlabs.org/api/1.2/series/3419/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3419","date":"2017-09-16T06:34:27","name":"Staging: irda: Use !x instead of NULL comparison","version":1,"mbox":"http://patchwork.ozlabs.org/series/3419/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814476/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814476/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lT+Bb/Kr\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvMvG4Hvvz9s81\n\tfor ;\n\tSat, 16 Sep 2017 16:34:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751249AbdIPGeg (ORCPT );\n\tSat, 16 Sep 2017 02:34:36 -0400","from mail-pg0-f67.google.com ([74.125.83.67]:33846 \"EHLO\n\tmail-pg0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750779AbdIPGee (ORCPT\n\t); Sat, 16 Sep 2017 02:34:34 -0400","by mail-pg0-f67.google.com with SMTP id v82so2390986pgb.1;\n\tFri, 15 Sep 2017 23:34:34 -0700 (PDT)","from srishti-PRODiiGY-945G ([122.168.202.126])\n\tby smtp.gmail.com with ESMTPSA id\n\ti2sm4079131pgq.81.2017.09.15.23.34.32\n\t(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 15 Sep 2017 23:34:33 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=CM2ZdDBdB76UCAkE23K1uoSrhBwp++Goba18PRcOCvw=;\n\tb=lT+Bb/KrJ1LfiNlQpQVMzbvVjjHbFDpkoxEdGr9yT6/F2gsd2OQ+ek70fgWuJCPbLR\n\tDSpz9RxWVeETANutv0+n2emmnkIHlbe01X0Nd4KtefDETEQeVPhPsvh2BCBMW2pQua05\n\tM9gIvDcYlJcvCCD8pAU9Oi1q7BSesMNFKf7oR72Ou9/5PU/G7QC9DYkF0jbzgzSnkfdf\n\tcud0l53PpPTmJE4Rily7Jj8dZzbdJmWI8wNh2wXoZZtiXdtmf30RZcQvVDEKM+5E/CVL\n\tWwFbSWBH2fxfEx1ExfERwDKTCL9VsV1XUkVJPKoued9A6RkYATkCq6JMWEreqopDdGFV\n\txY5g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=CM2ZdDBdB76UCAkE23K1uoSrhBwp++Goba18PRcOCvw=;\n\tb=YXZ9g2X15WM/gI2rwjeSStJv4igOuIt1bJIfzpQR365YgzAO0dQRv7Or2tTnq8Lqa1\n\t3s9KDmqZf4fSSMgkFb9OGYkGEz3FCO+ygrlU5J9NEKuWgkT0zlhjc9cuOa12jtKm8mRq\n\tjgoVdxUObbzPQmeIbLfwOmzQO9VgzKvvbhWwL7lzI3ElTPAAMcrmlRPLYL0FgdPqBlSX\n\ty20x2/6oWvLFC7kFuG6NcnN1N0d+s7XkL2Mtf0oEVQuujWkmYfQgmEtoqOwMHFPdKsuB\n\tJvwlGcn0RcwNNWNUjcXzt4+9le/g55OJjyNsINPih70Iiwp85O4dLMlrLhIGoS7/U3+k\n\t3R+A==","X-Gm-Message-State":"AHPjjUhlRyQP6eX92KigAyC3cIxMzfaYKCvmQMvCcQXZoHos2r0GmTES\n\t3CSyqJG8tO8pPA==","X-Google-Smtp-Source":"ADKCNb69/qLtNX+9u+sT1Y8Szii3LiBJHvMHKKnivUz+bSYUVib3o78kCqv/XS40HWFSRaiXH1PTeA==","X-Received":"by 10.101.70.138 with SMTP id h10mr26844436pgr.8.1505543674143; \n\tFri, 15 Sep 2017 23:34:34 -0700 (PDT)","From":"Srishti Sharma ","To":"samuel@sortiz.org","Cc":"gregkh@linuxfoundation.org, netdev@vger.kernel.org,\n\tdevel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,\n\toutreachy-kernel@googlegroups.com, Srishti Sharma ","Subject":"[PATCH] Staging: irda: Use !x instead of NULL comparison","Date":"Sat, 16 Sep 2017 12:04:27 +0530","Message-Id":"<1505543667-4670-1-git-send-email-srishtishar@gmail.com>","X-Mailer":"git-send-email 2.7.4","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Test for NULL as !x where functions that return NULL on failure\nare used. Done using the following semantic patch by coccinelle.\n\n@ is_null @\nexpression E;\nstatement S;\n@@\n\nE = (\\(kmalloc\\|devm_kzalloc\\|kmalloc_array\\|devm_ioremap\\|\nusb_alloc_urb\\|alloc_netdev\\|dev_alloc_skb\\)(...));\n\n(\nif(!E)\n S\n|\n-if(E==NULL)\n+if(!E)\n S\n)\n\nSigned-off-by: Srishti Sharma \n---\n drivers/staging/irda/net/discovery.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/staging/irda/net/discovery.c b/drivers/staging/irda/net/discovery.c\nindex 364d70a..1e54954 100644\n--- a/drivers/staging/irda/net/discovery.c\n+++ b/drivers/staging/irda/net/discovery.c\n@@ -179,7 +179,7 @@ void irlmp_expire_discoveries(hashbin_t *log, __u32 saddr, int force)\n \t\t\t\t/* Create the client specific buffer */\n \t\t\t\tn = HASHBIN_GET_SIZE(log);\n \t\t\t\tbuffer = kmalloc(n * sizeof(struct irda_device_info), GFP_ATOMIC);\n-\t\t\t\tif (buffer == NULL) {\n+\t\t\t\tif (!buffer) {\n \t\t\t\t\tspin_unlock_irqrestore(&log->hb_spinlock, flags);\n \t\t\t\t\treturn;\n \t\t\t\t}\n@@ -291,7 +291,7 @@ struct irda_device_info *irlmp_copy_discoveries(hashbin_t *log, int *pn,\n \t\t\t\t/* Create the client specific buffer */\n \t\t\t\tn = HASHBIN_GET_SIZE(log);\n \t\t\t\tbuffer = kmalloc(n * sizeof(struct irda_device_info), GFP_ATOMIC);\n-\t\t\t\tif (buffer == NULL) {\n+\t\t\t\tif (!buffer) {\n \t\t\t\t\tspin_unlock_irqrestore(&log->hb_spinlock, flags);\n \t\t\t\t\treturn NULL;\n \t\t\t\t}\n","prefixes":[]}