{"id":814039,"url":"http://patchwork.ozlabs.org/api/1.2/patches/814039/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/c5398945d4e80ed8b8497675dd0449763fec4eec.1505444568.git.lucien.xin@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-15T03:02:48","name":"[net] sctp: do not mark sk dumped when inet_sctp_diag_fill returns err","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"e9e5b75250d14a034dbedb3300bcf9146876fdf3","submitter":{"id":61073,"url":"http://patchwork.ozlabs.org/api/1.2/people/61073/?format=json","name":"Xin Long","email":"lucien.xin@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/c5398945d4e80ed8b8497675dd0449763fec4eec.1505444568.git.lucien.xin@gmail.com/mbox/","series":[{"id":3201,"url":"http://patchwork.ozlabs.org/api/1.2/series/3201/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3201","date":"2017-09-15T03:02:48","name":"[net] sctp: do not mark sk dumped when inet_sctp_diag_fill returns err","version":1,"mbox":"http://patchwork.ozlabs.org/series/3201/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/814039/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/814039/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"T1lqdcdX\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtgFJ0y7Kz9sCZ\n\tfor ;\n\tFri, 15 Sep 2017 13:03:00 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751933AbdIODC6 (ORCPT );\n\tThu, 14 Sep 2017 23:02:58 -0400","from mail-pg0-f66.google.com ([74.125.83.66]:37253 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751876AbdIODC4 (ORCPT\n\t); Thu, 14 Sep 2017 23:02:56 -0400","by mail-pg0-f66.google.com with SMTP id v5so617224pgn.4;\n\tThu, 14 Sep 2017 20:02:56 -0700 (PDT)","from localhost ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id\n\tc7sm3640610pfc.55.2017.09.14.20.02.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 14 Sep 2017 20:02:55 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=KF7Aev1se0up1r7278OICVFOiO98H77gy3ov13eg8dw=;\n\tb=T1lqdcdX0wgmHOif+hcK1tPHIA7qW/0XYu4aJbnzkqi3TNPe8+BSHqobIvC65s4Gxv\n\ta8VeOFyBxWlDefwzfee+KqQLIMVKs9/y6+SjMWc19WDRrKJ1YfP9eFEQK2obT7ZUse3C\n\tCjNzXNYDeUwnL75pWlzwN43DK2lMopJdzcrEKpcEiR8alxoaWiypLdrthGLsdzArihGU\n\tsFMVBcBCs2252wlqDp4h6QdMI3GBCgO2enTLH+SS50/bYdciVFqRSXB0E8q6rTxfdeVJ\n\t0KsFZs48PAqkmlQCYLNpyCC5JrpK87IAn9V7nzgQ1JT2Y0NP5mUQagKVC4xNJLgGt7+y\n\tZSUw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=KF7Aev1se0up1r7278OICVFOiO98H77gy3ov13eg8dw=;\n\tb=cusvKXh0JAL4JACN6lxCJ4T/56b1rKWLhQN2Tvn/LkCk/M+tBLZGcVQ0lfTBkBlkjG\n\tSYbS2/TPZSW9Eam6GhpdFlHYMc9iTsRNAT8kld76XRxq2r1o2lHIukfJ0vDS8eEcCi6r\n\twCZlQeqVjU8gq5+BuKBTnNP6N+qhVzzcdfiK4gsWEI1GYkhUXxvAOmyjGeRuLp42OO05\n\tMgrVpJCtRPQBP20UwNGQBviduLvgwq5z3TWv7vrf6jWp/vWBIauyR2T3cBF0y8927Rko\n\tr+NJay+mAhksCCXiVYXOqvy89/F0qvQ4UeIxRmV9yUa6sBMB1lc2os4zjiyxPaJvDE7e\n\t9GsQ==","X-Gm-Message-State":"AHPjjUht5N2TEvQQlgXVCEkX2vE9iSBU2U/g7H8rzpZqTRGn5/ay9ryB\n\tv07iplER0fxsypbz3A4=","X-Google-Smtp-Source":"AOwi7QAUolVrMa/Yj7520sr35N2SJMmB89w9njy7NGXuKdMxnaMZhkipTmH7mt5s3NFc801SIaPX4A==","X-Received":"by 10.98.133.17 with SMTP id u17mr3271709pfd.235.1505444575907; \n\tThu, 14 Sep 2017 20:02:55 -0700 (PDT)","From":"Xin Long ","To":"network dev , linux-sctp@vger.kernel.org","Cc":"davem@davemloft.net, Marcelo Ricardo Leitner ,\n\tNeil Horman ","Subject":"[PATCH net] sctp: do not mark sk dumped when inet_sctp_diag_fill\n\treturns err","Date":"Fri, 15 Sep 2017 11:02:48 +0800","Message-Id":"","X-Mailer":"git-send-email 2.1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"sctp_diag would not actually dump out sk/asoc if inet_sctp_diag_fill\nreturns err, in which case it shouldn't mark sk dumped by setting\ncb->args[3] as 1 in sctp_sock_dump().\n\nOtherwise, it could cause some asocs to have no parent's sk dumped\nin 'ss --sctp'.\n\nSo this patch is to not set cb->args[3] when inet_sctp_diag_fill()\nreturns err in sctp_sock_dump().\n\nFixes: 8f840e47f190 (\"sctp: add the sctp_diag.c file\")\nSigned-off-by: Xin Long \n---\n net/sctp/sctp_diag.c | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/net/sctp/sctp_diag.c b/net/sctp/sctp_diag.c\nindex 7008a99..22ed01a 100644\n--- a/net/sctp/sctp_diag.c\n+++ b/net/sctp/sctp_diag.c\n@@ -309,7 +309,6 @@ static int sctp_sock_dump(struct sctp_transport *tsp, void *p)\n \t\t\t\t\tcb->nlh->nlmsg_seq,\n \t\t\t\t\tNLM_F_MULTI, cb->nlh,\n \t\t\t\t\tcommp->net_admin) < 0) {\n-\t\t\tcb->args[3] = 1;\n \t\t\terr = 1;\n \t\t\tgoto release;\n \t\t}\n","prefixes":["net"]}