{"id":813982,"url":"http://patchwork.ozlabs.org/api/1.2/patches/813982/?format=json","web_url":"http://patchwork.ozlabs.org/project/sparclinux/patch/20170914223517.8242-5-pasha.tatashin@oracle.com/","project":{"id":10,"url":"http://patchwork.ozlabs.org/api/1.2/projects/10/?format=json","name":"Linux SPARC Development ","link_name":"sparclinux","list_id":"sparclinux.vger.kernel.org","list_email":"sparclinux@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170914223517.8242-5-pasha.tatashin@oracle.com>","list_archive_url":null,"date":"2017-09-14T22:35:10","name":"[v8,04/11] sparc64: simplify vmemmap_populate","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"0c078a5f0fc69521f1f577e4987c38edab41164b","submitter":{"id":71010,"url":"http://patchwork.ozlabs.org/api/1.2/people/71010/?format=json","name":"Pavel Tatashin","email":"pasha.tatashin@oracle.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/sparclinux/patch/20170914223517.8242-5-pasha.tatashin@oracle.com/mbox/","series":[{"id":3172,"url":"http://patchwork.ozlabs.org/api/1.2/series/3172/?format=json","web_url":"http://patchwork.ozlabs.org/project/sparclinux/list/?series=3172","date":"2017-09-14T22:35:07","name":"complete deferred page initialization","version":8,"mbox":"http://patchwork.ozlabs.org/series/3172/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813982/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813982/checks/","tags":{},"related":[],"headers":{"Return-Path":"<sparclinux-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=sparclinux-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtYN64hbRz9s5L\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 15 Sep 2017 08:38:30 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751268AbdINWg4 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 14 Sep 2017 18:36:56 -0400","from aserp1040.oracle.com ([141.146.126.69]:23439 \"EHLO\n\taserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751445AbdINWgx (ORCPT\n\t<rfc822; sparclinux@vger.kernel.org>); Thu, 14 Sep 2017 18:36:53 -0400","from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v8EMZTQS029474\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 14 Sep 2017 22:35:29 GMT","from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72])\n\tby userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v8EMZTtV028430\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 14 Sep 2017 22:35:29 GMT","from ubhmp0003.oracle.com (ubhmp0003.oracle.com [156.151.24.56])\n\tby userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v8EMZTQ9009725; \n\tThu, 14 Sep 2017 22:35:29 GMT","from cmex.localdomain (/12.145.98.253)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 14 Sep 2017 22:35:28 +0000"],"From":"Pavel Tatashin <pasha.tatashin@oracle.com>","To":"linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,\n\tlinux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tx86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com,\n\theiko.carstens@de.ibm.com, davem@davemloft.net,\n\twilly@infradead.org, mhocko@kernel.org, ard.biesheuvel@linaro.org,\n\twill.deacon@arm.com, catalin.marinas@arm.com, sam@ravnborg.org,\n\tmgorman@techsingularity.net, Steven.Sistare@oracle.com,\n\tdaniel.m.jordan@oracle.com, bob.picco@oracle.com","Subject":"[PATCH v8 04/11] sparc64: simplify vmemmap_populate","Date":"Thu, 14 Sep 2017 18:35:10 -0400","Message-Id":"<20170914223517.8242-5-pasha.tatashin@oracle.com>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170914223517.8242-1-pasha.tatashin@oracle.com>","References":"<20170914223517.8242-1-pasha.tatashin@oracle.com>","X-Source-IP":"userv0022.oracle.com [156.151.31.74]","Sender":"sparclinux-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<sparclinux.vger.kernel.org>","X-Mailing-List":"sparclinux@vger.kernel.org"},"content":"Remove duplicating code by using common functions\nvmemmap_pud_populate and vmemmap_pgd_populate.\n\nSigned-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>\nReviewed-by: Steven Sistare <steven.sistare@oracle.com>\nReviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>\nReviewed-by: Bob Picco <bob.picco@oracle.com>\nAcked-by: David S. Miller <davem@davemloft.net>\n---\n arch/sparc/mm/init_64.c | 23 ++++++-----------------\n 1 file changed, 6 insertions(+), 17 deletions(-)","diff":"diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c\nindex 078f1352736e..fc47afa518f5 100644\n--- a/arch/sparc/mm/init_64.c\n+++ b/arch/sparc/mm/init_64.c\n@@ -2642,30 +2642,19 @@ int __meminit vmemmap_populate(unsigned long vstart, unsigned long vend,\n \tvstart = vstart & PMD_MASK;\n \tvend = ALIGN(vend, PMD_SIZE);\n \tfor (; vstart < vend; vstart += PMD_SIZE) {\n-\t\tpgd_t *pgd = pgd_offset_k(vstart);\n+\t\tpgd_t *pgd = vmemmap_pgd_populate(vstart, node);\n \t\tunsigned long pte;\n \t\tpud_t *pud;\n \t\tpmd_t *pmd;\n \n-\t\tif (pgd_none(*pgd)) {\n-\t\t\tpud_t *new = vmemmap_alloc_block(PAGE_SIZE, node);\n+\t\tif (!pgd)\n+\t\t\treturn -ENOMEM;\n \n-\t\t\tif (!new)\n-\t\t\t\treturn -ENOMEM;\n-\t\t\tpgd_populate(&init_mm, pgd, new);\n-\t\t}\n-\n-\t\tpud = pud_offset(pgd, vstart);\n-\t\tif (pud_none(*pud)) {\n-\t\t\tpmd_t *new = vmemmap_alloc_block(PAGE_SIZE, node);\n-\n-\t\t\tif (!new)\n-\t\t\t\treturn -ENOMEM;\n-\t\t\tpud_populate(&init_mm, pud, new);\n-\t\t}\n+\t\tpud = vmemmap_pud_populate(pgd, vstart, node);\n+\t\tif (!pud)\n+\t\t\treturn -ENOMEM;\n \n \t\tpmd = pmd_offset(pud, vstart);\n-\n \t\tpte = pmd_val(*pmd);\n \t\tif (!(pte & _PAGE_VALID)) {\n \t\t\tvoid *block = vmemmap_alloc_block(PMD_SIZE, node);\n","prefixes":["v8","04/11"]}