{"id":813158,"url":"http://patchwork.ozlabs.org/api/1.2/patches/813158/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1505280046-16608-5-git-send-email-yamada.masahiro@socionext.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/1.2/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505280046-16608-5-git-send-email-yamada.masahiro@socionext.com>","list_archive_url":null,"date":"2017-09-13T05:20:41","name":"[4/9] mtd: nand: denali: squash denali_enable_dma() helper into caller","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e9b7173406ac4dbc480f227400651df94a341004","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/1.2/people/65882/?format=json","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"delegate":{"id":58324,"url":"http://patchwork.ozlabs.org/api/1.2/users/58324/?format=json","username":"bbrezillon","first_name":"Boris","last_name":"Brezillon","email":"boris.brezillon@free-electrons.com"},"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1505280046-16608-5-git-send-email-yamada.masahiro@socionext.com/mbox/","series":[{"id":2809,"url":"http://patchwork.ozlabs.org/api/1.2/series/2809/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=2809","date":"2017-09-13T05:20:39","name":"mtd: nand: denali: more clean-ups","version":1,"mbox":"http://patchwork.ozlabs.org/series/2809/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813158/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813158/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"ZVv3g7yO\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"mZ6PtYmJ\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsVSg5nl8z9sPm\n\tfor ;\n\tWed, 13 Sep 2017 15:23:47 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1ds09E-00082a-Uh; Wed, 13 Sep 2017 05:23:41 +0000","from conuserg-12.nifty.com ([210.131.2.79])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1ds07J-0006Xp-NJ\n\tfor linux-mtd@lists.infradead.org; Wed, 13 Sep 2017 05:21:51 +0000","from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp\n\t[153.142.97.92]) (authenticated)\n\tby conuserg-12.nifty.com with ESMTP id v8D5Kpx3010397;\n\tWed, 13 Sep 2017 14:20:54 +0900"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=JCqnWiLZc37PGQhukVxOZvGPXF3b6MWkOOly3EMgyto=;\n\tb=ZVv3g7yOyPHhvAwLDESKCpfSqT\n\txgGyyuNPJ9kpEEHyN4qTCNzNSZGy1f9sXF4q9yZI4hgnelTh1r8OcONKxzJgOhJYEwAjDAHfD582Z\n\tvQU7dqTMdex6jpWRBGES9qwlBVRnqoTovqA9tJZaAFauGW9owYdDWiMMqQY+BY0HPYeUBVXubsxXk\n\tHkR7X3vlgtlMFwa8dEr2lip5ZpvImdv93uZWPCBf08o55aogZfU4KFkPWWIy6Krr3BXMMaeZd+8pu\n\tW9dBKlGz5D5y0vrpERs5zhkf/EJ94tqEXiW312ptYLRIWdmfvMK+oM95nfbZmRi61IDjTscNBq+cw\n\tNdRgzfVA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1505280055;\n\tbh=UsmtvXFLh1VYoEpkB1cXxBkVIZ+LB34uuLv5OvakrN8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mZ6PtYmJrwOigXUgsvjpM1aFePJUuGx/sO0NS+Yypni4k1EHPHUE0dPEeZxu5EZSZ\n\tSlz5jkXDNkadXk+DqtbeI9J0e6/gRnvXa2zzJLyq6gJtnY3gqdsqZ45xa6957S1B/M\n\tR2PXx3eCIUV50ulMXDHVk58vH6ioWB15ZYoZ9a+AQUScTD2W6koDJm4qQj/q8b4R8O\n\tyzZzvq1fI7lUO1+Tie0ZtYpxuUsjGCi8yABXy87uTgNg12NtXv1bLPwEFcuwZ/30vI\n\tFmHg0qTAGX9QVqhekmAOWDG7Ilbw9mP8WAWhM40D2roQ+F+WhRPi6wA5z6QtAnkSud\n\t+5LG3qSc3lPLA=="],"DKIM-Filter":"OpenDKIM Filter v2.10.3 conuserg-12.nifty.com v8D5Kpx3010397","X-Nifty-SrcIP":"[153.142.97.92]","From":"Masahiro Yamada ","To":"linux-mtd@lists.infradead.org","Subject":"[PATCH 4/9] mtd: nand: denali: squash denali_enable_dma() helper\n\tinto caller","Date":"Wed, 13 Sep 2017 14:20:41 +0900","Message-Id":"<1505280046-16608-5-git-send-email-yamada.masahiro@socionext.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1505280046-16608-1-git-send-email-yamada.masahiro@socionext.com>","References":"<1505280046-16608-1-git-send-email-yamada.masahiro@socionext.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170912_222142_295005_4AA374F2 ","X-CRM114-Status":"UNSURE ( 9.61 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.2 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tMarek Vasut ,\n\tRichard Weinberger , linux-kernel@vger.kernel.org,\n\tMasahiro Yamada , \n\tCyrille Pitchen ,\n\tBrian Norris ,\n\tDavid Woodhouse ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"This helper just sets/clears a flag of DMA_ENABLE register (with\nregister read-back, I do not know why it is necessary).\n\nMove the register write code to the caller, and remove the helper.\nIt works for me without the register read-back.\n\nSigned-off-by: Masahiro Yamada \n---\n\n drivers/mtd/nand/denali.c | 12 +++---------\n 1 file changed, 3 insertions(+), 9 deletions(-)","diff":"diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c\nindex 4daeb7f..e7b25de 100644\n--- a/drivers/mtd/nand/denali.c\n+++ b/drivers/mtd/nand/denali.c\n@@ -465,13 +465,6 @@ static int denali_sw_ecc_fixup(struct mtd_info *mtd,\n \treturn max_bitflips;\n }\n \n-/* programs the controller to either enable/disable DMA transfers */\n-static void denali_enable_dma(struct denali_nand_info *denali, bool en)\n-{\n-\tiowrite32(en ? DMA_ENABLE__FLAG : 0, denali->reg + DMA_ENABLE);\n-\tioread32(denali->reg + DMA_ENABLE);\n-}\n-\n static void denali_setup_dma64(struct denali_nand_info *denali,\n \t\t\t dma_addr_t dma_addr, int page, int write)\n {\n@@ -619,7 +612,7 @@ static int denali_dma_xfer(struct denali_nand_info *denali, void *buf,\n \t\tecc_err_mask = INTR__ECC_ERR;\n \t}\n \n-\tdenali_enable_dma(denali, true);\n+\tiowrite32(DMA_ENABLE__FLAG, denali->reg + DMA_ENABLE);\n \n \tdenali_reset_irq(denali);\n \tdenali_setup_dma(denali, dma_addr, page, write);\n@@ -631,7 +624,8 @@ static int denali_dma_xfer(struct denali_nand_info *denali, void *buf,\n \telse if (irq_status & ecc_err_mask)\n \t\tret = -EBADMSG;\n \n-\tdenali_enable_dma(denali, false);\n+\tiowrite32(0, denali->reg + DMA_ENABLE);\n+\n \tdma_unmap_single(denali->dev, dma_addr, size, dir);\n \n \tif (irq_status & INTR__ERASED_PAGE)\n","prefixes":["4/9"]}