{"id":812290,"url":"http://patchwork.ozlabs.org/api/1.2/patches/812290/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1505123379-12144-1-git-send-email-wangyunjian@huawei.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.2/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505123379-12144-1-git-send-email-wangyunjian@huawei.com>","list_archive_url":null,"date":"2017-09-11T09:49:39","name":"[ovs-dev] conntrack: Fix conn_type need be checked when remove rev_conn.","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"66bfb8917e6648444d0e2576d50be946128eab75","submitter":{"id":69073,"url":"http://patchwork.ozlabs.org/api/1.2/people/69073/?format=json","name":"Yunjian Wang","email":"wangyunjian@huawei.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1505123379-12144-1-git-send-email-wangyunjian@huawei.com/mbox/","series":[{"id":2465,"url":"http://patchwork.ozlabs.org/api/1.2/series/2465/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=2465","date":"2017-09-11T09:49:39","name":"[ovs-dev] conntrack: Fix conn_type need be checked when remove rev_conn.","version":1,"mbox":"http://patchwork.ozlabs.org/series/2465/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812290/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812290/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrNTW2gsHz9s7G\n\tfor ;\n\tMon, 11 Sep 2017 19:50:39 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 8715DBA2;\n\tMon, 11 Sep 2017 09:50:16 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 81472B88\n\tfor ; Mon, 11 Sep 2017 09:50:14 +0000 (UTC)","from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 6C532A4\n\tfor ; Mon, 11 Sep 2017 09:50:13 +0000 (UTC)","from 172.30.72.59 (EHLO DGGEMS404-HUB.china.huawei.com)\n\t([172.30.72.59])\n\tby dggrg05-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DHB81134; Mon, 11 Sep 2017 17:50:03 +0800 (CST)","from localhost (10.177.24.66) by DGGEMS404-HUB.china.huawei.com\n\t(10.3.19.204) with Microsoft SMTP Server id 14.3.301.0;\n\tMon, 11 Sep 2017 17:49:53 +0800"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","From":"w00273186 ","To":"","Date":"Mon, 11 Sep 2017 17:49:39 +0800","Message-ID":"<1505123379-12144-1-git-send-email-wangyunjian@huawei.com>","X-Mailer":"git-send-email 1.9.5.msysgit.1","MIME-Version":"1.0","X-Originating-IP":"[10.177.24.66]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A020206.59B65C4B.0142, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"d6870140c2ee0f01017017d53398897a","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RP_MATCHES_RCVD\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"huanglili.huang@huawei.com, blp@ovs.org","Subject":"[ovs-dev] [PATCH] conntrack: Fix conn_type need be checked when\n\tremove rev_conn.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"From: Yunjian Wang \n\nThe rev_conn need will be removed, only when conn_type is CT_CONN_TYPE_UN_NAT.\nThis crash will be triggered when remove conn in ct-clean thread.\n\nReported-by: Lili Huang \nSigned-off-by: Yunjian Wang \n---\n lib/conntrack.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/lib/conntrack.c b/lib/conntrack.c\nindex 419cb1d..c1adb56 100644\n--- a/lib/conntrack.c\n+++ b/lib/conntrack.c\n@@ -684,9 +684,10 @@ nat_clean(struct conntrack *ct, struct conn *conn,\n \n /* In the unlikely event, rev conn was recreated, then skip\n * rev_conn cleanup. */\n- if (rev_conn && (!nat_conn_key_node ||\n- conn_key_cmp(&nat_conn_key_node->value,\n- &rev_conn->rev_key))) {\n+ if (rev_conn &&\n+ (rev_conn->conn_type == CT_CONN_TYPE_UN_NAT) &&\n+ (!nat_conn_key_node || conn_key_cmp(&nat_conn_key_node->value,\n+ &rev_conn->rev_key))) {\n hmap_remove(&ct->buckets[bucket_rev_conn].connections,\n &rev_conn->node);\n free(rev_conn);\n","prefixes":["ovs-dev"]}