{"id":812211,"url":"http://patchwork.ozlabs.org/api/1.2/patches/812211/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/fcac7d078947b59e47ad4474d2c60d4fd3395bcd.1505095255.git.joe@perches.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-11T02:02:25","name":"net: tcp_input: Neaten DBGUNDO","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"ffc75b33af34fe6469678ee225391f2a2e6a0c45","submitter":{"id":771,"url":"http://patchwork.ozlabs.org/api/1.2/people/771/?format=json","name":"Joe Perches","email":"joe@perches.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/fcac7d078947b59e47ad4474d2c60d4fd3395bcd.1505095255.git.joe@perches.com/mbox/","series":[{"id":2430,"url":"http://patchwork.ozlabs.org/api/1.2/series/2430/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=2430","date":"2017-09-11T02:02:25","name":"net: tcp_input: Neaten DBGUNDO","version":1,"mbox":"http://patchwork.ozlabs.org/series/2430/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812211/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812211/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrB5X68dyz9s7g\n\tfor ;\n\tMon, 11 Sep 2017 12:02:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752251AbdIKCCa (ORCPT );\n\tSun, 10 Sep 2017 22:02:30 -0400","from smtprelay0027.hostedemail.com ([216.40.44.27]:60435 \"EHLO\n\tsmtprelay.hostedemail.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1752120AbdIKCC2 (ORCPT\n\t); Sun, 10 Sep 2017 22:02:28 -0400","from filter.hostedemail.com (clb03-v110.bra.tucows.net\n\t[216.40.38.60])\n\tby smtprelay08.hostedemail.com (Postfix) with ESMTP id 00DF3182CED2A; \n\tMon, 11 Sep 2017 02:02:28 +0000 (UTC)","from joe-laptop.perches.com (unknown [47.151.132.55])\n\t(Authenticated sender: joe@perches.com)\n\tby omf06.hostedemail.com (Postfix) with ESMTPA;\n\tMon, 11 Sep 2017 02:02:26 +0000 (UTC)"],"X-Session-Marker":"6A6F6540706572636865732E636F6D","X-Spam-Summary":"2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::::,\n\tRULES_HIT:41:355:379:541:800:960:968:973:988:989:1260:1345:1437:1534:1541:1711:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3352:3865:3866:3868:3871:3874:4250:4321:4419:5007:6261:10004:10848:11026:11658:11914:12043:12296:12438:12555:12895:13069:13311:13357:14096:14181:14384:14394:14721:14915:21080:21451:21611:21627:30054,\n\t0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5,\n\tNetcheck:none, DomainCache:0, MSF:not bulk, SPF:, MSBL:0,\n\tDNSBL:none, Custom_rules:0:0:0, LFtime:1, LUA_SUMMARY:none","X-HE-Tag":"rub31_327b6a3dc1446","X-Filterd-Recvd-Size":"1714","From":"Joe Perches ","To":"\"David S. Miller\" ,\n\tAlexey Kuznetsov ,\n\tHideaki YOSHIFUJI ","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"[PATCH] net: tcp_input: Neaten DBGUNDO","Date":"Sun, 10 Sep 2017 19:02:25 -0700","Message-Id":"","X-Mailer":"git-send-email 2.10.0.rc2.1.g053435c","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Move the #ifdef into the static void function so that the use\nof DBGUNDO is validated when FASTRETRANS_DEBUG <= 1.\n\nRemove the now unnecessary #else and #define DBGUNDO.\n\nSigned-off-by: Joe Perches \n---\n net/ipv4/tcp_input.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c\nindex c5d7656beeee..bddf724f5c02 100644\n--- a/net/ipv4/tcp_input.c\n+++ b/net/ipv4/tcp_input.c\n@@ -2333,9 +2333,9 @@ static bool tcp_any_retrans_done(const struct sock *sk)\n \treturn false;\n }\n \n-#if FASTRETRANS_DEBUG > 1\n static void DBGUNDO(struct sock *sk, const char *msg)\n {\n+#if FASTRETRANS_DEBUG > 1\n \tstruct tcp_sock *tp = tcp_sk(sk);\n \tstruct inet_sock *inet = inet_sk(sk);\n \n@@ -2357,10 +2357,8 @@ static void DBGUNDO(struct sock *sk, const char *msg)\n \t\t\t tp->packets_out);\n \t}\n #endif\n-}\n-#else\n-#define DBGUNDO(x...) do { } while (0)\n #endif\n+}\n \n static void tcp_undo_cwnd_reduction(struct sock *sk, bool unmark_loss)\n {\n","prefixes":[]}