{"id":812134,"url":"http://patchwork.ozlabs.org/api/1.2/patches/812134/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170910124539.13808-1-dlebrun@google.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170910124539.13808-1-dlebrun@google.com>","list_archive_url":null,"date":"2017-09-10T12:45:39","name":"[net] ipv6: sr: remove duplicate routing header type check","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"f97a64e2715969aa6752693361f11141dac82d53","submitter":{"id":72340,"url":"http://patchwork.ozlabs.org/api/1.2/people/72340/?format=json","name":"David Lebrun","email":"target0@geeknode.org"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170910124539.13808-1-dlebrun@google.com/mbox/","series":[{"id":2398,"url":"http://patchwork.ozlabs.org/api/1.2/series/2398/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=2398","date":"2017-09-10T12:45:39","name":"[net] ipv6: sr: remove duplicate routing header type check","version":1,"mbox":"http://patchwork.ozlabs.org/series/2398/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812134/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812134/checks/","tags":{},"related":[],"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"AF5CWYNj\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xqrNv71lsz9s7m\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun, 10 Sep 2017 22:44:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751540AbdIJMoo (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 10 Sep 2017 08:44:44 -0400","from mail-wm0-f65.google.com ([74.125.82.65]:34322 \"EHLO\n\tmail-wm0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751469AbdIJMon (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sun, 10 Sep 2017 08:44:43 -0400","by mail-wm0-f65.google.com with SMTP id l19so4828913wmi.1\n\tfor <netdev@vger.kernel.org>; Sun, 10 Sep 2017 05:44:43 -0700 (PDT)","from localhost.localdomain (shingan.ethylix.be. [194.110.69.82])\n\tby smtp.gmail.com with ESMTPSA id\n\tf188sm8522137wme.21.2017.09.10.05.44.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSun, 10 Sep 2017 05:44:41 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id;\n\tbh=uHWl07jFK9+E3i3UiftAGQNBCtI3JBWTIZEn6RBXPGw=;\n\tb=AF5CWYNjrUxZ48GpH2skbBsTxBiSSdap89owYoov6T4tUAopnhzwgAn20Yvn/Smxig\n\tt2QDvVJiMjT39YRLrfAacql5bxnZ1hw4BNG7EMrOzA0eModLKQaHiRDD1Rw3acgrY4GW\n\tFHSrW18lUmVQmaQb1p/GtXJQTZCT9v8oLwms8zLtpvdKzvh1yfwfSauOh68Y5J02eo4D\n\tEDRWX3wgrFMv+3pfNV5KfdZxsAZAUIzwJYtdWsNity1lY78+CueeGfkJpKqBHpX5ARlm\n\t6pmBoc61QEofK+RCHRiT+jbV3TtBnhxCBOomKaZIifEsIumhkGSMbidfZkXTOV5UFgat\n\tbAug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id;\n\tbh=uHWl07jFK9+E3i3UiftAGQNBCtI3JBWTIZEn6RBXPGw=;\n\tb=okiE10YF/dAoJ/KKfmUmfkWfLWo5DcInU/hkW8FCzMWJKX3gJaRpxi7Z/xYwYcC75O\n\taXyJxKo/OGaa4lAotrP+J5w755euhb99bCd/uq0xT4ovIBNi1tZ4yTDa90ZTM1nVy7m8\n\thLzWAcfl6MzMkshtFvxMHe63O9aXzTTCiffeCigyCfv/lDwqfcNcui7QkfNnfzOHUYP2\n\tag1Q5870NYRwi9fRpcZQoNDp7bm8yz9xy+z7uNz1epGJ7Evri0kX1+w6MaAAub4tnYxB\n\th9r2qLifQuAv0ExGAXiiCttLA3IGsAX0D+fV/86/kSeAXjKHaLmgG4zomiHQZ1mLul0D\n\tCbig==","X-Gm-Message-State":"AHPjjUjRGkWV7awyP6o7hv5DjFoqxjrorRM2UPSScXw6Iq7SCiw9Y1HB\n\tpcaDJUDUBj9+hT5cSWP7737PW4VUk1E=","X-Google-Smtp-Source":"AOwi7QA7E60ooSRnfIs9ThAtCV8/ZLidyHfnq2OHcj8otYYOo12pAf1C/zWyfisphIcXBQzbbi9GgA==","X-Received":"by 10.28.144.1 with SMTP id s1mr6407193wmd.142.1505047482292;\n\tSun, 10 Sep 2017 05:44:42 -0700 (PDT)","From":"David Lebrun <target0@geeknode.org>","X-Google-Original-From":"David Lebrun <dlebrun@google.com>","To":"netdev@vger.kernel.org","Cc":"David Lebrun <dav.lebrun@gmail.com>, David Lebrun <dlebrun@google.com>","Subject":"[PATCH net] ipv6: sr: remove duplicate routing header type check","Date":"Sun, 10 Sep 2017 13:45:39 +0100","Message-Id":"<20170910124539.13808-1-dlebrun@google.com>","X-Mailer":"git-send-email 2.10.2","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: David Lebrun <dav.lebrun@gmail.com>\n\nFrom: David Lebrun <dlebrun@google.com>\n\nAs seg6_validate_srh() already checks that the Routing Header type is\ncorrect, it is not necessary to do it again in get_srh().\n\nFixes: 5829d70b (\"ipv6: sr: fix get_srh() to comply with IPv6 standard \"RFC 8200\")\nSigned-off-by: David Lebrun <dlebrun@google.com>\n---\n net/ipv6/seg6_local.c | 4 ----\n 1 file changed, 4 deletions(-)","diff":"diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c\nindex 7ff54db..825b8e0 100644\n--- a/net/ipv6/seg6_local.c\n+++ b/net/ipv6/seg6_local.c\n@@ -72,10 +72,6 @@ static struct ipv6_sr_hdr *get_srh(struct sk_buff *skb)\n \n \tsrh = (struct ipv6_sr_hdr *)(skb->data + srhoff);\n \n-\t/* make sure it's a Segment Routing header (Routing Type 4) */\n-\tif (srh->type != IPV6_SRCRT_TYPE_4)\n-\t\treturn NULL;\n-\n \tlen = (srh->hdrlen + 1) << 3;\n \n \tif (!pskb_may_pull(skb, srhoff + len))\n","prefixes":["net"]}