{"id":811812,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811812/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-imx/patch/e70ee5587d158f0e9725d413b0a514886a3174dc.1504898151.git.hns@goldelico.com/","project":{"id":19,"url":"http://patchwork.ozlabs.org/api/1.2/projects/19/?format=json","name":"Linux IMX development","link_name":"linux-imx","list_id":"linux-imx-kernel.lists.patchwork.ozlabs.org","list_email":"linux-imx-kernel@lists.patchwork.ozlabs.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-08T19:15:51","name":"omap2: hsmmc: fix logic to call either omap_hsmmc_init or omap_hsmmc_late_init but not both","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7c92e171ce0209f1ff2524acc17b16f2eebac60b","submitter":{"id":42442,"url":"http://patchwork.ozlabs.org/api/1.2/people/42442/?format=json","name":"H. Nikolaus Schaller","email":"hns@goldelico.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-imx/patch/e70ee5587d158f0e9725d413b0a514886a3174dc.1504898151.git.hns@goldelico.com/mbox/","series":[{"id":2279,"url":"http://patchwork.ozlabs.org/api/1.2/series/2279/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-imx/list/?series=2279","date":"2017-09-08T19:15:51","name":"omap2: hsmmc: fix logic to call either omap_hsmmc_init or omap_hsmmc_late_init but not both","version":1,"mbox":"http://patchwork.ozlabs.org/series/2279/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811812/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811812/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"VQzFfNw2\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=goldelico.com header.i=@goldelico.com\n\theader.b=\"lZDHyXb/\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpn9z5Hzhz9sRV\n\tfor ;\n\tSat, 9 Sep 2017 05:16:39 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dqOlX-0002Vi-O9; Fri, 08 Sep 2017 19:16:35 +0000","from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::2])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dqOlT-0002PF-EX for linux-arm-kernel@lists.infradead.org;\n\tFri, 08 Sep 2017 19:16:33 +0000","from localhost.localdomain (p57AE02FA.dip0.t-ipconnect.de\n\t[87.174.2.250]) by smtp.strato.de (RZmta 41.4 DYNA|AUTH)\n\twith ESMTPSA id Y0a1b6t88JFqgFX\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve\n\tsecp521r1 with 521 ECDH bits, eq. 15360 bits RSA))\n\t(Client did not present a certificate);\n\tFri, 8 Sep 2017 21:15:52 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To\n\t:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=F7OhKqLFA6XCEdr4oclAn8Ky2H9ip6G6gYX7oryEENQ=;\n\tb=VQzFfNw2pLhuV3\n\tIN9ib9FdFmISPYvREtMwKcEriv5PgoqBAsFunqTcaVTunj8WaXDPwmNN2c9VLDYbr58K3uXb6AZxa\n\tX8muFP+5sUIvxkl4gUhaJ7kjNlNGfOGkZrWhhnxJ3Y0FxvvuQWmsiDHmPtGP7cir0BYpQX9yz8Hii\n\tBwt5IFSXXpUz66jpgGXbx2hvJMIjf3n7WzUEgNYAQbRZJTIvCt/rFAYd8iYHjVGaJSO34oYbHIJk9\n\tpWW8U86ftxfPvHJ7nircLqyG9Xh1nG3Qh7r3CPOcNcHTg0/cCGkFQuYWV6n6OXIBvNWC/le383pCA\n\tNRYglJsflGPRqigg0+eg==;","v=1; a=rsa-sha256; c=relaxed/relaxed; t=1504898158;\n\ts=domk; d=goldelico.com;\n\th=Content-Transfer-Encoding:Content-Type:MIME-Version:Date:Subject:Cc:\n\tTo:From; bh=X2UKCIRyb7sXp6Rb50k0Alem9VtMvrKgCdL4OOGRCtg=;\n\tb=lZDHyXb/+SBBvdsMa8tBgskW+VDG7p7oEGYkg8beKR+KYt+RyF9kdiMg8Pt/9ev11h\n\t4LuyZmn+CFIq3fO3/8nN2oPpVIQEYQu60da2/HcAVBNS9U1M39/l1AkUb+2DepHIMO/Z\n\t+eL2vBiHISOQrQ5ARW8D09xvUK2lnn/0trZXI="],"X-RZG-AUTH":":JGIXVUS7cutRB/49FwqZ7WcecEarQROEYabkiUo6mSAGQ+qKIDwoIDdYJQ==","X-RZG-CLASS-ID":"mo00","From":"\"H. Nikolaus Schaller\" ","To":"hns@goldelico.com, Tony Lindgren ,\n\tRussell King ","Subject":"[PATCH] omap2: hsmmc: fix logic to call either omap_hsmmc_init or\n\tomap_hsmmc_late_init but not both","Date":"Fri, 8 Sep 2017 21:15:51 +0200","Message-Id":"","X-Mailer":"git-send-email 2.12.2","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170908_121631_685243_C68DD3A8 ","X-CRM114-Status":"GOOD ( 12.66 )","X-Spam-Score":"-2.7 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2a01:238:20a:202:5300:0:0:2 listed in] [list.dnswl.org]\n\t-0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"letux-kernel@openphoenux.org, linux-omap@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"},"content":"With 4.13 kernel I get this boot message:\n\n[    1.051727] ------------[ cut here ]------------\n[    1.051818] WARNING: CPU: 0 PID: 1 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x54/0x74\n[    1.051849] sysfs: cannot create duplicate filename '/devices/platform/omap_hsmmc.2'\n[    1.051879] Modules linked in:\n[    1.051971] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.13.0-letux+ #1360\n[    1.052001] Hardware name: Generic OMAP3 (Flattened Device Tree)\n[    1.052062] [] (unwind_backtrace) from [] (show_stack+0x10/0x14)\n[    1.052124] [] (show_stack) from [] (dump_stack+0x98/0xd0)\n[    1.052185] [] (dump_stack) from [] (__warn+0xd0/0x100)\n[    1.052215] [] (__warn) from [] (warn_slowpath_fmt+0x34/0x44)\n[    1.052276] [] (warn_slowpath_fmt) from [] (sysfs_warn_dup+0x54/0x74)\n[    1.052337] [] (sysfs_warn_dup) from [] (sysfs_create_dir_ns+0x74/0x84)\n[    1.052398] [] (sysfs_create_dir_ns) from [] (kobject_add_internal+0xd0/0x294)\n[    1.052429] [] (kobject_add_internal) from [] (kobject_add+0x6c/0x8c)\n[    1.052490] [] (kobject_add) from [] (device_add+0xe4/0x510)\n[    1.052551] [] (device_add) from [] (platform_device_add+0x130/0x1c0)\n[    1.052612] [] (platform_device_add) from [] (omap_hsmmc_late_init+0x3c/0x60)\n[    1.052673] [] (omap_hsmmc_late_init) from [] (omap3_pandora_legacy_init+0x24/0xb4)\n[    1.052734] [] (omap3_pandora_legacy_init) from [] (pdata_quirks_check+0x30/0x3c)\n[    1.052795] [] (pdata_quirks_check) from [] (omap_generic_init+0xc/0x18)\n[    1.052856] [] (omap_generic_init) from [] (customize_machine+0x1c/0x28)\n[    1.052917] [] (customize_machine) from [] (do_one_initcall+0xa8/0x150)\n[    1.052947] [] (do_one_initcall) from [] (kernel_init_freeable+0x110/0x1d4)\n[    1.053009] [] (kernel_init_freeable) from [] (kernel_init+0x8/0x10c)\n[    1.053070] [] (kernel_init) from [] (ret_from_fork+0x14/0x24)\n[    1.055023] ---[ end trace 44e490b09ac4ab88 ]---\n\nThis can be traced down to the calls of\n\n\tomap_hsmmc_init(pandora_mmc3);\n\tomap_hsmmc_late_init(pandora_mmc3);\n\nin omap3_pandora_legacy_init().\n\nIt turns out that both funcions disagree how to decide if the other one was alredy called.\n\nSigned-off-by: H. Nikolaus Schaller \n---\n arch/arm/mach-omap2/hsmmc.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/arch/arm/mach-omap2/hsmmc.c b/arch/arm/mach-omap2/hsmmc.c\nindex 5b614388d72f..6d28aa20a7d3 100644\n--- a/arch/arm/mach-omap2/hsmmc.c\n+++ b/arch/arm/mach-omap2/hsmmc.c\n@@ -58,10 +58,10 @@ void omap_hsmmc_late_init(struct omap2_hsmmc_info *c)\n \tstruct platform_device *pdev;\n \tint res;\n \n-\tif (omap_hsmmc_done != 1)\n+\tif (omap_hsmmc_done)\n \t\treturn;\n \n-\tomap_hsmmc_done++;\n+\tomap_hsmmc_done = 1;\n \n \tfor (; c->mmc; c++) {\n \t\tpdev = c->pdev;\n","prefixes":[]}