{"id":811791,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811791/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1504894024-2750-10-git-send-email-ldufour@linux.vnet.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<1504894024-2750-10-git-send-email-ldufour@linux.vnet.ibm.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/1504894024-2750-10-git-send-email-ldufour@linux.vnet.ibm.com/","date":"2017-09-08T18:06:53","name":"[v3,09/20] mm/migrate: Pass vm_fault pointer to migrate_misplaced_page()","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"89dbb5bc3a216da76f1094a4619d5b385a9d9df2","submitter":{"id":40248,"url":"http://patchwork.ozlabs.org/api/1.2/people/40248/?format=json","name":"Laurent Dufour","email":"ldufour@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1504894024-2750-10-git-send-email-ldufour@linux.vnet.ibm.com/mbox/","series":[{"id":2269,"url":"http://patchwork.ozlabs.org/api/1.2/series/2269/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=2269","date":"2017-09-08T18:06:44","name":"Speculative page faults","version":3,"mbox":"http://patchwork.ozlabs.org/series/2269/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811791/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811791/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpmKg0j5lz9s82\n\tfor ;\n\tSat, 9 Sep 2017 04:38:15 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xpmKf6hfRzDrJL\n\tfor ;\n\tSat, 9 Sep 2017 04:38:14 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xplfV1LxszDrX7\n\tfor ;\n\tSat, 9 Sep 2017 04:07:46 +1000 (AEST)","from pps.filterd (m0098393.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv88I6pYl109182\n\tfor ; Fri, 8 Sep 2017 14:07:44 -0400","from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cuvgwkkkr-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 08 Sep 2017 14:07:44 -0400","from localhost\n\tby e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 8 Sep 2017 19:07:41 +0100","from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196)\n\tby e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tFri, 8 Sep 2017 19:07:35 +0100","from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60])\n\tby b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v88I7ZEK23265518; Fri, 8 Sep 2017 18:07:35 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 3370D42045;\n\tFri, 8 Sep 2017 19:04:02 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 73AE74203F;\n\tFri, 8 Sep 2017 19:04:00 +0100 (BST)","from nimbus.lab.toulouse-stg.fr.ibm.com (unknown [9.145.31.125])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tFri, 8 Sep 2017 19:04:00 +0100 (BST)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=ldufour@linux.vnet.ibm.com; receiver=)","From":"Laurent Dufour ","To":"paulmck@linux.vnet.ibm.com, peterz@infradead.org,\n\takpm@linux-foundation.org, kirill@shutemov.name, ak@linux.intel.com, \n\tmhocko@kernel.org, dave@stgolabs.net, jack@suse.cz,\n\tMatthew Wilcox , benh@kernel.crashing.org,\n\tmpe@ellerman.id.au, paulus@samba.org,\n\tThomas Gleixner , Ingo Molnar , \n\thpa@zytor.com, Will Deacon ,\n\tSergey Senozhatsky ","Subject":"[PATCH v3 09/20] mm/migrate: Pass vm_fault pointer to\n\tmigrate_misplaced_page()","Date":"Fri, 8 Sep 2017 20:06:53 +0200","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1504894024-2750-1-git-send-email-ldufour@linux.vnet.ibm.com>","References":"<1504894024-2750-1-git-send-email-ldufour@linux.vnet.ibm.com>","X-TM-AS-GCONF":"00","x-cbid":"17090818-0008-0000-0000-000004959E61","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090818-0009-0000-0000-00001E26A5F1","Message-Id":"<1504894024-2750-10-git-send-email-ldufour@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-08_12:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709080270","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linuxppc-dev@lists.ozlabs.org, x86@kernel.org,\n\tlinux-kernel@vger.kernel.org, npiggin@gmail.com, linux-mm@kvack.org,\n\tTim Chen , \n\tharen@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"migrate_misplaced_page() is only called during the page fault handling so\nit's better to pass the pointer to the struct vm_fault instead of the vma.\n\nThis way during the speculative page fault path the saved vma->vm_flags\ncould be used.\n\nSigned-off-by: Laurent Dufour \n---\n include/linux/migrate.h | 4 ++--\n mm/memory.c | 2 +-\n mm/migrate.c | 4 ++--\n 3 files changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/include/linux/migrate.h b/include/linux/migrate.h\nindex 643c7ae7d7b4..a815ed6838b3 100644\n--- a/include/linux/migrate.h\n+++ b/include/linux/migrate.h\n@@ -126,14 +126,14 @@ static inline void __ClearPageMovable(struct page *page)\n #ifdef CONFIG_NUMA_BALANCING\n extern bool pmd_trans_migrating(pmd_t pmd);\n extern int migrate_misplaced_page(struct page *page,\n-\t\t\t\t struct vm_area_struct *vma, int node);\n+\t\t\t\t struct vm_fault *vmf, int node);\n #else\n static inline bool pmd_trans_migrating(pmd_t pmd)\n {\n \treturn false;\n }\n static inline int migrate_misplaced_page(struct page *page,\n-\t\t\t\t\t struct vm_area_struct *vma, int node)\n+\t\t\t\t\t struct vm_fault *vmf, int node)\n {\n \treturn -EAGAIN; /* can't migrate now */\n }\ndiff --git a/mm/memory.c b/mm/memory.c\nindex 401b13cbfc3c..a4982917c16e 100644\n--- a/mm/memory.c\n+++ b/mm/memory.c\n@@ -3790,7 +3790,7 @@ static int do_numa_page(struct vm_fault *vmf)\n \t}\n \n \t/* Migrate to the requested node */\n-\tmigrated = migrate_misplaced_page(page, vma, target_nid);\n+\tmigrated = migrate_misplaced_page(page, vmf, target_nid);\n \tif (migrated) {\n \t\tpage_nid = target_nid;\n \t\tflags |= TNF_MIGRATED;\ndiff --git a/mm/migrate.c b/mm/migrate.c\nindex 6954c1435833..4e8e22b9df8f 100644\n--- a/mm/migrate.c\n+++ b/mm/migrate.c\n@@ -1939,7 +1939,7 @@ bool pmd_trans_migrating(pmd_t pmd)\n * node. Caller is expected to have an elevated reference count on\n * the page that will be dropped by this function before returning.\n */\n-int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma,\n+int migrate_misplaced_page(struct page *page, struct vm_fault *vmf,\n \t\t\t int node)\n {\n \tpg_data_t *pgdat = NODE_DATA(node);\n@@ -1952,7 +1952,7 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma,\n \t * with execute permissions as they are probably shared libraries.\n \t */\n \tif (page_mapcount(page) != 1 && page_is_file_cache(page) &&\n-\t (vma->vm_flags & VM_EXEC))\n+\t (vmf->vma_flags & VM_EXEC))\n \t\tgoto out;\n \n \t/*\n","prefixes":["v3","09/20"]}