{"id":811737,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811737/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/1504892748-1605-5-git-send-email-pablo@netfilter.org/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.2/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504892748-1605-5-git-send-email-pablo@netfilter.org>","list_archive_url":null,"date":"2017-09-08T17:45:43","name":"[4/9] netfilter: xtables: add scheduling opportunity in get_counters","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8059c0fea50c5bd80fd17fc19238f2564ba262db","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/1.2/people/1315/?format=json","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"delegate":{"id":6139,"url":"http://patchwork.ozlabs.org/api/1.2/users/6139/?format=json","username":"pablo","first_name":"Pablo","last_name":"Neira","email":"pablo@netfilter.org"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/1504892748-1605-5-git-send-email-pablo@netfilter.org/mbox/","series":[{"id":2261,"url":"http://patchwork.ozlabs.org/api/1.2/series/2261/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=2261","date":"2017-09-08T17:45:46","name":"[1/9] netfilter: ipvs: fix the issue that sctp_conn_schedule drops non-INIT packet","version":1,"mbox":"http://patchwork.ozlabs.org/series/2261/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811737/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811737/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xplBK0YWvz9s8J\n\tfor ;\n\tSat, 9 Sep 2017 03:46:48 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756784AbdIHRqE (ORCPT );\n\tFri, 8 Sep 2017 13:46:04 -0400","from mail.us.es ([193.147.175.20]:54490 \"EHLO mail.us.es\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1756737AbdIHRqC (ORCPT );\n\tFri, 8 Sep 2017 13:46:02 -0400","from antivirus1-rhel7.int (unknown [192.168.2.11])\n\tby mail.us.es (Postfix) with ESMTP id EDAB88D0508\n\tfor ;\n\tFri, 8 Sep 2017 19:45:30 +0200 (CEST)","from antivirus1-rhel7.int (localhost [127.0.0.1])\n\tby antivirus1-rhel7.int (Postfix) with ESMTP id D403AB502D\n\tfor ;\n\tFri, 8 Sep 2017 19:45:30 +0200 (CEST)","by antivirus1-rhel7.int (Postfix, from userid 99)\n\tid C9BBEB502A; Fri, 8 Sep 2017 19:45:30 +0200 (CEST)","from antivirus1-rhel7.int (localhost [127.0.0.1])\n\tby antivirus1-rhel7.int (Postfix) with ESMTP id BF318B5024;\n\tFri, 8 Sep 2017 19:45:28 +0200 (CEST)","from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int\n\t(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); \n\tFri, 08 Sep 2017 19:45:28 +0200 (CEST)","from salvia.here (129.166.216.87.static.jazztel.es\n\t[87.216.166.129]) (Authenticated sender: pneira@us.es)\n\tby entrada.int (Postfix) with ESMTPA id 6F51144581E0;\n\tFri, 8 Sep 2017 19:45:28 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.1 (2015-04-28) on\n\tantivirus1-rhel7.int","X-Spam-Level":"","X-Spam-Status":"No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50,\n\tSMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1","X-Virus-Status":"clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int)","X-SMTPAUTHUS":"auth mail.us.es","From":"Pablo Neira Ayuso ","To":"netfilter-devel@vger.kernel.org","Cc":"davem@davemloft.net, netdev@vger.kernel.org","Subject":"[PATCH 4/9] netfilter: xtables: add scheduling opportunity in\n\tget_counters","Date":"Fri, 8 Sep 2017 19:45:43 +0200","Message-Id":"<1504892748-1605-5-git-send-email-pablo@netfilter.org>","X-Mailer":"git-send-email 2.1.4","In-Reply-To":"<1504892748-1605-1-git-send-email-pablo@netfilter.org>","References":"<1504892748-1605-1-git-send-email-pablo@netfilter.org>","X-Virus-Scanned":"ClamAV using ClamSMTP","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"},"content":"From: Florian Westphal \n\nThere are reports about spurious softlockups during iptables-restore, a\nbacktrace i saw points at get_counters -- it uses a sequence lock and also\nhas unbounded restart loop.\n\nSigned-off-by: Florian Westphal \nAcked-by: Eric Dumazet \nSigned-off-by: Pablo Neira Ayuso \n---\n net/ipv4/netfilter/arp_tables.c | 1 +\n net/ipv4/netfilter/ip_tables.c | 1 +\n net/ipv6/netfilter/ip6_tables.c | 1 +\n 3 files changed, 3 insertions(+)","diff":"diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c\nindex e04457198f93..9e2770fd00be 100644\n--- a/net/ipv4/netfilter/arp_tables.c\n+++ b/net/ipv4/netfilter/arp_tables.c\n@@ -629,6 +629,7 @@ static void get_counters(const struct xt_table_info *t,\n \n \t\t\tADD_COUNTER(counters[i], bcnt, pcnt);\n \t\t\t++i;\n+\t\t\tcond_resched();\n \t\t}\n \t}\n }\ndiff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c\nindex 576cba2b57e9..39286e543ee6 100644\n--- a/net/ipv4/netfilter/ip_tables.c\n+++ b/net/ipv4/netfilter/ip_tables.c\n@@ -776,6 +776,7 @@ get_counters(const struct xt_table_info *t,\n \n \t\t\tADD_COUNTER(counters[i], bcnt, pcnt);\n \t\t\t++i; /* macro does multi eval of i */\n+\t\t\tcond_resched();\n \t\t}\n \t}\n }\ndiff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c\nindex 54b1e75eded1..01bd3ee5ebc6 100644\n--- a/net/ipv6/netfilter/ip6_tables.c\n+++ b/net/ipv6/netfilter/ip6_tables.c\n@@ -795,6 +795,7 @@ get_counters(const struct xt_table_info *t,\n \n \t\t\tADD_COUNTER(counters[i], bcnt, pcnt);\n \t\t\t++i;\n+\t\t\tcond_resched();\n \t\t}\n \t}\n }\n","prefixes":["4/9"]}