{"id":811679,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811679/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908163859.29820-1-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170908163859.29820-1-richard.henderson@linaro.org>","list_archive_url":null,"date":"2017-09-08T16:38:59","name":"target/arm: Avoid an extra temporary for store_exclusive","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"124b1e54a77d8f50a08e48edabc01bd31bc388f6","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.2/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908163859.29820-1-richard.henderson@linaro.org/mbox/","series":[{"id":2246,"url":"http://patchwork.ozlabs.org/api/1.2/series/2246/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2246","date":"2017-09-08T16:38:59","name":"target/arm: Avoid an extra temporary for store_exclusive","version":1,"mbox":"http://patchwork.ozlabs.org/series/2246/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811679/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811679/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"e/CVhD6a\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpjj40p6Pz9s8J\n\tfor ;\n\tSat, 9 Sep 2017 02:39:52 +1000 (AEST)","from localhost ([::1]:46424 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqMJq-0005AW-4G\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 12:39:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46060)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqMJA-00058Q-7F\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 12:39:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqMJ5-00060a-GV\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 12:39:08 -0400","from mail-pg0-x22f.google.com ([2607:f8b0:400e:c05::22f]:37156)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqMJ5-00060K-B2\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 12:39:03 -0400","by mail-pg0-x22f.google.com with SMTP id d8so5682378pgt.4\n\tfor ; Fri, 08 Sep 2017 09:39:03 -0700 (PDT)","from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net.\n\t[97.126.108.236]) by smtp.gmail.com with ESMTPSA id\n\tq28sm4515173pfj.77.2017.09.08.09.39.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 08 Sep 2017 09:39:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id;\n\tbh=idWlPc4sVNdDvysx4VVV5IIav5gIxi0kIVm3/FP7va4=;\n\tb=e/CVhD6aqkDe6wMVmizPhVHg3J7CKlo4+sTYRXAwzjYgztBKVpmImupxTAF/HFFH2L\n\tDXx7UsMzeN1ubypgyZdh9TmOmUwp4tDcWVumX8EN1KX50lMoXDn1PGz9vhB01ouO/yBa\n\t7o5iFfpu6nrv+vmzAVZRi2u+d8ewFdXoh1rfQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=idWlPc4sVNdDvysx4VVV5IIav5gIxi0kIVm3/FP7va4=;\n\tb=oi3fHGocDCc/FGPWt6ygp6QQqL393WXaPNUnZtUn8SFxAPNcmDT/xilNk/qxMZsiUl\n\twpBkOMhJhWEclz/sOh+OT40Wtvu2AePytYW0QgzGL6mmiHJm8bHYgA7ImxysSxpfLyTT\n\t6zalY1OAVAs6YjKOGCCNP8Y9KUvWBbfUpYobGNlqwGEom1xP5XNGQcylReS7audLDYBE\n\tRkfQtaiKQOBqGo/KvVRFlviyhomNaYiUcN+rh8z1hF5mlYzo0cl++waB28zHiLeuzKik\n\tNZp3qSi/3ApBfxcvA5KGlUSBNyzbwjMqD2RfmCY9utmykL8OnlhZf1F3mJmmrlQwoDlx\n\tINtg==","X-Gm-Message-State":"AHPjjUjusYE6cAfGP9MHpIj68KpFwVehyaZeRx2L57VkmciaUjfLfehl\n\txIwxA6KwWMEixt2678m4Jg==","X-Google-Smtp-Source":"ADKCNb6777LaREK3n5kaLgWvOeRp7asd0YZMWmw9PeGZNBYSDi7tIqmjW9J1KFJ+u5ZAMEHME+Nqng==","X-Received":"by 10.84.168.98 with SMTP id e89mr4084662plb.292.1504888741739; \n\tFri, 08 Sep 2017 09:39:01 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Date":"Fri, 8 Sep 2017 09:38:59 -0700","Message-Id":"<20170908163859.29820-1-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.13.5","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::22f","Subject":"[Qemu-devel] [PATCH] target/arm: Avoid an extra temporary for\n\tstore_exclusive","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, qemu-arm@nongnu.org, patches@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Instead of copying addr to a local temp, reuse the value (which we\nhave just compared as equal) already saved in cpu_exclusive_addr.\n\nSigned-off-by: Richard Henderson \n---\n target/arm/translate-a64.c | 26 +++++++++-----------------\n 1 file changed, 9 insertions(+), 17 deletions(-)","diff":"diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c\nindex 9017e30510..114e21cc58 100644\n--- a/target/arm/translate-a64.c\n+++ b/target/arm/translate-a64.c\n@@ -1894,7 +1894,7 @@ static void gen_load_exclusive(DisasContext *s, int rt, int rt2,\n }\n \n static void gen_store_exclusive(DisasContext *s, int rd, int rt, int rt2,\n- TCGv_i64 inaddr, int size, int is_pair)\n+ TCGv_i64 addr, int size, int is_pair)\n {\n /* if (env->exclusive_addr == addr && env->exclusive_val == [addr]\n * && (!is_pair || env->exclusive_high == [addr + datasize])) {\n@@ -1910,13 +1910,8 @@ static void gen_store_exclusive(DisasContext *s, int rd, int rt, int rt2,\n */\n TCGLabel *fail_label = gen_new_label();\n TCGLabel *done_label = gen_new_label();\n- TCGv_i64 addr = tcg_temp_local_new_i64();\n TCGv_i64 tmp;\n \n- /* Copy input into a local temp so it is not trashed when the\n- * basic block ends at the branch insn.\n- */\n- tcg_gen_mov_i64(addr, inaddr);\n tcg_gen_brcond_i64(TCG_COND_NE, addr, cpu_exclusive_addr, fail_label);\n \n tmp = tcg_temp_new_i64();\n@@ -1927,27 +1922,24 @@ static void gen_store_exclusive(DisasContext *s, int rd, int rt, int rt2,\n } else {\n tcg_gen_concat32_i64(tmp, cpu_reg(s, rt2), cpu_reg(s, rt));\n }\n- tcg_gen_atomic_cmpxchg_i64(tmp, addr, cpu_exclusive_val, tmp,\n+ tcg_gen_atomic_cmpxchg_i64(tmp, cpu_exclusive_addr,\n+ cpu_exclusive_val, tmp,\n get_mem_index(s),\n MO_64 | MO_ALIGN | s->be_data);\n tcg_gen_setcond_i64(TCG_COND_NE, tmp, tmp, cpu_exclusive_val);\n } else if (s->be_data == MO_LE) {\n- gen_helper_paired_cmpxchg64_le(tmp, cpu_env, addr, cpu_reg(s, rt),\n- cpu_reg(s, rt2));\n+ gen_helper_paired_cmpxchg64_le(tmp, cpu_env, cpu_exclusive_addr,\n+ cpu_reg(s, rt), cpu_reg(s, rt2));\n } else {\n- gen_helper_paired_cmpxchg64_be(tmp, cpu_env, addr, cpu_reg(s, rt),\n- cpu_reg(s, rt2));\n+ gen_helper_paired_cmpxchg64_be(tmp, cpu_env, cpu_exclusive_addr,\n+ cpu_reg(s, rt), cpu_reg(s, rt2));\n }\n } else {\n- TCGv_i64 val = cpu_reg(s, rt);\n- tcg_gen_atomic_cmpxchg_i64(tmp, addr, cpu_exclusive_val, val,\n- get_mem_index(s),\n+ tcg_gen_atomic_cmpxchg_i64(tmp, cpu_exclusive_addr, cpu_exclusive_val,\n+ cpu_reg(s, rt), get_mem_index(s),\n size | MO_ALIGN | s->be_data);\n tcg_gen_setcond_i64(TCG_COND_NE, tmp, tmp, cpu_exclusive_val);\n }\n-\n- tcg_temp_free_i64(addr);\n-\n tcg_gen_mov_i64(cpu_reg(s, rd), tmp);\n tcg_temp_free_i64(tmp);\n tcg_gen_br(done_label);\n","prefixes":[]}