{"id":811592,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811592/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1504876813-105276-1-git-send-email-michalx.weglicki@intel.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.2/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504876813-105276-1-git-send-email-michalx.weglicki@intel.com>","list_archive_url":null,"date":"2017-09-08T13:20:12","name":"[ovs-dev,v3,1/2] netdev-dpdk: extend netdev_dpdk_get_status to include if_type and if_descr","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b5cf8860e4658090199b73d75aaa7d7be14ddfdd","submitter":{"id":67395,"url":"http://patchwork.ozlabs.org/api/1.2/people/67395/?format=json","name":"Weglicki, MichalX","email":"michalx.weglicki@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1504876813-105276-1-git-send-email-michalx.weglicki@intel.com/mbox/","series":[{"id":2212,"url":"http://patchwork.ozlabs.org/api/1.2/series/2212/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=2212","date":"2017-09-08T13:20:12","name":"[ovs-dev,v3,1/2] netdev-dpdk: extend netdev_dpdk_get_status to include if_type and if_descr","version":3,"mbox":"http://patchwork.ozlabs.org/series/2212/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811592/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811592/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpdZG13nDz9s7p\n\tfor ;\n\tFri, 8 Sep 2017 23:33:41 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 2DE08A95;\n\tFri, 8 Sep 2017 13:33:36 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 767D1A92\n\tfor ; Fri, 8 Sep 2017 13:33:35 +0000 (UTC)","from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0DBA21D7\n\tfor ; Fri, 8 Sep 2017 13:33:34 +0000 (UTC)","from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga105.jf.intel.com with ESMTP; 08 Sep 2017 06:33:34 -0700","from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga002.jf.intel.com with ESMTP; 08 Sep 2017 06:33:33 -0700","from silpixa00389819.ir.intel.com (silpixa00389819.ir.intel.com\n\t[10.237.219.152])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tv88DXW7A024601; Fri, 8 Sep 2017 14:33:32 +0100"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,361,1500966000\"; d=\"scan'208\";a=\"133205762\"","From":"Michal Weglicki ","To":"dev@openvswitch.org","Date":"Fri, 8 Sep 2017 14:20:12 +0100","Message-Id":"<1504876813-105276-1-git-send-email-michalx.weglicki@intel.com>","X-Mailer":"git-send-email 1.8.3.1","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"[ovs-dev] [PATCH v3 1/2] netdev-dpdk: extend netdev_dpdk_get_status\n\tto include if_type and if_descr","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"This commit extends netdev_dpdk_get_status API to include additional\ndriver-related information: if_type and if_descr.\n\nSigned-off-by: Przemyslaw Szczerbik \nSigned-off-by: Michal Weglicki \n---\nv2-v3: Code rebase.\n---\n lib/netdev-dpdk.c | 11 +++++++++++\n 1 file changed, 11 insertions(+)","diff":"diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c\nindex f58e9be..14301dc 100644\n--- a/lib/netdev-dpdk.c\n+++ b/lib/netdev-dpdk.c\n@@ -36,6 +36,7 @@\n #include \n #include \n #include \n+#include \n \n #include \"dirs.h\"\n #include \"dp-packet.h\"\n@@ -156,6 +157,11 @@ typedef uint8_t dpdk_port_t;\n #define VHOST_ENQ_RETRY_NUM 8\n #define IF_NAME_SZ (PATH_MAX > IFNAMSIZ ? PATH_MAX : IFNAMSIZ)\n \n+/* ifType value '6' is used for all ethernet-like interfaces, regardless of\n+* speed or link-layer encapsulation in use.\n+* Cf. IETF RFC 3635 Section 3.2.4. */\n+#define IF_TYPE_ETHERNETCSMACD 6\n+\n static const struct rte_eth_conf port_conf = {\n .rxmode = {\n .mq_mode = ETH_MQ_RX_RSS,\n@@ -2446,6 +2452,11 @@ netdev_dpdk_get_status(const struct netdev *netdev, struct smap *args)\n dev_info.max_hash_mac_addrs);\n smap_add_format(args, \"max_vfs\", \"%u\", dev_info.max_vfs);\n smap_add_format(args, \"max_vmdq_pools\", \"%u\", dev_info.max_vmdq_pools);\n+ /* Once DPDK library supports retrieving ifType we should get this value\n+ * directly from DPDK rather than hardcoding it. */\n+ smap_add_format(args, \"if_type\", \"%\"PRIu32, IF_TYPE_ETHERNETCSMACD);\n+ smap_add_format(args, \"if_descr\", \"%s %s\", rte_version(),\n+ dev_info.driver_name);\n \n if (dev_info.pci_dev) {\n smap_add_format(args, \"pci-vendor_id\", \"0x%u\",\n","prefixes":["ovs-dev","v3","1/2"]}