{"id":811489,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811489/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170908103000.6795-1-kilobyte@angband.pl/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170908103000.6795-1-kilobyte@angband.pl>","list_archive_url":null,"date":"2017-09-08T10:30:00","name":"[v2] rtl8xxxu: Don't printk raw binary if serial number is not burned in.","commit_ref":null,"pull_url":null,"state":"awaiting-upstream","archived":true,"hash":"b5117febb0926af6d8a3e3ca569ed8da92982a61","submitter":{"id":27590,"url":"http://patchwork.ozlabs.org/api/1.2/people/27590/?format=json","name":"Adam Borowski","email":"kilobyte@angband.pl"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170908103000.6795-1-kilobyte@angband.pl/mbox/","series":[{"id":2176,"url":"http://patchwork.ozlabs.org/api/1.2/series/2176/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=2176","date":"2017-09-08T10:30:00","name":"[v2] rtl8xxxu: Don't printk raw binary if serial number is not burned in.","version":2,"mbox":"http://patchwork.ozlabs.org/series/2176/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811489/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811489/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpYVx4f08z9s7f\n\tfor ;\n\tFri, 8 Sep 2017 20:30:33 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753352AbdIHKaY (ORCPT );\n\tFri, 8 Sep 2017 06:30:24 -0400","from tartarus.angband.pl ([89.206.35.136]:56740 \"EHLO\n\ttartarus.angband.pl\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752248AbdIHKaW (ORCPT\n\t); Fri, 8 Sep 2017 06:30:22 -0400","from 89-71-161-30.dynamic.chello.pl ([89.71.161.30]\n\thelo=umbar.angband.pl) by tartarus.angband.pl with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)\n\t(envelope-from )\n\tid 1dqGY7-0002mM-Ha; Fri, 08 Sep 2017 12:30:18 +0200","from kilobyte by umbar.angband.pl with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dqGY6-0001mb-DQ; Fri, 08 Sep 2017 12:30:10 +0200"],"From":"Adam Borowski ","To":"Jes Sorensen , Kalle Valo ,\n\tlinux-wireless@vger.kernel.org, netdev@vger.kernel.org,\n\tStefano Brivio ","Cc":"Adam Borowski ","Date":"Fri, 8 Sep 2017 12:30:00 +0200","Message-Id":"<20170908103000.6795-1-kilobyte@angband.pl>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170908032706.1fa59da9@elisabeth>","References":"<20170908032706.1fa59da9@elisabeth>","X-SA-Exim-Connect-IP":"89.71.161.30","X-SA-Exim-Mail-From":"kilobyte@angband.pl","X-Spam-Checker-Version":"SpamAssassin 3.4.1 (2015-04-28) on tartarus","X-Spam-Level":"","X-Spam-Status":"No, score=-2.9 required=8.0 tests=ALL_TRUSTED=-1,\n\tBAYES_00=-1.9, \n\tTVD_RCVD_IP=0.001 autolearn=ham autolearn_force=no languages=","Subject":"[PATCH v2] rtl8xxxu: Don't printk raw binary if serial number is\n\tnot burned in.","X-SA-Exim-Version":"4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000)","X-SA-Exim-Scanned":"Yes (on tartarus.angband.pl)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"I assume that a blank efuse comes with all ones, thus I did not bother\nrecognizing other possible junk values. This matches 100% of dongles\nI've seen (a single Gembird 8192eu).\n\nSigned-off-by: Adam Borowski \n---\nv2: strncmp(\"goofy string\") -> memchr_inv()\n\nStefano Brivio wrote:\n> You might want to use memchr_inv():\n>\n> if (memchr_inv(efuse->serial, 0xff, 11))\n> dev_info(&priv->udev->dev, \"Serial: %.11s\\n\", efuse->serial);\n> ...\n>\n> Mostly cosmetic though.\n\nThis looks much better, thanks!\n\n\n drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c\nindex 80fee699f58a..38b2ba1ac6f8 100644\n--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c\n+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c\n@@ -614,7 +614,10 @@ static int rtl8192eu_parse_efuse(struct rtl8xxxu_priv *priv)\n \n \tdev_info(&priv->udev->dev, \"Vendor: %.7s\\n\", efuse->vendor_name);\n \tdev_info(&priv->udev->dev, \"Product: %.11s\\n\", efuse->device_name);\n-\tdev_info(&priv->udev->dev, \"Serial: %.11s\\n\", efuse->serial);\n+\tif (memchr_inv(efuse->serial, 0xff, 11))\n+\t\tdev_info(&priv->udev->dev, \"Serial: %.11s\\n\", efuse->serial);\n+\telse\n+\t\tdev_info(&priv->udev->dev, \"Serial not available.\\n\");\n \n \tif (rtl8xxxu_debug & RTL8XXXU_DEBUG_EFUSE) {\n \t\tunsigned char *raw = priv->efuse_wifi.raw;\n","prefixes":["v2"]}