{"id":811423,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811423/?format=json","web_url":"http://patchwork.ozlabs.org/project/fwts/patch/20170908094354.16144-1-colin.king@canonical.com/","project":{"id":24,"url":"http://patchwork.ozlabs.org/api/1.2/projects/24/?format=json","name":"Firmware Test Suite development","link_name":"fwts","list_id":"fwts-devel.lists.ubuntu.com","list_email":"fwts-devel@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170908094354.16144-1-colin.king@canonical.com>","list_archive_url":null,"date":"2017-09-08T09:43:54","name":"lib: fwts_formatting: make width parameter size_t","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ff5beaed7b5c95805bf5c771fb52bf0db0e10b19","submitter":{"id":2900,"url":"http://patchwork.ozlabs.org/api/1.2/people/2900/?format=json","name":"Colin Ian King","email":"colin.king@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/fwts/patch/20170908094354.16144-1-colin.king@canonical.com/mbox/","series":[{"id":2157,"url":"http://patchwork.ozlabs.org/api/1.2/series/2157/?format=json","web_url":"http://patchwork.ozlabs.org/project/fwts/list/?series=2157","date":"2017-09-08T09:43:54","name":"lib: fwts_formatting: make width parameter size_t","version":1,"mbox":"http://patchwork.ozlabs.org/series/2157/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811423/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811423/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpXTB2N63z9s4s;\n\tFri, 8 Sep 2017 19:43:58 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dqFpN-0005aN-49; Fri, 08 Sep 2017 09:43:57 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dqFpL-0005ZV-Mb\n\tfor fwts-devel@lists.ubuntu.com; Fri, 08 Sep 2017 09:43:55 +0000","from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from )\n\tid 1dqFpL-0002rA-Bn; Fri, 08 Sep 2017 09:43:55 +0000"],"From":"Colin King ","To":"fwts-devel@lists.ubuntu.com","Subject":"[PATCH] lib: fwts_formatting: make width parameter size_t","Date":"Fri, 8 Sep 2017 10:43:54 +0100","Message-Id":"<20170908094354.16144-1-colin.king@canonical.com>","X-Mailer":"git-send-email 2.14.1","MIME-Version":"1.0","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "},"content":"From: Colin Ian King \n\nLengths of string objects should really be size_t rather than int.\n\nSigned-off-by: Colin Ian King \n---\n src/lib/include/fwts_formatting.h | 2 +-\n src/lib/src/fwts_formatting.c | 8 ++++----\n 2 files changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/src/lib/include/fwts_formatting.h b/src/lib/include/fwts_formatting.h\nindex 3431c6aa..036f09e1 100644\n--- a/src/lib/include/fwts_formatting.h\n+++ b/src/lib/include/fwts_formatting.h\n@@ -22,6 +22,6 @@\n \n #include \"fwts_list.h\"\n \n-fwts_list *fwts_format_text(const char *text, const int width);\n+fwts_list *fwts_format_text(const char *text, const size_t width);\n \n #endif\ndiff --git a/src/lib/src/fwts_formatting.c b/src/lib/src/fwts_formatting.c\nindex 3b413bd3..0f661d5c 100644\n--- a/src/lib/src/fwts_formatting.c\n+++ b/src/lib/src/fwts_formatting.c\n@@ -30,9 +30,9 @@\n *\tduplicate a portion of a line of text, from start to end up to\n *\ta maximum of width characters\n */\n-static char *dup_line(const char *start, const char *end, const int width)\n+static char *dup_line(const char *start, const char *end, const size_t width)\n {\n-\tint maxlen;\n+\tsize_t maxlen;\n \tchar *buffer;\n \tchar *bufptr;\n \n@@ -83,9 +83,9 @@ static char *format_remove_multiple_whitespaces(const char *text)\n * \tgiven a text string, format it into a list of lines of\n *\ttext to a given width.\n */\n-fwts_list *fwts_format_text(const char *text, const int width)\n+fwts_list *fwts_format_text(const char *text, const size_t width)\n {\n-\tint linelen = 0;\n+\tsize_t linelen = 0;\n \tchar *lastspace = NULL;\n \tchar *tidied_text;\n \tchar *linestart;\n","prefixes":[]}