{"id":811327,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811327/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/c600e16fc4ed41d1bcc0154eef1ce8d4-mfwitten@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-08T05:06:26","name":"[2/3] net: inet_recvmsg(): Remove unnecessary bitwise operation","commit_ref":null,"pull_url":null,"state":"deferred","archived":true,"hash":"8aa798b63def78fc07fcfeda5dd36a5b7c9fa685","submitter":{"id":7859,"url":"http://patchwork.ozlabs.org/api/1.2/people/7859/?format=json","name":"Michael Witten","email":"mfwitten@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/c600e16fc4ed41d1bcc0154eef1ce8d4-mfwitten@gmail.com/mbox/","series":[{"id":2106,"url":"http://patchwork.ozlabs.org/api/1.2/series/2106/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=2106","date":"2017-09-08T05:05:37","name":"[1/3] net: __sock_cmsg_send(): Remove unused parameter `msg'","version":1,"mbox":"http://patchwork.ozlabs.org/series/2106/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811327/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811327/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jpOUn3fm\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpRYs1DRVz9s8J\n\tfor ;\n\tFri, 8 Sep 2017 16:02:41 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932107AbdIHGCX (ORCPT );\n\tFri, 8 Sep 2017 02:02:23 -0400","from mail-pf0-f194.google.com ([209.85.192.194]:32988 \"EHLO\n\tmail-pf0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754298AbdIHGCV (ORCPT\n\t); Fri, 8 Sep 2017 02:02:21 -0400","by mail-pf0-f194.google.com with SMTP id h4so980554pfk.0;\n\tThu, 07 Sep 2017 23:02:21 -0700 (PDT)","from gmail.com ([65.19.167.131]) by smtp.gmail.com with ESMTPSA id\n\tt27sm1877536pfi.92.2017.09.07.23.02.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 07 Sep 2017 23:02:20 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:date:from:to:cc:message-id:in-reply-to:references;\n\tbh=gDZ3PYAZ/MqILRMH+j3oBRjyWfvIu4ytjwZiWWsLP3I=;\n\tb=jpOUn3fm/Wo1JnanVEuKexsmMczpypG4dIJdq5VG9GqZ19zGGcM/4iMY/fa6BNpU5E\n\tVf+UuDXAPGaYm9juPhOW83v5YmhPELHUHrl1RDI1ZWQlaJgGinl3h6NkloQiCuB1GnzP\n\t81EbyBCzUBQpi1sS/4BHiPdJ6cX4LhmAFwxTM+rK92obOasYNziiY1TFd/9YpGc/hoed\n\tlGgGkw3FYBs2MVVjFHglDBTJkBIOMfapvT5YU4m34WKDwOUMuQTlN07NIyxedpPdVtrQ\n\tBrtNDZFT45L/F3eUrJpWvwbAcv4SoelXtorn22HDxsANT4ZprXXf5Xg9LArJ8BiqKo13\n\t00Kg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:date:from:to:cc:message-id:in-reply-to\n\t:references;\n\tbh=gDZ3PYAZ/MqILRMH+j3oBRjyWfvIu4ytjwZiWWsLP3I=;\n\tb=lsCEck67M+myWFPLpIeVGwQgT8xky6FpATPgBLYkeCAiuVYH2gEsR/2RIPLreyx2tN\n\t71k8d56BbL75h/YF2WtU6EEiHfq5/hdL02BNzaZvdXp3mdOVo/8Wtle6IpMDuyVjyENK\n\tTnTE65GISzaZYvSI8YWwynCnUlqoxy2PcayYDaFYmxYGs0cdTiuhSvHRdYJYyPNx8o9w\n\tGQaJKp1M6RMi8vDlKUn8j/o2xLUivDhNqeoGGB/0NXbspKRiD+ahMgSKvnxg8Zg4pOji\n\tpY0r7wwls8NJfeOYSwx220iKnX5tn6dqu5B/j/2mjfuD+h8mE3oweOuiFeLuRfwHWDDA\n\t+DpQ==","X-Gm-Message-State":"AHPjjUhSknyhNahf5PAyDDoEUy77svmR20msksERVF9Dc++RGp15xAQ3\n\tUDLqtybQP6v7dw==","X-Google-Smtp-Source":"ADKCNb7RA5r/GBgRz7bZbGnR2bHuHPdpg9ddc0O0fuv3FOjLreVpQE9mguGMA6pVLgsYdHTwYN+iLw==","X-Received":"by 10.99.96.10 with SMTP id u10mr1940905pgb.370.1504850541046;\n\tThu, 07 Sep 2017 23:02:21 -0700 (PDT)","Subject":"[PATCH 2/3] net: inet_recvmsg(): Remove unnecessary bitwise\n\toperation","Date":"Fri, 08 Sep 2017 05:06:26 -0000","From":"Michael Witten ","To":"\"David S. Miller\" ,\n\tAlexey Kuznetsov ,\n\tHideaki YOSHIFUJI ","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org","Message-ID":"","In-Reply-To":"<45aab5effc0c424a992646a97cf2ec14-mfwitten@gmail.com>","References":"<45aab5effc0c424a992646a97cf2ec14-mfwitten@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Date: Fri, 8 Sep 2017 00:47:49 +0000\nThe flag `MSG_DONTWAIT' is handled by passing an argument through\nthe dedicated parameter `nonblock' of the function `tcp_recvmsg()'.\n\nPresumably because `MSG_DONTWAIT' is handled so explicitly, it is\nunset in the collection of flags that are passed to `tcp_recvmsg()';\nyet, this unsetting appears to be unnecessary, and so this commit\nremoves the bitwise operation that performs the unsetting.\n\nSigned-off-by: Michael Witten \n---\n net/ipv4/af_inet.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c\nindex e31108e5ef79..2dbed042a412 100644\n--- a/net/ipv4/af_inet.c\n+++ b/net/ipv4/af_inet.c\n@@ -791,7 +791,7 @@ int inet_recvmsg(struct socket *sock, struct msghdr *msg, size_t size,\n \tsock_rps_record_flow(sk);\n \n \terr = sk->sk_prot->recvmsg(sk, msg, size, flags & MSG_DONTWAIT,\n-\t\t\t\t flags & ~MSG_DONTWAIT, &addr_len);\n+\t\t\t\t flags, &addr_len);\n \tif (err >= 0)\n \t\tmsg->msg_namelen = addr_len;\n \treturn err;\n","prefixes":["2/3"]}