{"id":811299,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811299/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504836324-4871-15-git-send-email-jasowang@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504836324-4871-15-git-send-email-jasowang@redhat.com>","list_archive_url":null,"date":"2017-09-08T02:05:20","name":"[PULL,14/18] net/colo-compare.c: Adjust net queue pop order for performance","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"47d3db2b0a8f000fb0e8fed4cf25317cae4682b7","submitter":{"id":5225,"url":"http://patchwork.ozlabs.org/api/1.2/people/5225/?format=json","name":"Jason Wang","email":"jasowang@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504836324-4871-15-git-send-email-jasowang@redhat.com/mbox/","series":[{"id":2087,"url":"http://patchwork.ozlabs.org/api/1.2/series/2087/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2087","date":"2017-09-08T02:05:06","name":"[PULL,01/18] net/filter-rewriter.c: Fix rewirter checksum bug when use virtio-net","version":1,"mbox":"http://patchwork.ozlabs.org/series/2087/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811299/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811299/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jasowang@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpLYG4NDZz9sPk\n\tfor ;\n\tFri, 8 Sep 2017 12:16:50 +1000 (AEST)","from localhost ([::1]:42990 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dq8qe-0004De-74\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 22:16:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:32895)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dq8gn-0003hM-6J\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 22:06:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dq8gi-0002aF-7g\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 22:06:37 -0400","from mx1.redhat.com ([209.132.183.28]:37028)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dq8gi-0002Z9-1V\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 22:06:32 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 14B8EC0587DF;\n\tFri, 8 Sep 2017 02:06:31 +0000 (UTC)","from jason-ThinkPad-T450s.redhat.com (ovpn-12-98.pek2.redhat.com\n\t[10.72.12.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id AD038600C2;\n\tFri, 8 Sep 2017 02:06:28 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 14B8EC0587DF","From":"Jason Wang ","To":"peter.maydell@linaro.org,\n\tqemu-devel@nongnu.org","Date":"Fri, 8 Sep 2017 10:05:20 +0800","Message-Id":"<1504836324-4871-15-git-send-email-jasowang@redhat.com>","In-Reply-To":"<1504836324-4871-1-git-send-email-jasowang@redhat.com>","References":"<1504836324-4871-1-git-send-email-jasowang@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tFri, 08 Sep 2017 02:06:31 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 14/18] net/colo-compare.c: Adjust net queue pop\n\torder for performance","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Jason Wang ,\n\tZhang Chen ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Zhang Chen \n\nThe packet_enqueue() use g_queue_push_tail() to\nenqueue net packet, so it is more efficent way use\ng_queue_pop_head() to get packet for compare.\nThat will improve the success rate of comparison.\nIn my test the performance of ftp put 1000M file\nwill increase 10%\n\nSigned-off-by: Zhang Chen \nSigned-off-by: Jason Wang \n---\n net/colo-compare.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/net/colo-compare.c b/net/colo-compare.c\nindex 612fbac..f480315 100644\n--- a/net/colo-compare.c\n+++ b/net/colo-compare.c\n@@ -484,7 +484,7 @@ static void colo_compare_connection(void *opaque, void *user_data)\n \n while (!g_queue_is_empty(&conn->primary_list) &&\n !g_queue_is_empty(&conn->secondary_list)) {\n- pkt = g_queue_pop_tail(&conn->primary_list);\n+ pkt = g_queue_pop_head(&conn->primary_list);\n switch (conn->ip_proto) {\n case IPPROTO_TCP:\n result = g_queue_find_custom(&conn->secondary_list,\n@@ -522,7 +522,7 @@ static void colo_compare_connection(void *opaque, void *user_data)\n * until next comparison.\n */\n trace_colo_compare_main(\"packet different\");\n- g_queue_push_tail(&conn->primary_list, pkt);\n+ g_queue_push_head(&conn->primary_list, pkt);\n /* TODO: colo_notify_checkpoint();*/\n break;\n }\n","prefixes":["PULL","14/18"]}