{"id":811289,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811289/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504836324-4871-4-git-send-email-jasowang@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504836324-4871-4-git-send-email-jasowang@redhat.com>","list_archive_url":null,"date":"2017-09-08T02:05:09","name":"[PULL,03/18] net/rocker: Plug memory leak in pci_rocker_init()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5ad0056058400527b5c72bef0c114b43ceb4ed3c","submitter":{"id":5225,"url":"http://patchwork.ozlabs.org/api/1.2/people/5225/?format=json","name":"Jason Wang","email":"jasowang@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504836324-4871-4-git-send-email-jasowang@redhat.com/mbox/","series":[{"id":2087,"url":"http://patchwork.ozlabs.org/api/1.2/series/2087/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2087","date":"2017-09-08T02:05:06","name":"[PULL,01/18] net/filter-rewriter.c: Fix rewirter checksum bug when use virtio-net","version":1,"mbox":"http://patchwork.ozlabs.org/series/2087/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811289/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811289/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jasowang@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpLPZ3gGSz9ryT\n\tfor ;\n\tFri, 8 Sep 2017 12:10:10 +1000 (AEST)","from localhost ([::1]:42957 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dq8kB-0006GE-Gs\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 22:10:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60755)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dq8g0-000322-6G\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 22:05:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dq8fv-000228-IR\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 22:05:48 -0400","from mx1.redhat.com ([209.132.183.28]:50628)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dq8fv-00021Z-6L\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 22:05:43 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 231655D697;\n\tFri, 8 Sep 2017 02:05:42 +0000 (UTC)","from jason-ThinkPad-T450s.redhat.com (ovpn-12-98.pek2.redhat.com\n\t[10.72.12.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 787FF600C2;\n\tFri, 8 Sep 2017 02:05:37 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 231655D697","From":"Jason Wang ","To":"peter.maydell@linaro.org,\n\tqemu-devel@nongnu.org","Date":"Fri, 8 Sep 2017 10:05:09 +0800","Message-Id":"<1504836324-4871-4-git-send-email-jasowang@redhat.com>","In-Reply-To":"<1504836324-4871-1-git-send-email-jasowang@redhat.com>","References":"<1504836324-4871-1-git-send-email-jasowang@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tFri, 08 Sep 2017 02:05:42 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 03/18] net/rocker: Plug memory leak in\n\tpci_rocker_init()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mao Zhongyi , f4bug@amsat.org,\n\tjiri@resnulli.us, jasowang@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Mao Zhongyi \n\npci_rocker_init() leaks a World when the name more than 9 chars,\nthen return a negative value directly, doesn't make a correct\ncleanup. So add a new goto label to fix it.\n\nCc: jasowang@redhat.com\nCc: jiri@resnulli.us\nCc: armbru@redhat.com\nCc: f4bug@amsat.org\nSigned-off-by: Mao Zhongyi \nReviewed-by: Markus Armbruster \nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Jason Wang \n---\n hw/net/rocker/rocker.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c\nindex 7496752..9a538a9 100644\n--- a/hw/net/rocker/rocker.c\n+++ b/hw/net/rocker/rocker.c\n@@ -1355,7 +1355,8 @@ static int pci_rocker_init(PCIDevice *dev)\n fprintf(stderr,\n \"rocker: name too long; please shorten to at most %d chars\\n\",\n MAX_ROCKER_NAME_LEN);\n- return -EINVAL;\n+ err = -EINVAL;\n+ goto err_name_too_long;\n }\n \n if (memcmp(&r->fp_start_macaddr, &zero, sizeof(zero)) == 0) {\n@@ -1414,6 +1415,7 @@ static int pci_rocker_init(PCIDevice *dev)\n \n return 0;\n \n+err_name_too_long:\n err_duplicate:\n rocker_msix_uninit(r);\n err_msix_init:\n","prefixes":["PULL","03/18"]}