{"id":811286,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811286/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504836324-4871-6-git-send-email-jasowang@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504836324-4871-6-git-send-email-jasowang@redhat.com>","list_archive_url":null,"date":"2017-09-08T02:05:11","name":"[PULL,05/18] net/rocker: Fix the unusual macro name","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"94b0331f21300a57824abbb14dd28a392a32b438","submitter":{"id":5225,"url":"http://patchwork.ozlabs.org/api/1.2/people/5225/?format=json","name":"Jason Wang","email":"jasowang@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504836324-4871-6-git-send-email-jasowang@redhat.com/mbox/","series":[{"id":2087,"url":"http://patchwork.ozlabs.org/api/1.2/series/2087/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2087","date":"2017-09-08T02:05:06","name":"[PULL,01/18] net/filter-rewriter.c: Fix rewirter checksum bug when use virtio-net","version":1,"mbox":"http://patchwork.ozlabs.org/series/2087/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811286/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811286/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jasowang@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpLNT3PTWz9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 12:09:13 +1000 (AEST)","from localhost ([::1]:42952 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dq8jH-0005Nl-F2\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 22:09:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60794)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <jasowang@redhat.com>) id 1dq8g9-00039R-Ut\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 22:06:05 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <jasowang@redhat.com>) id 1dq8g5-00026X-3h\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 22:05:57 -0400","from mx1.redhat.com ([209.132.183.28]:50354)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <jasowang@redhat.com>) id 1dq8g4-00026A-RP\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 22:05:53 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DA66E8046E;\n\tFri,  8 Sep 2017 02:05:51 +0000 (UTC)","from jason-ThinkPad-T450s.redhat.com (ovpn-12-98.pek2.redhat.com\n\t[10.72.12.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A9037600C2;\n\tFri,  8 Sep 2017 02:05:47 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DA66E8046E","From":"Jason Wang <jasowang@redhat.com>","To":"peter.maydell@linaro.org,\n\tqemu-devel@nongnu.org","Date":"Fri,  8 Sep 2017 10:05:11 +0800","Message-Id":"<1504836324-4871-6-git-send-email-jasowang@redhat.com>","In-Reply-To":"<1504836324-4871-1-git-send-email-jasowang@redhat.com>","References":"<1504836324-4871-1-git-send-email-jasowang@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tFri, 08 Sep 2017 02:05:52 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 05/18] net/rocker: Fix the unusual macro name","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Mao Zhongyi <maozy.fnst@cn.fujitsu.com>, f4bug@amsat.org,\n\tjiri@resnulli.us, jasowang@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"From: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>\n\nCc: jasowang@redhat.com\nCc: jiri@resnulli.us\nCc: armbru@redhat.com\nCc: f4bug@amsat.org\nSuggested-by: Markus Armbruster <armbru@redhat.com>\nSigned-off-by: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>\nReviewed-by: Markus Armbruster <armbru@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\nSigned-off-by: Jason Wang <jasowang@redhat.com>\n---\n hw/net/rocker/rocker.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)","diff":"diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c\nindex bb38cba..9273473 100644\n--- a/hw/net/rocker/rocker.c\n+++ b/hw/net/rocker/rocker.c\n@@ -69,10 +69,10 @@ struct rocker {\n     QLIST_ENTRY(rocker) next;\n };\n \n-#define ROCKER \"rocker\"\n+#define TYPE_ROCKER \"rocker\"\n \n-#define to_rocker(obj) \\\n-    OBJECT_CHECK(Rocker, (obj), ROCKER)\n+#define ROCKER(obj) \\\n+    OBJECT_CHECK(Rocker, (obj), TYPE_ROCKER)\n \n static QLIST_HEAD(, rocker) rockers;\n \n@@ -1285,7 +1285,7 @@ static World *rocker_world_type_by_name(Rocker *r, const char *name)\n \n static void pci_rocker_realize(PCIDevice *dev, Error **errp)\n {\n-    Rocker *r = to_rocker(dev);\n+    Rocker *r = ROCKER(dev);\n     const MACAddr zero = { .a = { 0, 0, 0, 0, 0, 0 } };\n     const MACAddr dflt = { .a = { 0x52, 0x54, 0x00, 0x12, 0x35, 0x01 } };\n     static int sw_index;\n@@ -1331,7 +1331,7 @@ static void pci_rocker_realize(PCIDevice *dev, Error **errp)\n     /* validate switch properties */\n \n     if (!r->name) {\n-        r->name = g_strdup(ROCKER);\n+        r->name = g_strdup(TYPE_ROCKER);\n     }\n \n     if (rocker_find(r->name)) {\n@@ -1427,7 +1427,7 @@ err_world_type_by_name:\n \n static void pci_rocker_uninit(PCIDevice *dev)\n {\n-    Rocker *r = to_rocker(dev);\n+    Rocker *r = ROCKER(dev);\n     int i;\n \n     QLIST_REMOVE(r, next);\n@@ -1460,7 +1460,7 @@ static void pci_rocker_uninit(PCIDevice *dev)\n \n static void rocker_reset(DeviceState *dev)\n {\n-    Rocker *r = to_rocker(dev);\n+    Rocker *r = ROCKER(dev);\n     int i;\n \n     for (i = 0; i < ROCKER_WORLD_TYPE_MAX; i++) {\n@@ -1498,7 +1498,7 @@ static Property rocker_properties[] = {\n };\n \n static const VMStateDescription rocker_vmsd = {\n-    .name = ROCKER,\n+    .name = TYPE_ROCKER,\n     .unmigratable = 1,\n };\n \n@@ -1521,7 +1521,7 @@ static void rocker_class_init(ObjectClass *klass, void *data)\n }\n \n static const TypeInfo rocker_info = {\n-    .name          = ROCKER,\n+    .name          = TYPE_ROCKER,\n     .parent        = TYPE_PCI_DEVICE,\n     .instance_size = sizeof(Rocker),\n     .class_init    = rocker_class_init,\n","prefixes":["PULL","05/18"]}