{"id":811273,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811273/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170908001204.18174-4-mhalcrow@google.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/1.2/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170908001204.18174-4-mhalcrow@google.com>","list_archive_url":null,"date":"2017-09-08T00:12:04","name":"[3/3] UBIFS crypto: Return -EXDEV for link, rename, and cross-rename between incompat contexts","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"3f46d9b938ff70bf1ac35d49a05dbd4dbbfb6f37","submitter":{"id":64496,"url":"http://patchwork.ozlabs.org/api/1.2/people/64496/?format=json","name":"Michael Halcrow","email":"mhalcrow@google.com"},"delegate":{"id":54851,"url":"http://patchwork.ozlabs.org/api/1.2/users/54851/?format=json","username":"rw","first_name":"Richard","last_name":"Weinberger","email":"richard@nod.at"},"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170908001204.18174-4-mhalcrow@google.com/mbox/","series":[{"id":2078,"url":"http://patchwork.ozlabs.org/api/1.2/series/2078/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=2078","date":"2017-09-08T00:12:01","name":"fscrypto: Return -EXDEV for link, rename, and cross-rename between incompat contexts","version":1,"mbox":"http://patchwork.ozlabs.org/series/2078/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811273/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811273/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"E8J8RwCX\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"QZ5fy9eq\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpHsT2yT0z9s81\n\tfor ;\n\tFri, 8 Sep 2017 10:15:41 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dq6xI-0000rD-9x; Fri, 08 Sep 2017 00:15:32 +0000","from mail-pg0-x234.google.com ([2607:f8b0:400e:c05::234])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dq6un-0006qy-DU\n\tfor linux-mtd@lists.infradead.org; Fri, 08 Sep 2017 00:13:00 +0000","by mail-pg0-x234.google.com with SMTP id m9so2117094pgd.3\n\tfor ;\n\tThu, 07 Sep 2017 17:12:37 -0700 (PDT)","from mhalcrow-linux.kir.corp.google.com ([100.66.175.61])\n\tby smtp.gmail.com with ESMTPSA id\n\td25sm1007805pfb.1.2017.09.07.17.12.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 07 Sep 2017 17:12:36 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=VVTfGinn/QGREayhe09DiSp3TVCvI6xwhQcvm+YIcNA=;\n\tb=E8J8RwCXsI/O3780uMuU0+v5Qk\n\t5yhuKMKwZ12oCq+GhsIz9qngjrx2hrFef+n/LGC+tjCamuIllCkeO5aoc9zQc7ouuhxY+6/zZRDeI\n\tA7Uyxglzru4Mhwyr8HTkjgJPHzhSuM8xMWiI2W1nPeR4Sp1z0l1B7oU9NMEgPMXFipna3ToIlUgkO\n\tECxsj4ZXRLg+fdEoVUDZsHDAnOLYvv8Urs0JRS9if+nXDyohCEVlWf78lRxWhiErU+D0Ai68RqcKK\n\tf2UGMlwdRqI57csPoMTAQ3u+vWdhfWhl8HBCeTpP+eeIGfUVmV6LCUVWam8Qfnu4BmNzxB35iqkJK\n\tqLcbN4tA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=qDjywoq7Vkn7rFJB7qZ7l3QEG4VNF8mMs4cBtXwCfq0=;\n\tb=QZ5fy9eq6+/nFtZjgrqpDue+frA+q8wasI1uuQtSVhKDkm3q+h7Se8c/L+IVVAfvQl\n\tJZWUEmeCL+VR8QvOx35cYG1cyhB1ZEs80FSrgi7hkcvf/vgmMQUb4bxTkeUJ9Tsyqe7E\n\tLJhyTGujzQ7KWNar5SNKdXU2qmTwNbtNmeTkj+Mk3S4Gks5SOOnvafxpLVXJoRUH+FyS\n\tBs1ZFhq9WHgbD+rpFUZXgoggg+hsnbza5j/BQ2wo5Y3lIrcNsntkuSkQiwUr4l7BxM/D\n\t3JpV3CVMfGloOGxTrSf5WAOn5xWTVDQ0L53PRx7WwBFre8cnPFyLoh+56kSt9lw7swUJ\n\tFnlQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=qDjywoq7Vkn7rFJB7qZ7l3QEG4VNF8mMs4cBtXwCfq0=;\n\tb=jgiyA9DDxuyH7XiNjHah/b8/esVBYf7f+/KahbKyF44GfEjadtKU2vmY8eA4J2gqkV\n\tG2q5uyqEXoFPC4LalKz5v2VkzSSSBXHEPqxGuGAeGvQecf8Nt+UiqLy6T04B4YLvF1Vt\n\tHv2qjBSzVaB3cTuWjf/OwBM/9TRo8x/3amyteylEx4mlpyM7FvRmRpr3Xe4mRpISTh/1\n\tcTbTXsVf5H06yH8CGpPgPEFBp6QbpijlcNgUVRNfaAx+gWDcsjZLCibtcyufUWEHsmja\n\toBmBvPXuWLQ8V65n5XokMgVsKLUkOQR2LxxCT4Atb+M+y/EAiISoq7t7f7OVfNzttoR3\n\txIWw==","X-Gm-Message-State":"AHPjjUhjiG3ndTacbak1qHvTGqFGoI5PpCH8EYnWjRxMQFGMOBsckB2Z\n\tH/jII+OJm9xM+ARm","X-Google-Smtp-Source":"ADKCNb4QfNMNxfw8TbCVeDqp1WNCcaEoHB4z7idGyPhInLTE1pHpNfqRl1X7WnoHEnb506ZiXvxB/A==","X-Received":"by 10.98.248.71 with SMTP id c7mr1158757pfm.129.1504829557244;\n\tThu, 07 Sep 2017 17:12:37 -0700 (PDT)","From":"Michael Halcrow ","To":"linux-fscrypt@vger.kernel.org","Subject":"[PATCH 3/3] UBIFS crypto: Return -EXDEV for link, rename,\n\tand cross-rename between incompat contexts","Date":"Thu, 7 Sep 2017 17:12:04 -0700","Message-Id":"<20170908001204.18174-4-mhalcrow@google.com>","X-Mailer":"git-send-email 2.14.1.581.gf28d330327-goog","In-Reply-To":"<20170908001204.18174-1-mhalcrow@google.com>","References":"<20170908001204.18174-1-mhalcrow@google.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170907_171257_702111_B14FC7EE ","X-CRM114-Status":"UNSURE ( 8.56 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"0.5 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (0.5 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c05:0:0:0:234 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t2.5 SUSPICIOUS_RECIPS Similar addresses in recipient list\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tlinux-ext4@vger.kernel.org, tytso@mit.edu,\n\tlinux-f2fs-devel@lists.sourceforge.net","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"Gives user space the opportunity to fall back to copy-and-delete.\n\nSigned-off-by: Michael Halcrow \n---\n fs/ubifs/dir.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c\nindex 417fe0b29f23..6c5753a2f79f 100644\n--- a/fs/ubifs/dir.c\n+++ b/fs/ubifs/dir.c\n@@ -745,7 +745,7 @@ static int ubifs_link(struct dentry *old_dentry, struct inode *dir,\n \n \tif (ubifs_crypt_is_encrypted(dir) &&\n \t !fscrypt_has_permitted_context(dir, inode))\n-\t\treturn -EPERM;\n+\t\treturn -EXDEV;\n \n \terr = fscrypt_setup_filename(dir, &dentry->d_name, 0, &nm);\n \tif (err)\n@@ -1356,7 +1356,7 @@ static int do_rename(struct inode *old_dir, struct dentry *old_dentry,\n \tif (old_dir != new_dir) {\n \t\tif (ubifs_crypt_is_encrypted(new_dir) &&\n \t\t !fscrypt_has_permitted_context(new_dir, old_inode))\n-\t\t\treturn -EPERM;\n+\t\t\treturn -EXDEV;\n \t}\n \n \tif (unlink && is_dir) {\n@@ -1578,7 +1578,7 @@ static int ubifs_xrename(struct inode *old_dir, struct dentry *old_dentry,\n \t (old_dir != new_dir) &&\n \t (!fscrypt_has_permitted_context(new_dir, fst_inode) ||\n \t !fscrypt_has_permitted_context(old_dir, snd_inode)))\n-\t\treturn -EPERM;\n+\t\treturn -EXDEV;\n \n \terr = fscrypt_setup_filename(old_dir, &old_dentry->d_name, 0, &fst_nm);\n \tif (err)\n","prefixes":["3/3"]}