{"id":811271,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811271/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170908001204.18174-2-mhalcrow@google.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/1.2/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170908001204.18174-2-mhalcrow@google.com>","list_archive_url":null,"date":"2017-09-08T00:12:02","name":"[1/3] ext4 crypto: Return -EXDEV for link, rename, and cross-rename between incompat contexts","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"6723976b65c17ed71027c203b49e30f16947fcef","submitter":{"id":64496,"url":"http://patchwork.ozlabs.org/api/1.2/people/64496/?format=json","name":"Michael Halcrow","email":"mhalcrow@google.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/20170908001204.18174-2-mhalcrow@google.com/mbox/","series":[{"id":2078,"url":"http://patchwork.ozlabs.org/api/1.2/series/2078/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=2078","date":"2017-09-08T00:12:01","name":"fscrypto: Return -EXDEV for link, rename, and cross-rename between incompat contexts","version":1,"mbox":"http://patchwork.ozlabs.org/series/2078/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811271/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811271/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"lX6qMfA9\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"X+8QJKUG\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpHqb0X9fz9s81\n\tfor ;\n\tFri, 8 Sep 2017 10:14:03 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dq6vl-0007m3-Dt; Fri, 08 Sep 2017 00:13:57 +0000","from mail-pf0-x22d.google.com ([2607:f8b0:400e:c00::22d])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dq6uj-0006kS-HK\n\tfor linux-mtd@lists.infradead.org; Fri, 08 Sep 2017 00:12:55 +0000","by mail-pf0-x22d.google.com with SMTP id g13so1916215pfm.2\n\tfor ;\n\tThu, 07 Sep 2017 17:12:32 -0700 (PDT)","from mhalcrow-linux.kir.corp.google.com ([100.66.175.61])\n\tby smtp.gmail.com with ESMTPSA id\n\td25sm1007805pfb.1.2017.09.07.17.12.31\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 07 Sep 2017 17:12:31 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=SUzm24q/Mb01iTTmHl1xGTWc3tSGhUY7Snx3QrevtCg=;\n\tb=lX6qMfA9lfbhYSRs5swgUoSNkM\n\tmxrHvJmT3pK7a1cx/eEaqkktbctzpPlRF2CerBP15guV6LtRGVISGKlUG3KOHRM/iFOsbToy9Z3xC\n\tPOc+QgtM2m06RtyDx2uxade0tGucL6BJ6C7kOKUkkV1ePCysjbIsF+puvfXUxdEJfmc8NWaSr+C+Z\n\tQacx21AoDF3KZN89tIv60ktfF7iqvwKYOGrNx+3jkSXjR5EPALvIZ9FVHe0FoZCtJnJ0j+JtgehMz\n\tFzraF8HrqYxGNslX43xlNetrQypQEEdWAvGJulwgOC4fA6dGglv71B/UrSGwpdJqmC/Y31xOLo79N\n\t3vHPvbsA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=p/JV/GCGMlQrRMcB4xRDJuCDYFD95LtSDYEi9esBWvE=;\n\tb=X+8QJKUGY7vzJmz1iJqV7GgxdVNqS9/WTdbYgoM0ccLCQ8WCb22kSXO2NIEoqeWp1V\n\tbiRx0eMrH2fcv59BcrJEBptKQ6VuNa1ffqzmdbHdoRNgvcU3FP8GHtAz/tU3JSuH4bog\n\ty5G6a9uEpSaija1ypRMP1gFX0B/K7uUX8FRAGpAZemGkFBMIRh2Hhl9/oBSxRCvtNZB0\n\tAYlk0WsvRwkH2QKr57dF34YQkFjrkhSMD2gD+DzdE+Tlmwong3syLfRatU5W5LNELlLz\n\t7Mrk3Z01AXfJvr7TZrF9F2QvwAIYykMHw/bY7r2yoO0faf5hu5BT/dEaIp4EJzMzqEKF\n\tDBNg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=p/JV/GCGMlQrRMcB4xRDJuCDYFD95LtSDYEi9esBWvE=;\n\tb=JHMvrHy0wSAbYUewerKaiB+jazjvRtadfkmhPisMXkCHZYfWIZtuxqgAYD2jFq+qRc\n\tvQjG6JUI8eMCteV5QPtlBV3JNBIgqULngzaFBgCH11hClkpVFNgkcROtFbyeCqvYq3Qc\n\t9VYHS5Nt8QtDrheKrjSvCVeGwniAoTfg6qSLtEC3uo1BGe38QNGBr1PYe8GMC+GhMPBb\n\ttl+KFXuyPRxq5e5l71NwVe3+cyJMzDFpdnJFJnh7jlxkOcYVquSTTvjvwVCPRxboKhBq\n\tjqKpir0HUlNloGZC7RWvkCZCEvhtuibBj878ge6+6nkAOtIC08AqeMpZaqyEPH1bUy3v\n\t86AQ==","X-Gm-Message-State":"AHPjjUgZfiREi0cPTpxd1HWDgaLpqM9Ab7tBOmKw3AMvxiv/OjztgyON\n\tT3tFy/VwaH1MrKC3","X-Google-Smtp-Source":"ADKCNb7gVRvszoGixNODZzDTX4Rg+1Ssu6aS33fYta90PO6l576fJYafIE3T8CDNkWqEoCl4XzYMoA==","X-Received":"by 10.98.236.81 with SMTP id k78mr1227570pfh.336.1504829551886; \n\tThu, 07 Sep 2017 17:12:31 -0700 (PDT)","From":"Michael Halcrow ","To":"linux-fscrypt@vger.kernel.org","Subject":"[PATCH 1/3] ext4 crypto: Return -EXDEV for link, rename,\n\tand cross-rename between incompat contexts","Date":"Thu, 7 Sep 2017 17:12:02 -0700","Message-Id":"<20170908001204.18174-2-mhalcrow@google.com>","X-Mailer":"git-send-email 2.14.1.581.gf28d330327-goog","In-Reply-To":"<20170908001204.18174-1-mhalcrow@google.com>","References":"<20170908001204.18174-1-mhalcrow@google.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170907_171253_774131_B0159A04 ","X-CRM114-Status":"UNSURE ( 8.54 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"0.5 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (0.5 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c00:0:0:0:22d listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t2.5 SUSPICIOUS_RECIPS Similar addresses in recipient list\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tlinux-ext4@vger.kernel.org, tytso@mit.edu,\n\tlinux-f2fs-devel@lists.sourceforge.net","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"Gives user space the opportunity to fall back to copy-and-delete.\n\nSigned-off-by: Michael Halcrow \n---\n fs/ext4/namei.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c\nindex c1cf020d1889..3c493bc4273d 100644\n--- a/fs/ext4/namei.c\n+++ b/fs/ext4/namei.c\n@@ -3223,7 +3223,7 @@ static int ext4_link(struct dentry *old_dentry,\n \t\treturn -EMLINK;\n \tif (ext4_encrypted_inode(dir) &&\n \t\t\t!fscrypt_has_permitted_context(dir, inode))\n-\t\treturn -EPERM;\n+\t\treturn -EXDEV;\n \n if ((ext4_test_inode_flag(dir, EXT4_INODE_PROJINHERIT)) &&\n \t (!projid_eq(EXT4_I(dir)->i_projid,\n@@ -3552,7 +3552,7 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry,\n \tif ((old.dir != new.dir) &&\n \t ext4_encrypted_inode(new.dir) &&\n \t !fscrypt_has_permitted_context(new.dir, old.inode)) {\n-\t\tretval = -EPERM;\n+\t\tretval = -EXDEV;\n \t\tgoto end_rename;\n \t}\n \n@@ -3732,7 +3732,7 @@ static int ext4_cross_rename(struct inode *old_dir, struct dentry *old_dentry,\n \t (old_dir != new_dir) &&\n \t (!fscrypt_has_permitted_context(new_dir, old.inode) ||\n \t !fscrypt_has_permitted_context(old_dir, new.inode)))\n-\t\treturn -EPERM;\n+\t\treturn -EXDEV;\n \n \tif ((ext4_test_inode_flag(new_dir, EXT4_INODE_PROJINHERIT) &&\n \t !projid_eq(EXT4_I(new_dir)->i_projid,\n","prefixes":["1/3"]}