{"id":811263,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811263/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170907224051.21518-21-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170907224051.21518-21-richard.henderson@linaro.org>","list_archive_url":null,"date":"2017-09-07T22:40:48","name":"[PULL,20/23] tcg/arm: Use constant pool for call","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d41b43a3c1f1bed136937ce5feafdec1ff3284bd","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.2/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170907224051.21518-21-richard.henderson@linaro.org/mbox/","series":[{"id":2073,"url":"http://patchwork.ozlabs.org/api/1.2/series/2073/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2073","date":"2017-09-07T22:40:28","name":"[PULL,01/23] tcg: Move USE_DIRECT_JUMP discriminator to tcg/cpu/tcg-target.h","version":1,"mbox":"http://patchwork.ozlabs.org/series/2073/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811263/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811263/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"bUH1aWUr\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpG9S52QRz9s81\n\tfor ;\n\tFri, 8 Sep 2017 08:59:24 +1000 (AEST)","from localhost ([::1]:42587 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dq5la-0001Ns-Pz\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 18:59:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52351)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dq5UG-0003Hb-Gz\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 18:41:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dq5UB-0008ON-Um\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 18:41:28 -0400","from mail-pf0-x235.google.com ([2607:f8b0:400e:c00::235]:35370)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dq5UB-0008Ng-OX\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 18:41:23 -0400","by mail-pf0-x235.google.com with SMTP id g13so1630129pfm.2\n\tfor ; Thu, 07 Sep 2017 15:41:23 -0700 (PDT)","from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net.\n\t[97.126.108.236]) by smtp.gmail.com with ESMTPSA id\n\th19sm770678pfh.142.2017.09.07.15.41.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 07 Sep 2017 15:41:21 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=/pPbNEjmX+uxRZu6MhUxcaRB0QEpWumd838yfUa4lXE=;\n\tb=bUH1aWUrjUIkCNtM4t410GExkDd+spICWAcqcZcdZAFt49/ysGYL8DA/gffyS+zNsa\n\t8P46Yb2ZaLFsu2VnuWjeBVyVzZUQWbR+MhYevBFLIkhrZp2EErudBgXeyusVu0dkLMyt\n\t6T+dqm6gL3jxHNJcxZFQTNzwXLMag/+qATGOo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=/pPbNEjmX+uxRZu6MhUxcaRB0QEpWumd838yfUa4lXE=;\n\tb=lsvdMrSIeK1mNTpdSsB/XVLoJlM5Q/52ju/bn7k4kixshDdYDv8Tsqtu8YZ3ax3rQh\n\t5CGBQwmiqw6shygUBIPVz2bQglUbacW1CdOj1sa9AWbpPw6RB40j+yaqucESrbeZ5LXu\n\t/xzAWDcQIOVwl0GFJ90emgWEJ/Y44An/8OpBn89PdNykOVzt1RhYra9BqOHtHirtkTjE\n\tCIXZnQSg71jwBevq8IdBEi1FanhXg59bkPs342SXyTW82AELMIuRg5paK7wRESQTcxi5\n\tyUq8vPz7bKKK5yKKGnsABj5yetdIZ3ma2mSKUn5zydZzoEvMLgVKz1OXCXt35qRm3EdY\n\t4rBg==","X-Gm-Message-State":"AHPjjUgfzgxHx2J58JAlygMdKPSoyZ3c80/KL5frLhLfEZ+WKJ/Kasu3\n\tzYjRJxHTh7jSnQ2TVJ7s9Q==","X-Google-Smtp-Source":"ADKCNb7znRlPwqJ553KE28/8lfxQLoMYURYl8H8w8rhcV81Ny+PKMNY8+w1FY14P+N0HCK+VU8Bv1w==","X-Received":"by 10.84.233.67 with SMTP id k3mr1008124plt.416.1504824082509;\n\tThu, 07 Sep 2017 15:41:22 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Date":"Thu, 7 Sep 2017 15:40:48 -0700","Message-Id":"<20170907224051.21518-21-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170907224051.21518-1-richard.henderson@linaro.org>","References":"<20170907224051.21518-1-richard.henderson@linaro.org>","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::235","Subject":"[Qemu-devel] [PULL 20/23] tcg/arm: Use constant pool for call","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, Richard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Richard Henderson \n\nSigned-off-by: Richard Henderson \n---\n tcg/arm/tcg-target.inc.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)","diff":"diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c\nindex 2736022d5a..db46aea38c 100644\n--- a/tcg/arm/tcg-target.inc.c\n+++ b/tcg/arm/tcg-target.inc.c\n@@ -1054,10 +1054,7 @@ static void tcg_out_goto(TCGContext *s, int cond, tcg_insn_unit *addr)\n tcg_out_b(s, cond, disp);\n return;\n }\n-\n- assert(use_armv5t_instructions || (addri & 1) == 0);\n- tcg_out_movi32(s, cond, TCG_REG_TMP, addri);\n- tcg_out_bx(s, cond, TCG_REG_TMP);\n+ tcg_out_movi_pool(s, cond, TCG_REG_PC, addri);\n }\n \n /* The call case is mostly used for helpers - so it's not unreasonable\n@@ -1081,9 +1078,9 @@ static void tcg_out_call(TCGContext *s, tcg_insn_unit *addr)\n tcg_out_movi32(s, COND_AL, TCG_REG_TMP, addri);\n tcg_out_blx(s, COND_AL, TCG_REG_TMP);\n } else {\n+ /* ??? Know that movi_pool emits exactly 2 insns. */\n tcg_out_dat_imm(s, COND_AL, ARITH_ADD, TCG_REG_R14, TCG_REG_PC, 4);\n- tcg_out_ld32_12(s, COND_AL, TCG_REG_PC, TCG_REG_PC, -4);\n- tcg_out32(s, addri);\n+ tcg_out_movi_pool(s, COND_AL, TCG_REG_PC, addri);\n }\n }\n \n","prefixes":["PULL","20/23"]}