{"id":811259,"url":"http://patchwork.ozlabs.org/api/1.2/patches/811259/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170907224051.21518-17-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170907224051.21518-17-richard.henderson@linaro.org>","list_archive_url":null,"date":"2017-09-07T22:40:44","name":"[PULL,16/23] tcg/arm: Tighten tlb indexing offset test","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8c0e1bf0ce632c9c0287af74bf538e613a716a2a","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.2/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170907224051.21518-17-richard.henderson@linaro.org/mbox/","series":[{"id":2073,"url":"http://patchwork.ozlabs.org/api/1.2/series/2073/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2073","date":"2017-09-07T22:40:28","name":"[PULL,01/23] tcg: Move USE_DIRECT_JUMP discriminator to tcg/cpu/tcg-target.h","version":1,"mbox":"http://patchwork.ozlabs.org/series/2073/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811259/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811259/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ic7ZBugQ\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpG4d3mNmz9rxl\n\tfor ;\n\tFri, 8 Sep 2017 08:55:13 +1000 (AEST)","from localhost ([::1]:42569 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dq5hX-00066T-JF\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 18:55:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52272)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dq5UB-0003CD-KM\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 18:41:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dq5U7-0008KH-07\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 18:41:23 -0400","from mail-pf0-x230.google.com ([2607:f8b0:400e:c00::230]:35370)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dq5U6-0008JY-R5\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 18:41:18 -0400","by mail-pf0-x230.google.com with SMTP id g13so1629864pfm.2\n\tfor ; Thu, 07 Sep 2017 15:41:18 -0700 (PDT)","from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net.\n\t[97.126.108.236]) by smtp.gmail.com with ESMTPSA id\n\th19sm770678pfh.142.2017.09.07.15.41.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 07 Sep 2017 15:41:16 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=2N1o0vUjnZz5BCK8ZK7VFGbHwO2asiO5JbqCJsu9o+Y=;\n\tb=ic7ZBugQCPbzUP5aStxddpM+ys7WR/lxY0abfdStBcRYMnsSNXKJT5Jrpv79G1WJPe\n\tELlS8ZRCfoanSXMJGjh+s9yLCy5mYPoXCKvdcyU3DE+wxo8Qr9hxCFWe07Uk/8gyVaeH\n\t7Se/wQQlOz9jqXSY148eQMQzbT5g4xfQPAxaQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=2N1o0vUjnZz5BCK8ZK7VFGbHwO2asiO5JbqCJsu9o+Y=;\n\tb=Bk78j1nctPxBEsv2JtI513K4L/zaZ9NmJb7w6hKaCS3YyVxwpXIXIC7v+GFNIGALlH\n\ty7FfhjLgB+7WrhC7GWGHLjXNjPPasykojwJWBUtr9zIUpqkhCZBVGC9Rb9iX8teWdRSQ\n\teEF2OSwG1tDPpMyItEhiP3FRnZILWLg5mwvZdOxGUcgiJRYgqKOlR9UVN2mMpgdLegmc\n\tH30S/20gSZQ60jiSL+7MVBpZCmy7gdhqsN92gkUhW/ztbivIUT+XtjA8FG7lBVTTSxlB\n\to+adp0uU8w/nrFpSohUJHaDucx9ZJHN+I1iERnXZwGNdkmh5A+11NsmzIGe34ThGeZZP\n\t4JPw==","X-Gm-Message-State":"AHPjjUhEvwjJvOHSpn1FaGGS5gPAA2lep3SP5MS8PfTBlh+ThIX5wAbq\n\tUW/l4LEL99HQHygbooLXdQ==","X-Google-Smtp-Source":"ADKCNb4LqiJVX+xYU9Adv2kxiCFAuWu2qk4MFd6rriOIgZ5961o1yziJdSVJ5zOrbzex9XAgol+b9Q==","X-Received":"by 10.99.54.7 with SMTP id d7mr956281pga.115.1504824077525;\n\tThu, 07 Sep 2017 15:41:17 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Date":"Thu, 7 Sep 2017 15:40:44 -0700","Message-Id":"<20170907224051.21518-17-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170907224051.21518-1-richard.henderson@linaro.org>","References":"<20170907224051.21518-1-richard.henderson@linaro.org>","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::230","Subject":"[Qemu-devel] [PULL 16/23] tcg/arm: Tighten tlb indexing offset test","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, Richard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Richard Henderson \n\nWe are not going to use ldrd for loading the comparator\nfor 32-bit guests, so don't limit cmp_off to 8 bits then.\nThis eliminates one insn in the tlb load for some guests.\n\nSigned-off-by: Richard Henderson \n---\n tcg/arm/tcg-target.inc.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c\nindex 66c369c239..6c12b169ce 100644\n--- a/tcg/arm/tcg-target.inc.c\n+++ b/tcg/arm/tcg-target.inc.c\n@@ -1202,7 +1202,9 @@ static TCGReg tcg_out_tlb_read(TCGContext *s, TCGReg addrlo, TCGReg addrhi,\n }\n \n /* We checked that the offset is contained within 16 bits above. */\n- if (add_off > 0xfff || (use_armv6_instructions && cmp_off > 0xff)) {\n+ if (add_off > 0xfff\n+ || (use_armv6_instructions && TARGET_LONG_BITS == 64\n+ && cmp_off > 0xff)) {\n tcg_out_dat_imm(s, COND_AL, ARITH_ADD, TCG_REG_R2, base,\n (24 << 7) | (cmp_off >> 8));\n base = TCG_REG_R2;\n","prefixes":["PULL","16/23"]}