{"id":810974,"url":"http://patchwork.ozlabs.org/api/1.2/patches/810974/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20170907073211.zgcgmdfrphtqy3d7@mwanda/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.2/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170907073211.zgcgmdfrphtqy3d7@mwanda>","list_archive_url":null,"date":"2017-09-07T11:12:05","name":"[2/2] pinctrl: sprd: fix off by one bugs","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3006757e0472b7564b838f08835c63cf401f5f3f","submitter":{"id":9327,"url":"http://patchwork.ozlabs.org/api/1.2/people/9327/?format=json","name":"Dan Carpenter","email":"dan.carpenter@oracle.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20170907073211.zgcgmdfrphtqy3d7@mwanda/mbox/","series":[{"id":1927,"url":"http://patchwork.ozlabs.org/api/1.2/series/1927/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=1927","date":"2017-09-07T07:29:26","name":"[1/2] pinctrl: sprd: check for allocation failure","version":1,"mbox":"http://patchwork.ozlabs.org/series/1927/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810974/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810974/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnyTp3pMTz9s9Y\n\tfor ;\n\tThu, 7 Sep 2017 21:12:30 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754146AbdIGLM2 (ORCPT );\n\tThu, 7 Sep 2017 07:12:28 -0400","from aserp1040.oracle.com ([141.146.126.69]:39034 \"EHLO\n\taserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754024AbdIGLM2 (ORCPT\n\t); Thu, 7 Sep 2017 07:12:28 -0400","from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2)\n\twith ESMTP id v87BCMJq001763\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 7 Sep 2017 11:12:22 GMT","from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235])\n\tby aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv87BCMX6017043\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 7 Sep 2017 11:12:22 GMT","from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9])\n\tby aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v87BCLPN029366; \n\tThu, 7 Sep 2017 11:12:21 GMT","from mwanda (/197.157.34.182)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 07 Sep 2017 04:12:20 -0700"],"Date":"Thu, 7 Sep 2017 14:12:05 +0300","From":"Dan Carpenter ","To":"Linus Walleij ,\n\tBaolin Wang ","Cc":"linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org","Subject":"[PATCH 2/2] pinctrl: sprd: fix off by one bugs","Message-ID":"<20170907073211.zgcgmdfrphtqy3d7@mwanda>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170907072926.56oqezwk4r72yjgt@mwanda>","X-Mailer":"git-send-email haha only kidding","User-Agent":"NeoMutt/20170609 (1.8.3)","X-Source-IP":"aserv0021.oracle.com [141.146.126.233]","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"},"content":"info->groups[] has info->ngroups elements so these comparisons should be\n>= instead of >.\n\nFixes: 41d32cfce1ae (\"pinctrl: sprd: Add Spreadtrum pin control driver\")\nSigned-off-by: Dan Carpenter \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","diff":"diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c\nindex 673b77bbbc8c..939e1bbf6253 100644\n--- a/drivers/pinctrl/sprd/pinctrl-sprd.c\n+++ b/drivers/pinctrl/sprd/pinctrl-sprd.c\n@@ -400,7 +400,7 @@ static int sprd_pmx_set_mux(struct pinctrl_dev *pctldev,\n \tunsigned long reg;\n \tunsigned int val = 0;\n \n-\tif (group_selector > info->ngroups)\n+\tif (group_selector >= info->ngroups)\n \t\treturn -EINVAL;\n \n \tswitch (func_selector) {\n@@ -734,7 +734,7 @@ static int sprd_pinconf_group_get(struct pinctrl_dev *pctldev,\n \tstruct sprd_pin_group *grp;\n \tunsigned int pin_id;\n \n-\tif (selector > info->ngroups)\n+\tif (selector >= info->ngroups)\n \t\treturn -EINVAL;\n \n \tgrp = &info->groups[selector];\n@@ -753,7 +753,7 @@ static int sprd_pinconf_group_set(struct pinctrl_dev *pctldev,\n \tstruct sprd_pin_group *grp;\n \tint ret, i;\n \n-\tif (selector > info->ngroups)\n+\tif (selector >= info->ngroups)\n \t\treturn -EINVAL;\n \n \tgrp = &info->groups[selector];\n@@ -813,7 +813,7 @@ static void sprd_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,\n \tconst char *name;\n \tint i, ret;\n \n-\tif (selector > info->ngroups)\n+\tif (selector >= info->ngroups)\n \t\treturn;\n \n \tgrp = &info->groups[selector];\n","prefixes":["2/2"]}