{"id":810916,"url":"http://patchwork.ozlabs.org/api/1.2/patches/810916/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170907085310.19353-1-kwolf@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170907085310.19353-1-kwolf@redhat.com>","list_archive_url":null,"date":"2017-09-07T08:53:10","name":"qemu-iotests: Add missing -machine accel=qtest","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e91e8c7fdd079daba66ecfd34b5b2831d4acf55d","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/1.2/people/2714/?format=json","name":"Kevin Wolf","email":"kwolf@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170907085310.19353-1-kwolf@redhat.com/mbox/","series":[{"id":1950,"url":"http://patchwork.ozlabs.org/api/1.2/series/1950/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1950","date":"2017-09-07T08:53:10","name":"qemu-iotests: Add missing -machine accel=qtest","version":1,"mbox":"http://patchwork.ozlabs.org/series/1950/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810916/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810916/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnvQ76XyKz9s8J\n\tfor ;\n\tThu, 7 Sep 2017 18:54:07 +1000 (AEST)","from localhost ([::1]:39395 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpsZa-0005hz-1o\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 04:54:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46402)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpsYt-0005cG-BB\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 04:53:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpsYs-0005xl-Kf\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 04:53:23 -0400","from mx1.redhat.com ([209.132.183.28]:45984)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpsYm-0005uL-Qg; Thu, 07 Sep 2017 04:53:16 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C836080464;\n\tThu, 7 Sep 2017 08:53:15 +0000 (UTC)","from dhcp-200-186.str.redhat.com (dhcp-200-186.str.redhat.com\n\t[10.33.200.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id DD4676031A;\n\tThu, 7 Sep 2017 08:53:14 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C836080464","From":"Kevin Wolf ","To":"qemu-block@nongnu.org","Date":"Thu, 7 Sep 2017 10:53:10 +0200","Message-Id":"<20170907085310.19353-1-kwolf@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 07 Sep 2017 08:53:15 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH] qemu-iotests: Add missing -machine accel=qtest","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, cohuck@redhat.com, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"A basic set of qemu options is initialised in ./common:\n\n export QEMU_OPTIONS=\"-nodefaults -machine accel=qtest\"\n\nHowever, two test cases (172 and 186) overwrite QEMU_OPTIONS and neglect\nto manually set '-machine accel=qtest'. Add the missing option for 172.\n186 probably only copied the code from 172, it doesn't actually need to\noverwrite QEMU_OPTIONS, so remove that in 186.\n\nSigned-off-by: Kevin Wolf \n---\n tests/qemu-iotests/172 | 2 +-\n tests/qemu-iotests/186 | 6 +++---\n 2 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/tests/qemu-iotests/172 b/tests/qemu-iotests/172\nindex 826d6fecd3..02c5f79bab 100755\n--- a/tests/qemu-iotests/172\n+++ b/tests/qemu-iotests/172\n@@ -56,7 +56,7 @@ function do_run_qemu()\n done\n fi\n echo quit\n- ) | $QEMU -nographic -monitor stdio -serial none \"$@\"\n+ ) | $QEMU -machine accel=qtest -nographic -monitor stdio -serial none \"$@\"\n echo\n }\n \ndiff --git a/tests/qemu-iotests/186 b/tests/qemu-iotests/186\nindex 2b9f618f90..44cc01ed87 100755\n--- a/tests/qemu-iotests/186\n+++ b/tests/qemu-iotests/186\n@@ -56,15 +56,15 @@ function do_run_qemu()\n done\n fi\n echo quit\n- ) | $QEMU -S -nodefaults -display none -device virtio-scsi-pci -monitor stdio \"$@\" 2>&1\n+ ) | $QEMU -S -display none -device virtio-scsi-pci -monitor stdio \"$@\" 2>&1\n echo\n }\n \n function check_info_block()\n {\n echo \"info block\" |\n- QEMU_OPTIONS=\"\" do_run_qemu \"$@\" | _filter_win32 | _filter_hmp |\n- _filter_qemu | _filter_generated_node_ids\n+ do_run_qemu \"$@\" | _filter_win32 | _filter_hmp | _filter_qemu |\n+ _filter_generated_node_ids\n }\n \n \n","prefixes":[]}