{"id":810885,"url":"http://patchwork.ozlabs.org/api/1.2/patches/810885/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20170907080327.21390-1-shuwang@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.2/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170907080327.21390-1-shuwang@redhat.com>","list_archive_url":null,"date":"2017-09-07T08:03:27","name":"cifs: release cifs root_cred after exit_cifs","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"320f8c157de399899f4e9237c1bd6e82e15402d4","submitter":{"id":72314,"url":"http://patchwork.ozlabs.org/api/1.2/people/72314/?format=json","name":"Shu Wang","email":"shuwang@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20170907080327.21390-1-shuwang@redhat.com/mbox/","series":[{"id":1936,"url":"http://patchwork.ozlabs.org/api/1.2/series/1936/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=1936","date":"2017-09-07T08:03:27","name":"cifs: release cifs root_cred after exit_cifs","version":1,"mbox":"http://patchwork.ozlabs.org/series/1936/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810885/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810885/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=shuwang@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xntHt0GvLz9s9Y\n\tfor ;\n\tThu, 7 Sep 2017 18:03:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752276AbdIGIDg (ORCPT );\n\tThu, 7 Sep 2017 04:03:36 -0400","from mx1.redhat.com ([209.132.183.28]:58572 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751055AbdIGIDf (ORCPT );\n\tThu, 7 Sep 2017 04:03:35 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3AD754E4C2;\n\tThu, 7 Sep 2017 08:03:35 +0000 (UTC)","from d760b8.nay.redhat.com (dhcp-12-134.nay.redhat.com\n\t[10.66.12.134])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9881518A20;\n\tThu, 7 Sep 2017 08:03:30 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3AD754E4C2","From":"shuwang@redhat.com","To":"sfrench@samba.org","Cc":"linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,\n\tlinux-kernel@vger.kernel.org, chuhu@redhat.com, liwang@redhat.com,\n\tShu Wang ","Subject":"[PATCH] cifs: release cifs root_cred after exit_cifs","Date":"Thu, 7 Sep 2017 16:03:27 +0800","Message-Id":"<20170907080327.21390-1-shuwang@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 07 Sep 2017 08:03:35 +0000 (UTC)","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"},"content":"From: Shu Wang \n\nmemory leak was found by kmemleak. exit_cifs_spnego\nshould be called before cifs module removed, or\ncifs root_cred will not be released.\n\nkmemleak report:\nunreferenced object 0xffff880070a3ce40 (size 192):\n backtrace:\n kmemleak_alloc+0x4a/0xa0\n kmem_cache_alloc+0xc7/0x1d0\n prepare_kernel_cred+0x20/0x120\n init_cifs_spnego+0x2d/0x170 [cifs]\n 0xffffffffc07801f3\n do_one_initcall+0x51/0x1b0\n do_init_module+0x60/0x1fd\n load_module+0x161e/0x1b60\n SYSC_finit_module+0xa9/0x100\n SyS_finit_module+0xe/0x10\n\nSigned-off-by: Shu Wang \n---\n fs/cifs/cifsfs.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c\nindex 180b3356ff86..a92bdb89bde3 100644\n--- a/fs/cifs/cifsfs.c\n+++ b/fs/cifs/cifsfs.c\n@@ -1447,7 +1447,7 @@ exit_cifs(void)\n \texit_cifs_idmap();\n #endif\n #ifdef CONFIG_CIFS_UPCALL\n-\tunregister_key_type(&cifs_spnego_key_type);\n+\texit_cifs_spnego();\n #endif\n \tcifs_destroy_request_bufs();\n \tcifs_destroy_mids();\n","prefixes":[]}