{"id":810875,"url":"http://patchwork.ozlabs.org/api/1.2/patches/810875/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20170907072926.56oqezwk4r72yjgt@mwanda/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.2/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170907072926.56oqezwk4r72yjgt@mwanda>","list_archive_url":null,"date":"2017-09-07T07:29:26","name":"[1/2] pinctrl: sprd: check for allocation failure","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"978a9f5a80876f3f0b004364cbbe47820615a060","submitter":{"id":9327,"url":"http://patchwork.ozlabs.org/api/1.2/people/9327/?format=json","name":"Dan Carpenter","email":"dan.carpenter@oracle.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20170907072926.56oqezwk4r72yjgt@mwanda/mbox/","series":[{"id":1927,"url":"http://patchwork.ozlabs.org/api/1.2/series/1927/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=1927","date":"2017-09-07T07:29:26","name":"[1/2] pinctrl: sprd: check for allocation failure","version":1,"mbox":"http://patchwork.ozlabs.org/series/1927/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810875/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810875/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnsZ563w0z9sRY\n\tfor ;\n\tThu, 7 Sep 2017 17:30:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753312AbdIGHaw (ORCPT );\n\tThu, 7 Sep 2017 03:30:52 -0400","from aserp1040.oracle.com ([141.146.126.69]:42524 \"EHLO\n\taserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752315AbdIGHav (ORCPT\n\t); Thu, 7 Sep 2017 03:30:51 -0400","from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2)\n\twith ESMTP id v877UjlJ019936\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 7 Sep 2017 07:30:45 GMT","from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72])\n\tby aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v877Ui9P024973\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 7 Sep 2017 07:30:44 GMT","from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22])\n\tby userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tv877UhHc001046; Thu, 7 Sep 2017 07:30:43 GMT","from mwanda (/197.157.0.35)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 07 Sep 2017 00:30:42 -0700"],"Date":"Thu, 7 Sep 2017 10:29:26 +0300","From":"Dan Carpenter ","To":"Linus Walleij ,\n\tBaolin Wang ","Cc":"linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org","Subject":"[PATCH 1/2] pinctrl: sprd: check for allocation failure","Message-ID":"<20170907072926.56oqezwk4r72yjgt@mwanda>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","X-Mailer":"git-send-email haha only kidding","User-Agent":"NeoMutt/20170609 (1.8.3)","X-Source-IP":"aserv0022.oracle.com [141.146.126.234]","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"},"content":"devm_pinctrl_get() could fail with ERR_PTR(-ENOMEM) so I have added a\ncheck for that. I also reversed the other IS_ERR() test because it was\na little confusing to test one way and then the opposite a couple lines\nlater.\n\nFixes: 41d32cfce1ae (\"pinctrl: sprd: Add Spreadtrum pin control driver\")\nSigned-off-by: Dan Carpenter \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","diff":"diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c\nindex 7e7b9ac7e836..673b77bbbc8c 100644\n--- a/drivers/pinctrl/sprd/pinctrl-sprd.c\n+++ b/drivers/pinctrl/sprd/pinctrl-sprd.c\n@@ -1100,12 +1100,16 @@ int sprd_pinctrl_remove(struct platform_device *pdev)\n \n void sprd_pinctrl_shutdown(struct platform_device *pdev)\n {\n-\tstruct pinctrl *pinctl = devm_pinctrl_get(&pdev->dev);\n+\tstruct pinctrl *pinctl;\n \tstruct pinctrl_state *state;\n \n+\tpinctl = devm_pinctrl_get(&pdev->dev);\n+\tif (IS_ERR(pinctl))\n+\t\treturn;\n \tstate = pinctrl_lookup_state(pinctl, \"shutdown\");\n-\tif (!IS_ERR(state))\n-\t\tpinctrl_select_state(pinctl, state);\n+\tif (IS_ERR(state))\n+\t\treturn;\n+\tpinctrl_select_state(pinctl, state);\n }\n \n MODULE_DESCRIPTION(\"SPREADTRUM Pin Controller Driver\");\n","prefixes":["1/2"]}