{"id":810778,"url":"http://patchwork.ozlabs.org/api/1.2/patches/810778/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/1504729681-3504-14-git-send-email-deller@gmx.de/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.2/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504729681-3504-14-git-send-email-deller@gmx.de>","list_archive_url":null,"date":"2017-09-06T20:28:00","name":"[13/14] netfilter/ipvs: Use %pS printk format for direct addresses","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"71c70196ef2c00c2ccceabb4fe6a46db84e78656","submitter":{"id":1115,"url":"http://patchwork.ozlabs.org/api/1.2/people/1115/?format=json","name":"Helge Deller","email":"deller@gmx.de"},"delegate":{"id":6139,"url":"http://patchwork.ozlabs.org/api/1.2/users/6139/?format=json","username":"pablo","first_name":"Pablo","last_name":"Neira","email":"pablo@netfilter.org"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/1504729681-3504-14-git-send-email-deller@gmx.de/mbox/","series":[{"id":1873,"url":"http://patchwork.ozlabs.org/api/1.2/series/1873/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=1873","date":"2017-09-06T20:28:00","name":null,"version":1,"mbox":"http://patchwork.ozlabs.org/series/1873/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810778/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810778/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnZxG3mqmz9t2r\n\tfor ;\n\tThu, 7 Sep 2017 06:31:30 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753178AbdIFUa7 (ORCPT );\n\tWed, 6 Sep 2017 16:30:59 -0400","from mout.gmx.net ([212.227.15.18]:64434 \"EHLO mout.gmx.net\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752693AbdIFU2S (ORCPT );\n\tWed, 6 Sep 2017 16:28:18 -0400","from p100.fritz.box ([193.159.16.8]) by mail.gmx.com (mrgmx001\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 0MBExR-1diJ5A3ukv-00AF12;\n\tWed, 06 Sep 2017 22:28:10 +0200"],"From":"Helge Deller ","To":"linux-kernel@vger.kernel.org","Cc":"Sergey Senozhatsky ,\n\tPetr Mladek ,\n\tAndrew Morton ,\n\tWensong Zhang , netdev@vger.kernel.org,\n\tlvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org","Subject":"[PATCH 13/14] netfilter/ipvs: Use %pS printk format for direct\n\taddresses","Date":"Wed, 6 Sep 2017 22:28:00 +0200","Message-Id":"<1504729681-3504-14-git-send-email-deller@gmx.de>","X-Mailer":"git-send-email 2.1.0","In-Reply-To":"<1504729681-3504-1-git-send-email-deller@gmx.de>","References":"<1504729681-3504-1-git-send-email-deller@gmx.de>","X-Provags-ID":"V03:K0:IPyGDTPDEnlrPYfs7kn5j/D4+CPakpL71kinjb3VoHWpgkjlMhL\n\tGWQJgI0K0DgVCQ3UNQsRqSzuEMaVa9zwvm1FkgW0EEcx8UWgbmyhkl+RcOJbkUysKRQdlDs\n\tuwcab4crvYy7h86Dnhjz/1nnmpKmhPFYXDj+Sae790mqmd0y7wKYdHsFq8xL4OxnEDGMsAv\n\tnrs0l1jQqNY6jQTaEawtQ==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:d4QUHjZIVv0=:AkYT+HNVjjPCcreJtkVysI\n\t6H9/fVr7B3hch+24YRtV30mZj86zUHxYsEKCGjN/ajwVEJLSEEVd8+1RO6UcTzmykHwgBlMxL\n\tCxVXm81sUQZU04kwLmnef9n7NKWhiU6qx1n+Ypp1llT2SgYnSnSwqJ+isy3fvhFJALgTMFuVA\n\tOmqADF4W+mOmHI3+oEwE+7VkuKNcy/QYOviId9pE71UcbWT4W3iPDerubC8+YcYvJkbvswd8R\n\tI0pafSuMd9ouZWEJnlC/AC2uChmW848VKsQmzFeALtz+jeULcgl4kHKzyJNwnsglpcvdjFaDl\n\t6KGErGbJGY9m/lmVGp7giN+Knv8lGmrTa22ht4y3plW4fYc6JAoRrKnHICe7S1Hkv3wNywuQX\n\ti3uJ33mXU3XNi02kuuceQPwLSKG5rvlWTyxHI0X5SgB+Xjoc0nsX37qbCLaNURLGGvD5O5C5t\n\tM2YHD8M8gk4ydpyf+yZybtXt8f6ZunZi17e+9l3c4Pf7yD4z66GVWWqd2iziQpn5dLqNUtVAK\n\t5wR6Gb8GoYESM2lnvJGn/W3hYzndV3IeGH4eldLGEKqAapmnt27k+CCl60h7TYnzRkSI8D7EA\n\tWD/PWWx5WcSfa3FXAWOYCo5lihoKwFn2ajmaUIBgUFUc8Z/W8War/mUbCIkJkj7bnjqQkpR92\n\tHLgOtrGSs/jNmZUzH8lgo9dXLKGCknRvyhrNxJGDZz0VzFWRBlZ1q3B1/0Nq/I88qio4HmHos\n\tArJgy1g2pz+4RCfoFyQLO7rW0LVRH1oEWeMJMPC8zfd4V9x/ZKN9TLStvMbpBGthl5fc1wU9+\n\tcdcw/c7CxMHI/nHnc79gTdOhJMNww==","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"},"content":"The debug and error printk functions in ipvs uses wrongly the %pF instead of\nthe %pS printk format specifier for printing symbols for the address returned\nby _builtin_return_address(0). Fix it for the ia64, ppc64 and parisc64\narchitectures.\n\nSigned-off-by: Helge Deller \nCc: Wensong Zhang \nCc: netdev@vger.kernel.org\nCc: lvs-devel@vger.kernel.org\nCc: netfilter-devel@vger.kernel.org\n---\n net/netfilter/ipvs/ip_vs_conn.c | 2 +-\n net/netfilter/ipvs/ip_vs_ctl.c | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c\nindex 3d2ac71a..f73561c 100644\n--- a/net/netfilter/ipvs/ip_vs_conn.c\n+++ b/net/netfilter/ipvs/ip_vs_conn.c\n@@ -185,7 +185,7 @@ static inline int ip_vs_conn_hash(struct ip_vs_conn *cp)\n \t\thlist_add_head_rcu(&cp->c_list, &ip_vs_conn_tab[hash]);\n \t\tret = 1;\n \t} else {\n-\t\tpr_err(\"%s(): request for already hashed, called from %pF\\n\",\n+\t\tpr_err(\"%s(): request for already hashed, called from %pS\\n\",\n \t\t __func__, __builtin_return_address(0));\n \t\tret = 0;\n \t}\ndiff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c\nindex 1fa3c23..88fc58a 100644\n--- a/net/netfilter/ipvs/ip_vs_ctl.c\n+++ b/net/netfilter/ipvs/ip_vs_ctl.c\n@@ -300,7 +300,7 @@ static int ip_vs_svc_hash(struct ip_vs_service *svc)\n \tunsigned int hash;\n \n \tif (svc->flags & IP_VS_SVC_F_HASHED) {\n-\t\tpr_err(\"%s(): request for already hashed, called from %pF\\n\",\n+\t\tpr_err(\"%s(): request for already hashed, called from %pS\\n\",\n \t\t __func__, __builtin_return_address(0));\n \t\treturn 0;\n \t}\n@@ -334,7 +334,7 @@ static int ip_vs_svc_hash(struct ip_vs_service *svc)\n static int ip_vs_svc_unhash(struct ip_vs_service *svc)\n {\n \tif (!(svc->flags & IP_VS_SVC_F_HASHED)) {\n-\t\tpr_err(\"%s(): request for unhash flagged, called from %pF\\n\",\n+\t\tpr_err(\"%s(): request for unhash flagged, called from %pS\\n\",\n \t\t __func__, __builtin_return_address(0));\n \t\treturn 0;\n \t}\n","prefixes":["13/14"]}