{"id":810732,"url":"http://patchwork.ozlabs.org/api/1.2/patches/810732/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1504717269-11918-1-git-send-email-suneelglinux@gmail.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504717269-11918-1-git-send-email-suneelglinux@gmail.com>","list_archive_url":null,"date":"2017-09-06T17:01:09","name":"[U-Boot,v1] cmd: usb: add blk devices to ignore list in tree graph","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4b10b69b0cf9b0163d096c8f223a67f4ac2882c4","submitter":{"id":72058,"url":"http://patchwork.ozlabs.org/api/1.2/people/72058/?format=json","name":"Suneel Garapati","email":"suneelglinux@gmail.com"},"delegate":{"id":1699,"url":"http://patchwork.ozlabs.org/api/1.2/users/1699/?format=json","username":"marex","first_name":"Marek","last_name":"Vasut","email":"marek.vasut@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1504717269-11918-1-git-send-email-suneelglinux@gmail.com/mbox/","series":[{"id":1857,"url":"http://patchwork.ozlabs.org/api/1.2/series/1857/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=1857","date":"2017-09-06T17:01:09","name":"[U-Boot,v1] cmd: usb: add blk devices to ignore list in tree graph","version":1,"mbox":"http://patchwork.ozlabs.org/series/1857/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810732/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810732/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lM5Y87Mn\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnVGv6Mmwz9t3Z\n\tfor ;\n\tThu, 7 Sep 2017 03:01:27 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 829FAC21EB9; Wed, 6 Sep 2017 17:01:21 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id AA76FC21E3B;\n\tWed, 6 Sep 2017 17:01:19 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5CADAC21E3B; Wed, 6 Sep 2017 17:01:18 +0000 (UTC)","from mail-pf0-f193.google.com (mail-pf0-f193.google.com\n\t[209.85.192.193])\n\tby lists.denx.de (Postfix) with ESMTPS id C20C0C21D88\n\tfor ; Wed, 6 Sep 2017 17:01:17 +0000 (UTC)","by mail-pf0-f193.google.com with SMTP id f84so1406745pfj.3\n\tfor ; Wed, 06 Sep 2017 10:01:17 -0700 (PDT)","from suneel.hsd1.ca.comcast.net\n\t([2601:646:8e00:e521:a8ab:948d:75cf:79c4])\n\tby smtp.gmail.com with ESMTPSA id\n\th1sm343899pfg.153.2017.09.06.10.01.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 06 Sep 2017 10:01:12 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=JSlVb967taIvf7rKQu4ZgW42KAQ+LWts6KB+xhEEHos=;\n\tb=lM5Y87Mn+cwY8Lm/1Pk7C6BH55AmibTXuIJ+E+UYk1g9dEo371VWcWDwZdPo7ghw5R\n\timl9bKOlQbx1ulMqdRZPOv+OTlgjuT7jjkYsBKHpLW07IxBC0EFFwJ3tDUabJG/S0JBJ\n\t1ym3jzNu+VqSNJBADuHUPvPaNoWDCsdNoTupiicUQp4L1LLAevsbD4+suKJQ1ashCvkE\n\tex7cPqnGU2Gflr/x+Bf9GOHy7IANu3sYEfuIih3damRSFN9dOIYrtJkY0ZyzfDcKrUdV\n\t5/3VVSqR1WpIebLdBSlYfjCCqG5ov+MNPXPrTOb2/nWtFxKb8W6twslCgpyNE487swEE\n\tQUEg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=JSlVb967taIvf7rKQu4ZgW42KAQ+LWts6KB+xhEEHos=;\n\tb=PKh57+cYOwQytc3r58QZIHWYzvMW7A/pIE6H0iuApFci5b1o4gY5+LOg9hsfXCSl17\n\tx403z9+73+wswm1KYzy8Hk5HeW6vkafq5/PF4An1DDeC3RNaqdC9lkaO4KeacpWAc89b\n\t1b4nETu8Kav6Xgy7i2WPG9z6ixAYzroBLcKZb4viyaY49/ROmSvwxA08AQ21epFtuf0D\n\t9u24s9zCs762c3Ex3sIcdmEtQ4fcAs8zQOi/HFosiWTK9n6fP5pNgfiYy/4Nj7xc7gsm\n\tYG/7CucqTDKYGeqKaWnlJ7LECJyXPGOuP8xNHYodZgansflOWO4E75nbPVQYvwpEpuXm\n\tUu0A==","X-Gm-Message-State":"AHPjjUiQkCi2BQ7P0h9hH3301YTnAYWG9rNjk4WzUQAzMvwbPMLNihxm\n\tPWXy4cEsx/HI9A==","X-Google-Smtp-Source":"ADKCNb5xoeuY4TUV0u00AZXRfD9/I/JduHirU4KKdfnvprqRWi7TCmmM4moSTUgsV4jUhCw4c7DraQ==","X-Received":"by 10.99.63.135 with SMTP id m129mr8612437pga.207.1504717272679; \n\tWed, 06 Sep 2017 10:01:12 -0700 (PDT)","From":"Suneel Garapati ","To":"Stefan Roese ","Date":"Wed, 6 Sep 2017 10:01:09 -0700","Message-Id":"<1504717269-11918-1-git-send-email-suneelglinux@gmail.com>","X-Mailer":"git-send-email 2.7.4","Cc":"u-boot@lists.denx.de, Michal Simek ","Subject":"[U-Boot] [PATCH v1] cmd: usb: add blk devices to ignore list in\n\ttree graph","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"add blk child devices to ignore list while displaying\nusb tree graph, otherwise usb tree and info commands\nmay cause crash treating blk as usb device.\n\nSigned-off-by: Suneel Garapati \n---\n\nChanges v1:\n - add separate check on blk uclass\n - modify description\n - add separate check on parent uclass as usb\n\n cmd/usb.c | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)","diff":"diff --git a/cmd/usb.c b/cmd/usb.c\nindex d95bcf5..cb0e183 100644\n--- a/cmd/usb.c\n+++ b/cmd/usb.c\n@@ -414,8 +414,13 @@ static void usb_show_tree_graph(struct usb_device *dev, char *pre)\n \n \t\tudev = dev_get_parent_priv(child);\n \n-\t\t/* Ignore emulators, we only want real devices */\n-\t\tif (device_get_uclass_id(child) != UCLASS_USB_EMUL) {\n+\t\t/*\n+\t\t * Ignore emulators and block child devices, with check on\n+\t\t * parent uclass as usb, we only want real devices\n+\t\t */\n+\t\tif ((device_get_uclass_id(child) != UCLASS_USB_EMUL) &&\n+\t\t (device_get_uclass_id(child) != UCLASS_BLK) &&\n+\t\t (device_get_uclass_id(child->parent) == UCLASS_USB)) {\n \t\t\tusb_show_tree_graph(udev, pre);\n \t\t\tpre[index] = 0;\n \t\t}\n@@ -605,7 +610,8 @@ static void usb_show_info(struct usb_device *udev)\n \tfor (device_find_first_child(udev->dev, &child);\n \t child;\n \t device_find_next_child(&child)) {\n-\t\tif (device_active(child)) {\n+\t\tif (device_active(child) &&\n+\t\t (device_get_uclass_id(child) != UCLASS_BLK)) {\n \t\t\tudev = dev_get_parent_priv(child);\n \t\t\tusb_show_info(udev);\n \t\t}\n","prefixes":["U-Boot","v1"]}