{"id":810724,"url":"http://patchwork.ozlabs.org/api/1.2/patches/810724/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906160612.22769-28-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170906160612.22769-28-richard.henderson@linaro.org>","list_archive_url":null,"date":"2017-09-06T16:06:07","name":"[PULL,27/32] target/arm: [tcg,a64] Port to disas_log","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d740a77dd25dec7df647f67e7230d0361fbcd181","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.2/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906160612.22769-28-richard.henderson@linaro.org/mbox/","series":[{"id":1847,"url":"http://patchwork.ozlabs.org/api/1.2/series/1847/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1847","date":"2017-09-06T16:05:41","name":"[PULL,01/32] tcg: Add generic DISAS_NORETURN","version":1,"mbox":"http://patchwork.ozlabs.org/series/1847/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810724/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810724/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"D8pQR9sj\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnTl96jd7z9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu,  7 Sep 2017 02:37:24 +1000 (AEST)","from localhost ([::1]:37100 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dpdKM-0000eK-MG\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 12:37:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42005)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dpcqv-0000Xt-LO\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:07:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dpcqp-0002ss-QY\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:06:57 -0400","from mail-pg0-x22d.google.com ([2607:f8b0:400e:c05::22d]:35581)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <richard.henderson@linaro.org>)\n\tid 1dpcqp-0002rK-Kg\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:06:51 -0400","by mail-pg0-x22d.google.com with SMTP id 188so12739150pgb.2\n\tfor <qemu-devel@nongnu.org>; Wed, 06 Sep 2017 09:06:51 -0700 (PDT)","from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net.\n\t[97.126.108.236]) by smtp.gmail.com with ESMTPSA id\n\tt65sm262863pfk.59.2017.09.06.09.06.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 06 Sep 2017 09:06:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=zTHnNo4fpTvvHZYmEhurskvtWnhzILXVy4UhrbbCYXM=;\n\tb=D8pQR9sjA5G9Qmb99cbnG6iurAxDYUp6rNJJ/BSXWoY30IyraUOjhaflF+E27mNMQE\n\tZlHhBBkD41BneLfWDjpZY6kRGpQ9U8ibj4ZjWH38rWsGWhTMq+VfLumR+23L+gExGvVY\n\tt0h+DsGkB0CmZz8w2TNp9o4baqWldlE+0Wi3U=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=zTHnNo4fpTvvHZYmEhurskvtWnhzILXVy4UhrbbCYXM=;\n\tb=EmzhB1PcciKfZ9vSW0ApQNDrkydeevcbtAWEZstwKWKtNxzVrti6ZXAEAuEB8KgIwg\n\tNe9XGAidRfYi0vBI2TRGBchEfxMEEJXzy4y8Q2M9RLNDlSfJa+5QiF64w7abg1vNHcXP\n\t+zkIhHrssGpicmtv9WvxXXX6KDLursFu0McoOz2/1Rsdnyn0STPKQxacKZdn9NDTTslE\n\tOflsNGsEf8H9trsZ1zTP8wvXgF2NptTwiAIuyOSkLEnZVI22K2zc+fM+XqAboBggzsE2\n\tWzzB78YzoJZNYGmZ9j0auWKXsCM5dbdn6pxkngSyq521KhVBh7fG4gvJYfw03aiRtaru\n\tf1YA==","X-Gm-Message-State":"AHPjjUgv2NW80vxecW/kWwkievxUS5Y/SZbGEXkFFoIzG/rNUgrcB++C\n\t9ODgAMRgaNsoNb5pPT3e/w==","X-Google-Smtp-Source":"ADKCNb4CrrQ7YiaRh0+wocy6gk7wDoTf23/pb3scbXyfuyR5GXWhZoguk0g5z4pxW+OLLcfbky/C8w==","X-Received":"by 10.84.131.109 with SMTP id 100mr8848919pld.122.1504714010503; \n\tWed, 06 Sep 2017 09:06:50 -0700 (PDT)","From":"Richard Henderson <richard.henderson@linaro.org>","To":"qemu-devel@nongnu.org","Date":"Wed,  6 Sep 2017 09:06:07 -0700","Message-Id":"<20170906160612.22769-28-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170906160612.22769-1-richard.henderson@linaro.org>","References":"<20170906160612.22769-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::22d","Subject":"[Qemu-devel] [PULL 27/32] target/arm: [tcg,a64] Port to disas_log","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"peter.maydell@linaro.org, =?utf-8?q?Llu=C3=ADs_Vilanova?=\n\t<vilanova@ac.upc.edu>, \tRichard Henderson <rth@twiddle.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"From: Lluís Vilanova <vilanova@ac.upc.edu>\n\nIncrementally paves the way towards using the generic instruction translation\nloop.\n\nReviewed-by: Emilio G. Cota <cota@braap.org>\nReviewed-by: Richard Henderson <rth@twiddle.net>\nSigned-off-by: Lluís Vilanova <vilanova@ac.upc.edu>\nMessage-Id: <150002606914.22386.15524101311003685068.stgit@frigg.lan>\n[rth: Move tb->size computation and use that result.]\nSigned-off-by: Richard Henderson <rth@twiddle.net>\n---\n target/arm/translate-a64.c | 19 ++++++++++++++-----\n 1 file changed, 14 insertions(+), 5 deletions(-)","diff":"diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c\nindex 723e86c976..1973a36462 100644\n--- a/target/arm/translate-a64.c\n+++ b/target/arm/translate-a64.c\n@@ -11393,6 +11393,16 @@ static void aarch64_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu)\n     }\n }\n \n+static void aarch64_tr_disas_log(const DisasContextBase *dcbase,\n+                                      CPUState *cpu)\n+{\n+    DisasContext *dc = container_of(dcbase, DisasContext, base);\n+\n+    qemu_log(\"IN: %s\\n\", lookup_symbol(dc->base.pc_first));\n+    log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size,\n+                     4 | (bswap_code(dc->sctlr_b) ? 2 : 0));\n+}\n+\n void gen_intermediate_code_a64(DisasContextBase *dcbase, CPUState *cs,\n                                TranslationBlock *tb)\n {\n@@ -11468,18 +11478,17 @@ void gen_intermediate_code_a64(DisasContextBase *dcbase, CPUState *cs,\n \n     gen_tb_end(tb, dc->base.num_insns);\n \n+    dc->base.tb->size = dc->pc - dc->base.pc_first;\n+    dc->base.tb->icount = dc->base.num_insns;\n+\n #ifdef DEBUG_DISAS\n     if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM) &&\n         qemu_log_in_addr_range(dc->base.pc_first)) {\n         qemu_log_lock();\n         qemu_log(\"----------------\\n\");\n-        qemu_log(\"IN: %s\\n\", lookup_symbol(dc->base.pc_first));\n-        log_target_disas(cs, dc->base.pc_first, dc->pc - dc->base.pc_first,\n-                         4 | (bswap_code(dc->sctlr_b) ? 2 : 0));\n+        aarch64_tr_disas_log(&dc->base, cs);\n         qemu_log(\"\\n\");\n         qemu_log_unlock();\n     }\n #endif\n-    dc->base.tb->size = dc->pc - dc->base.pc_first;\n-    dc->base.tb->icount = dc->base.num_insns;\n }\n","prefixes":["PULL","27/32"]}