{"id":810710,"url":"http://patchwork.ozlabs.org/api/1.2/patches/810710/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906160612.22769-27-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170906160612.22769-27-richard.henderson@linaro.org>","list_archive_url":null,"date":"2017-09-06T16:06:06","name":"[PULL,26/32] target/arm: [tcg] Port to disas_log","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"99e8d3e780c2d58d4081dcee290df4f917333879","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.2/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906160612.22769-27-richard.henderson@linaro.org/mbox/","series":[{"id":1847,"url":"http://patchwork.ozlabs.org/api/1.2/series/1847/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1847","date":"2017-09-06T16:05:41","name":"[PULL,01/32] tcg: Add generic DISAS_NORETURN","version":1,"mbox":"http://patchwork.ozlabs.org/series/1847/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810710/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810710/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"DYEOaXnQ\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnTLS6krYz9sRV\n\tfor ;\n\tThu, 7 Sep 2017 02:19:28 +1000 (AEST)","from localhost ([::1]:37006 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpd30-0002EX-Sp\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 12:19:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41950)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpcqp-0000QN-MY\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:06:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpcqo-0002qf-Mk\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:06:51 -0400","from mail-pf0-x234.google.com ([2607:f8b0:400e:c00::234]:36484)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpcqo-0002qO-Ht\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:06:50 -0400","by mail-pf0-x234.google.com with SMTP id e199so13453818pfh.3\n\tfor ; Wed, 06 Sep 2017 09:06:50 -0700 (PDT)","from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net.\n\t[97.126.108.236]) by smtp.gmail.com with ESMTPSA id\n\tt65sm262863pfk.59.2017.09.06.09.06.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 06 Sep 2017 09:06:48 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=pEMSMV5Z7pScAAcMP+yKs/Gg5lY3QrUgOjrToUNpIiA=;\n\tb=DYEOaXnQqzDP5qiNQIzU59g1TIyI5m3U1tI+gxHhAIpoFfrOjdomeOedJnu1V4Kag5\n\tFBhWGb7jeDLfHV5ko2Cm3LHQcZzMfyBoWtIN0vgzpYOugtOjClT10zD/HGIQs9ze64aW\n\tvSSxK5rj9O4Ipbn1dUltL6OXExjGG4iZNjQAQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=pEMSMV5Z7pScAAcMP+yKs/Gg5lY3QrUgOjrToUNpIiA=;\n\tb=GbldSpfDMMF7MpW3mRlOCtQUhBvaEP2uTLk9/RMUU2ehcMP/cVG0Yj/yNcazMd1eUM\n\t5BpMtzeAe3HmbLpmrFTkkju1tQ4LiF7PsiCbKc3pLKsoeGwIYRqSJXIwBCgav6EdvBBL\n\t5szeyGgc/LnmN+TZrmAShK1YaYo/1oyNc4M/gPcmGR6yV2iUsBaCeBy7fKT01K/WLXAW\n\tYQi752eNEznOBGjZPQZxdQWdDAtGoF5JaK2w9uD7fGtVUpVKIXiGcfxJHQke9EeEuqo4\n\tibKFsl0oBJF3oiII9Khfg/WyuJIDxK7U2Th1NbLVDfX30NCSt4+pEyn7UlgaTwO1HO/p\n\tyO7A==","X-Gm-Message-State":"AHPjjUhQQly9CzapSPa237soYVNT4xzIpG1/471SXGikX5uawhwhrlIl\n\tl9FLbRbCafst7VKAKGJ35A==","X-Google-Smtp-Source":"ADKCNb4Dasx45YMUyouWpU3jqHiuZV6WRT0kQOtKJg6dou8cexlrVPASQ3m0Kj4ofGl8nKJnQ6uHGw==","X-Received":"by 10.98.201.197 with SMTP id l66mr7636810pfk.135.1504714009257; \n\tWed, 06 Sep 2017 09:06:49 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Date":"Wed, 6 Sep 2017 09:06:06 -0700","Message-Id":"<20170906160612.22769-27-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170906160612.22769-1-richard.henderson@linaro.org>","References":"<20170906160612.22769-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::234","Subject":"[Qemu-devel] [PULL 26/32] target/arm: [tcg] Port to disas_log","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, =?utf-8?q?Llu=C3=ADs_Vilanova?=\n\t, \tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Lluís Vilanova \n\nIncrementally paves the way towards using the generic instruction translation\nloop.\n\nSigned-off-by: Lluís Vilanova \nReviewed-by: Richard Henderson \nReviewed-by: Alex Benneé \nMessage-Id: <150002582711.22386.191527630537864599.stgit@frigg.lan>\n[rth: Move tb->size computation and use that result.]\nSigned-off-by: Richard Henderson \n---\n target/arm/translate.c | 18 +++++++++++++-----\n 1 file changed, 13 insertions(+), 5 deletions(-)","diff":"diff --git a/target/arm/translate.c b/target/arm/translate.c\nindex 10527b50c8..2dca196e17 100644\n--- a/target/arm/translate.c\n+++ b/target/arm/translate.c\n@@ -12171,6 +12171,15 @@ static void arm_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu)\n }\n }\n \n+static void arm_tr_disas_log(const DisasContextBase *dcbase, CPUState *cpu)\n+{\n+ DisasContext *dc = container_of(dcbase, DisasContext, base);\n+\n+ qemu_log(\"IN: %s\\n\", lookup_symbol(dc->base.pc_first));\n+ log_target_disas(cpu, dc->base.pc_first, dc->base.tb->size,\n+ dc->thumb | (dc->sctlr_b << 1));\n+}\n+\n /* generate intermediate code for basic block 'tb'. */\n void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)\n {\n@@ -12251,20 +12260,19 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)\n \n gen_tb_end(tb, dc->base.num_insns);\n \n+ tb->size = dc->pc - dc->base.pc_first;\n+ tb->icount = dc->base.num_insns;\n+\n #ifdef DEBUG_DISAS\n if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM) &&\n qemu_log_in_addr_range(dc->base.pc_first)) {\n qemu_log_lock();\n qemu_log(\"----------------\\n\");\n- qemu_log(\"IN: %s\\n\", lookup_symbol(dc->base.pc_first));\n- log_target_disas(cs, dc->base.pc_first, dc->pc - dc->base.pc_first,\n- dc->thumb | (dc->sctlr_b << 1));\n+ arm_tr_disas_log(&dc->base, cs);\n qemu_log(\"\\n\");\n qemu_log_unlock();\n }\n #endif\n- tb->size = dc->pc - dc->base.pc_first;\n- tb->icount = dc->base.num_insns;\n }\n \n static const char *cpu_mode_names[16] = {\n","prefixes":["PULL","26/32"]}