{"id":810355,"url":"http://patchwork.ozlabs.org/api/1.2/patches/810355/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/1504662052-12478-1-git-send-email-yamada.masahiro@socionext.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.2/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504662052-12478-1-git-send-email-yamada.masahiro@socionext.com>","list_archive_url":null,"date":"2017-09-06T01:40:52","name":"gpio: thunderx: select IRQ_DOMAIN_HIERARCHY instead of depends on","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"796a3bef7cfeee83e9cd5a87df46bfe07eeadc5a","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/1.2/people/65882/?format=json","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/1504662052-12478-1-git-send-email-yamada.masahiro@socionext.com/mbox/","series":[{"id":1679,"url":"http://patchwork.ozlabs.org/api/1.2/series/1679/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=1679","date":"2017-09-06T01:40:52","name":"gpio: thunderx: select IRQ_DOMAIN_HIERARCHY instead of depends on","version":1,"mbox":"http://patchwork.ozlabs.org/series/1679/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810355/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810355/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"rGayAm3h\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xn5sS2bw3z9sNc\n\tfor ;\n\tWed, 6 Sep 2017 11:41:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753505AbdIFBla (ORCPT );\n\tTue, 5 Sep 2017 21:41:30 -0400","from conuserg-09.nifty.com ([210.131.2.76]:17225 \"EHLO\n\tconuserg-09.nifty.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753474AbdIFBla (ORCPT\n\t); Tue, 5 Sep 2017 21:41:30 -0400","from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp\n\t[153.142.97.92]) (authenticated)\n\tby conuserg-09.nifty.com with ESMTP id v861etHU030333;\n\tWed, 6 Sep 2017 10:40:55 +0900"],"DKIM-Filter":"OpenDKIM Filter v2.10.3 conuserg-09.nifty.com v861etHU030333","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1504662055;\n\tbh=StCdSR3mElgXxanw8Fw/g9I9oBXbD6s90xXDjX/QV4M=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=rGayAm3hkmLW/jghsWM68jKrUBO3rWamXzusgUQKBD6jNOy0Of6vmZnxtltWkzfAV\n\tw0cOHD0KMVdNFwY8VIVuPlWR52hzISq7sgRWmbyqQHkBneNP2fO2bjbIN9v6A/+pve\n\tK4zjG0clEKU2JpxYEla8lpnYcCSjK/j8xEEFqqALziuLELFyGDI8l1rkWmkfN6L9yb\n\tZtYd2gYZFdGKR+jmPeSYqkhrFfsUBvb+GwtbSPa80v60IHQQM+st0T4Gt8HiPBvQyy\n\tlf7rNLxkDlfJcmrpTMsUqZyravIAsBUMho6Z5jVmHhFcyy5VGPJHrNWeN1JY6IzZuv\n\tGi4OOw4UhGNPQ==","X-Nifty-SrcIP":"[153.142.97.92]","From":"Masahiro Yamada ","To":"linux-gpio@vger.kernel.org","Cc":"David Daney ,\n\tMasahiro Yamada ,\n\tLinus Walleij , linux-kernel@vger.kernel.org","Subject":"[PATCH] gpio: thunderx: select IRQ_DOMAIN_HIERARCHY instead of\n\tdepends on","Date":"Wed, 6 Sep 2017 10:40:52 +0900","Message-Id":"<1504662052-12478-1-git-send-email-yamada.masahiro@socionext.com>","X-Mailer":"git-send-email 2.7.4","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"},"content":"IRQ_DOMAIN_HIERARCHY is not user-configurable, but supposed to be\nselected by drivers that need IRQ domain hierarchy support.\n\nGPIO_THUNDERX is the only user of \"depends on IRQ_DOMAIN_HIERARCHY\".\nThis means, we can not enable GPIO_THUNDERX unless other drivers\nselect IRQ_DOMAIN_HIERARCHY elsewhere. This is odd. Flip the logic.\n\nSigned-off-by: Masahiro Yamada \n---\n\n drivers/gpio/Kconfig | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig\nindex 3388d54..3f80f16 100644\n--- a/drivers/gpio/Kconfig\n+++ b/drivers/gpio/Kconfig\n@@ -453,7 +453,8 @@ config GPIO_TS4800\n config GPIO_THUNDERX\n \ttristate \"Cavium ThunderX/OCTEON-TX GPIO\"\n \tdepends on ARCH_THUNDER || (64BIT && COMPILE_TEST)\n-\tdepends on PCI_MSI && IRQ_DOMAIN_HIERARCHY\n+\tdepends on PCI_MSI\n+\tselect IRQ_DOMAIN_HIERARCHY\n \tselect IRQ_FASTEOI_HIERARCHY_HANDLERS\n \thelp\n \t Say yes here to support the on-chip GPIO lines on the ThunderX\n","prefixes":[]}