{"id":810318,"url":"http://patchwork.ozlabs.org/api/1.2/patches/810318/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1504653683-11543-2-git-send-email-jschoenh@amazon.de/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<1504653683-11543-2-git-send-email-jschoenh@amazon.de>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/1504653683-11543-2-git-send-email-jschoenh@amazon.de/","date":"2017-09-05T23:21:23","name":"[2/2] PCI: Remove unused function __pci_reset_function()","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"6fb76a55af03d5a4ca2c3c975c33adb4b446da58","submitter":{"id":72300,"url":"http://patchwork.ozlabs.org/api/1.2/people/72300/?format=json","name":"Jan H. Schönherr","email":"jschoenh@amazon.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1504653683-11543-2-git-send-email-jschoenh@amazon.de/mbox/","series":[{"id":1665,"url":"http://patchwork.ozlabs.org/api/1.2/series/1665/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=1665","date":"2017-09-05T23:21:23","name":"[1/2] PCI: Remove reset argument from pci_iov_{add, remove}_virtfn()","version":1,"mbox":"http://patchwork.ozlabs.org/series/1665/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810318/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810318/checks/","tags":{},"related":[],"headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xn2xp3pFJz9s7h\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed,  6 Sep 2017 09:30:06 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xn2xp2jSszDrJl\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed,  6 Sep 2017 09:30:06 +1000 (AEST)","from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com\n\t[52.95.49.90])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xn2mk5ymqzDrKj\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed,  6 Sep 2017 09:22:14 +1000 (AEST)","from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO\n\temail-inbound-relay-1a-e34f1ddc.us-east-1.amazon.com) ([10.43.8.6])\n\tby smtp-border-fw-out-6002.iad6.amazon.com with\n\tESMTP/TLS/DHE-RSA-AES256-SHA; 05 Sep 2017 23:22:04 +0000","from u28d244cd5724546b2f74.ant.amazon.com\n\t(iad7-ws-svc-lb50-vlan2.amazon.com [10.0.93.210])\n\tby email-inbound-relay-1a-e34f1ddc.us-east-1.amazon.com\n\t(8.14.7/8.14.7) with ESMTP id v85NLvLK042639\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\n\tTue, 5 Sep 2017 23:21:59 GMT","from u28d244cd5724546b2f74.ant.amazon.com (localhost [127.0.0.1])\n\tby u28d244cd5724546b2f74.ant.amazon.com\n\t(8.14.4/8.14.4/Debian-2ubuntu2.1) with\n\tESMTP id v85NLuDQ011664; Wed, 6 Sep 2017 01:21:56 +0200","(from jschoenh@localhost)\n\tby u28d244cd5724546b2f74.ant.amazon.com (8.14.4/8.14.4/Submit) id\n\tv85NLrEK011658; Wed, 6 Sep 2017 01:21:53 +0200"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=amazon.de header.i=@amazon.de\n\theader.b=\"S+FosY1M\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=amazon.de header.i=@amazon.de\n\theader.b=\"S+FosY1M\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=amazon.com\n\t(client-ip=52.95.49.90; helo=smtp-fw-6002.amazon.com;\n\tenvelope-from=prvs=414b27ec5=jschoenh@amazon.com; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=amazon.de header.i=@amazon.de\n\theader.b=\"S+FosY1M\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209;\n\tt=1504653734; x=1536189734;\n\th=from:to:cc:subject:date:message-id:in-reply-to:\n\treferences:mime-version:content-transfer-encoding;\n\tbh=8R+7bNT+ZKlkrv+f5f0fMLcUccE6IJRnywrzk+6Uz9g=;\n\tb=S+FosY1MKKscmh95UwiKZAxWaaG4AwNPNaHSx+/r/jTy4c1AQc5VY8ma\n\t8xjglbildruo35uKGGwSJCQIffKep4EiXtQQ3cg4l7Fi9hdy8Iq5/RB/W\n\tSMF3ru567//Xq2AKhdLn4y2nWZODNbwfngIzZTwQ1pWQubOaq9mKsDu7F M=;","X-IronPort-AV":"E=Sophos;i=\"5.41,481,1498521600\"; d=\"scan'208\";a=\"303737485\"","From":"=?utf-8?q?Jan_H=2E_Sch=C3=B6nherr?= <jschoenh@amazon.de>","To":"Bjorn Helgaas <bhelgaas@google.com>","Subject":"[PATCH 2/2] PCI: Remove unused function __pci_reset_function()","Date":"Wed,  6 Sep 2017 01:21:23 +0200","Message-Id":"<1504653683-11543-2-git-send-email-jschoenh@amazon.de>","X-Mailer":"git-send-email 2.3.1.dirty","In-Reply-To":"<1504653683-11543-1-git-send-email-jschoenh@amazon.de>","References":"<1504653683-11543-1-git-send-email-jschoenh@amazon.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Mailman-Approved-At":"Wed, 06 Sep 2017 09:28:43 +1000","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Cc":"linux-pci@vger.kernel.org, =?utf-8?q?Jan_H=2E_Sch=C3=B6nherr?=\n\t<jschoenh@amazon.de>,  linuxppc-dev@lists.ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"},"content":"The last caller of __pci_reset_function() has been removed. Remove\nthe function as well.\n\nSigned-off-by: Jan H. Schönherr <jschoenh@amazon.de>\n---\n drivers/pci/pci.c   | 35 +++--------------------------------\n include/linux/pci.h |  1 -\n 2 files changed, 3 insertions(+), 33 deletions(-)","diff":"diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c\nindex fdf65a6..dabcf5a 100644\n--- a/drivers/pci/pci.c\n+++ b/drivers/pci/pci.c\n@@ -4115,35 +4115,6 @@ static void pci_dev_restore(struct pci_dev *dev)\n }\n \n /**\n- * __pci_reset_function - reset a PCI device function\n- * @dev: PCI device to reset\n- *\n- * Some devices allow an individual function to be reset without affecting\n- * other functions in the same device.  The PCI device must be responsive\n- * to PCI config space in order to use this function.\n- *\n- * The device function is presumed to be unused when this function is called.\n- * Resetting the device will make the contents of PCI configuration space\n- * random, so any caller of this must be prepared to reinitialise the\n- * device including MSI, bus mastering, BARs, decoding IO and memory spaces,\n- * etc.\n- *\n- * Returns 0 if the device function was successfully reset or negative if the\n- * device doesn't support resetting a single function.\n- */\n-int __pci_reset_function(struct pci_dev *dev)\n-{\n-\tint ret;\n-\n-\tpci_dev_lock(dev);\n-\tret = __pci_reset_function_locked(dev);\n-\tpci_dev_unlock(dev);\n-\n-\treturn ret;\n-}\n-EXPORT_SYMBOL_GPL(__pci_reset_function);\n-\n-/**\n  * __pci_reset_function_locked - reset a PCI device function while holding\n  * the @dev mutex lock.\n  * @dev: PCI device to reset\n@@ -4233,8 +4204,8 @@ int pci_probe_reset_function(struct pci_dev *dev)\n  *\n  * This function does not just reset the PCI portion of a device, but\n  * clears all the state associated with the device.  This function differs\n- * from __pci_reset_function in that it saves and restores device state\n- * over the reset.\n+ * from __pci_reset_function_locked() in that it saves and restores device state\n+ * over the reset and takes the PCI device lock.\n  *\n  * Returns 0 if the device function was successfully reset or negative if the\n  * device doesn't support resetting a single function.\n@@ -4269,7 +4240,7 @@ EXPORT_SYMBOL_GPL(pci_reset_function);\n  *\n  * This function does not just reset the PCI portion of a device, but\n  * clears all the state associated with the device.  This function differs\n- * from __pci_reset_function() in that it saves and restores device state\n+ * from __pci_reset_function_locked() in that it saves and restores device state\n  * over the reset.  It also differs from pci_reset_function() in that it\n  * requires the PCI device lock to be held.\n  *\ndiff --git a/include/linux/pci.h b/include/linux/pci.h\nindex 4acf321..b55e0cf 100644\n--- a/include/linux/pci.h\n+++ b/include/linux/pci.h\n@@ -1066,7 +1066,6 @@ int pcie_set_mps(struct pci_dev *dev, int mps);\n int pcie_get_minimum_link(struct pci_dev *dev, enum pci_bus_speed *speed,\n \t\t\t  enum pcie_link_width *width);\n void pcie_flr(struct pci_dev *dev);\n-int __pci_reset_function(struct pci_dev *dev);\n int __pci_reset_function_locked(struct pci_dev *dev);\n int pci_reset_function(struct pci_dev *dev);\n int pci_reset_function_locked(struct pci_dev *dev);\n","prefixes":["2/2"]}