{"id":810235,"url":"http://patchwork.ozlabs.org/api/1.2/patches/810235/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170905180602.28698-1-f4bug@amsat.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170905180602.28698-1-f4bug@amsat.org>","list_archive_url":null,"date":"2017-09-05T18:06:02","name":"[v3] vhost-user: disable the *broken* subprocess tests","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"90dc16f53161eb7e91ba0c1822e0c4611b85cf31","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/1.2/people/70924/?format=json","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170905180602.28698-1-f4bug@amsat.org/mbox/","series":[{"id":1621,"url":"http://patchwork.ozlabs.org/api/1.2/series/1621/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1621","date":"2017-09-05T18:06:02","name":"[v3] vhost-user: disable the *broken* subprocess tests","version":3,"mbox":"http://patchwork.ozlabs.org/series/1621/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810235/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810235/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"efxzNFLj\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmvmj2cXnz9s03\n\tfor ;\n\tWed, 6 Sep 2017 04:06:44 +1000 (AEST)","from localhost ([::1]:60481 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpIFF-0005w1-JT\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 14:06:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33545)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dpIEq-0005vV-Un\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 14:06:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dpIEm-0007Pz-5H\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 14:06:16 -0400","from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:33577)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpIEm-0007Pj-0C\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 14:06:12 -0400","by mail-qt0-x241.google.com with SMTP id h15so2639841qta.0\n\tfor ; Tue, 05 Sep 2017 11:06:11 -0700 (PDT)","from yoga.offpageads.com ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\ts124sm782491qkc.8.2017.09.05.11.06.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 05 Sep 2017 11:06:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=N5j0U81rQ3sN7EMgfYC6FynumKCqT8JEeQacYZPmqmg=;\n\tb=efxzNFLjRRyjr8k4aWFOTkOODzERpq/oWBm01dLRnM3ef7DJu2wy1ETNs95vCjY7hO\n\tlNh7841hPbCifFXFQ36lvCiOnNJCkwoPEHfH8Ys9nGe+tYIDiuQBpyNXGrtG2i124fJU\n\tbOZYgH5mjoRbcPD1FAPyKNKvj8LTKLp/vB6KLEj3KkjiuSeCThclrvPjyXaXqY2ipxBr\n\t/SzgJKsSs6f0rrI0CIoyt6M30vnZdeHSb15coMP2Wfl9D+jLW/UTjZMpwhPFX0KV32C8\n\tvdBayodYH89taZOjtCvRioz570SHa8QWBNda9FhVwxcS3QokccvBY6IS2gw46KFOFJZx\n\tANyQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:mime-version:content-transfer-encoding;\n\tbh=N5j0U81rQ3sN7EMgfYC6FynumKCqT8JEeQacYZPmqmg=;\n\tb=PbLRTZfKhxFTTUL0p8N6LzrQRRVJPB6SjjybeSojsqiVi+lMAPB/eQmtBz/RSzXHiY\n\t24RikWCz89sj13OqVJDT1jW2cWnoCtNp9k0Q1qDUb0xvfVPC49pXOK2TrH9es+b22YjE\n\tRuL9OWN3Hpm2m3lhTtSHgGFIW1SGNWjQskE0RSIjLS5OYWqEvQ76KZDlYGKN6mTvHBa4\n\tedU82fPIvqAsPWtCOYVa3rdKE32meiVOdMgsOAyktioLHRl0Re9TXftSlM0ZP7aQnVU8\n\td67xfmQD1oqg9gvji4IkhsSBF/d8b8kr5gKcKNszafrYGVPrX1WYTssJVEGDhSjC0JRg\n\teiFA==","X-Gm-Message-State":"AHPjjUhZ3eMtcX1zL9XQSffXp/v8cRgR5POjgOAMmcrZCk+TG/AW1vAD\n\tTCq+EB6425QU8A==","X-Google-Smtp-Source":"ADKCNb7ESdLAqy/GXdqti9VeUQIBELvpNkVMerMiR2Tn9AG0DGmqtVur7SYII5L1NSxA5Ka78QBEMQ==","X-Received":"by 10.200.38.154 with SMTP id 26mr6391105qto.188.1504634771322; \n\tTue, 05 Sep 2017 11:06:11 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Peter Maydell ,\n\t\"Daniel P . Berrange\" ","Date":"Tue, 5 Sep 2017 15:06:02 -0300","Message-Id":"<20170905180602.28698-1-f4bug@amsat.org>","X-Mailer":"git-send-email 2.14.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::241","Subject":"[Qemu-devel] [PATCH v3] vhost-user: disable the *broken* subprocess\n\ttests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tqemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"tests/vhost-user-test keeps failing on build-system since Aug 15:\n\n ERROR:tests/vhost-user-test.c:835:test_flags_mismatch: child process (/i386/vhost-user/flags-mismatch/subprocess [4836]) failed unexpectedly\n...\n ERROR:tests/vhost-user-test.c:807:test_connect_fail: child process (/x86_64/vhost-user/connect-fail/subprocess [58910]) failed unexpectedly\n\nSuggested-by: Peter Maydell \nSuggested-by: Daniel P. Berrange \nSigned-off-by: Philippe Mathieu-Daudé \n---\nv3: only disable tests using glib subprocess,\n migrate/multiqueue/guest-mem are still tested.\n\nv2: remove unuseful warning\n\n tests/vhost-user-test.c | 17 ++++++++++-------\n 1 file changed, 10 insertions(+), 7 deletions(-)","diff":"diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c\nindex d4da09f147..4b98018478 100644\n--- a/tests/vhost-user-test.c\n+++ b/tests/vhost-user-test.c\n@@ -31,6 +31,8 @@\n #include \n #include \n \n+#define VHOST_USER_NET_TESTS_WORKING 0 /* broken as of 2.10.0 */\n+\n /* GLIB version compatibility flags */\n #if !GLIB_CHECK_VERSION(2, 26, 0)\n #define G_TIME_SPAN_SECOND (G_GINT64_CONSTANT(1000000))\n@@ -472,11 +474,6 @@ static void test_server_listen(TestServer *server)\n test_server_create_chr(server, \",server,nowait\");\n }\n \n-static inline void test_server_connect(TestServer *server)\n-{\n- test_server_create_chr(server, \",reconnect=1\");\n-}\n-\n #define GET_QEMU_CMD(s) \\\n g_strdup_printf(QEMU_CMD, 512, 512, (root), (s)->chr_name, \\\n (s)->socket_path, \"\", (s)->chr_name)\n@@ -722,7 +719,12 @@ static void wait_for_rings_started(TestServer *s, size_t count)\n g_mutex_unlock(&s->data_mutex);\n }\n \n-#ifdef CONFIG_HAS_GLIB_SUBPROCESS_TESTS\n+#if VHOST_USER_NET_TESTS_WORKING && defined(CONFIG_HAS_GLIB_SUBPROCESS_TESTS)\n+static inline void test_server_connect(TestServer *server)\n+{\n+ test_server_create_chr(server, \",reconnect=1\");\n+}\n+\n static gboolean\n reconnect_cb(gpointer user_data)\n {\n@@ -962,7 +964,8 @@ int main(int argc, char **argv)\n qtest_add_data_func(\"/vhost-user/read-guest-mem\", server, read_guest_mem);\n qtest_add_func(\"/vhost-user/migrate\", test_migrate);\n qtest_add_func(\"/vhost-user/multiqueue\", test_multiqueue);\n-#ifdef CONFIG_HAS_GLIB_SUBPROCESS_TESTS\n+\n+#if VHOST_USER_NET_TESTS_WORKING && defined(CONFIG_HAS_GLIB_SUBPROCESS_TESTS)\n qtest_add_func(\"/vhost-user/reconnect/subprocess\",\n test_reconnect_subprocess);\n qtest_add_func(\"/vhost-user/reconnect\", test_reconnect);\n","prefixes":["v3"]}