{"id":810064,"url":"http://patchwork.ozlabs.org/api/1.2/patches/810064/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/patch/20170905100327.21421-1-aleksander@aleksander.es/","project":{"id":27,"url":"http://patchwork.ozlabs.org/api/1.2/projects/27/?format=json","name":"Buildroot development","link_name":"buildroot","list_id":"buildroot.buildroot.org","list_email":"buildroot@buildroot.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170905100327.21421-1-aleksander@aleksander.es>","list_archive_url":null,"date":"2017-09-05T10:03:27","name":"libqmi: udev and qmi-over-mbim are optional","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"ed028e2ac6a04a6fdba7e72cb405f3ef91db34b3","submitter":{"id":48681,"url":"http://patchwork.ozlabs.org/api/1.2/people/48681/?format=json","name":"Aleksander Morgado","email":"aleksander@aleksander.es"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/buildroot/patch/20170905100327.21421-1-aleksander@aleksander.es/mbox/","series":[{"id":1540,"url":"http://patchwork.ozlabs.org/api/1.2/series/1540/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/list/?series=1540","date":"2017-09-05T10:03:27","name":"libqmi: udev and qmi-over-mbim are optional","version":1,"mbox":"http://patchwork.ozlabs.org/series/1540/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/810064/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/810064/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aleksander-es.20150623.gappssmtp.com\n\theader.i=@aleksander-es.20150623.gappssmtp.com\n\theader.b=\"FzeWzKqw\"; dkim-atps=neutral"],"Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmj3T32R9z9sNq\n\tfor ;\n\tTue, 5 Sep 2017 20:03:49 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8A46485B58;\n\tTue, 5 Sep 2017 10:03:46 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YatAiG30M0yd; Tue, 5 Sep 2017 10:03:44 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C119E85B2F;\n\tTue, 5 Sep 2017 10:03:44 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8F06C1C1650\n\tfor ;\n\tTue, 5 Sep 2017 10:03:43 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8784986CF0\n\tfor ;\n\tTue, 5 Sep 2017 10:03:43 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id oUpL-9RHVnLr for ;\n\tTue, 5 Sep 2017 10:03:42 +0000 (UTC)","from mail-wr0-f193.google.com (mail-wr0-f193.google.com\n\t[209.85.128.193])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id C2E8D86CE8\n\tfor ; Tue, 5 Sep 2017 10:03:41 +0000 (UTC)","by mail-wr0-f193.google.com with SMTP id b9so1470959wra.0\n\tfor ; Tue, 05 Sep 2017 03:03:41 -0700 (PDT)","from localhost.localdomain\n\t(116.red-83-40-186.dynamicip.rima-tde.net. [83.40.186.116])\n\tby smtp.gmail.com with ESMTPSA id\n\ty99sm327942wmh.1.2017.09.05.03.03.38\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 05 Sep 2017 03:03:39 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=aleksander-es.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=EUnOUY7oc0ZZzRu//EjK/WFvkpCc2GcTHF9p2tsAvTQ=;\n\tb=FzeWzKqw+DqBJGsOfbjbZU24EDsXhERYWYVGgTs6y4XAIlV9vSb97pj4nwd0/1t48E\n\t7rbfjaf56WzDlFkLJ9cF8O5HoxS2+WXsKhOnrzsusQdtTEu0K/0B/sqpXLuxF6Gyuv3K\n\tmEHIHUQNjG8Yd0SJwNDDzjd2Cin3bbX71x95Uznszp9SSFGuOSFR4WIoQGrIjNBwnWzc\n\tPE6B4mjCIPIMgiFkdROH8vgfBYT83v6vTch1ZrRRi8tvSt+e6RsJak1X2Dx0ilMD7Z9T\n\tnf6+Ahs84NbzV86l30PdTcQf1YDK5EH/2rIs/R70iCfsHjCIFzWgvqhzC4di59538yIm\n\tA2vg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=EUnOUY7oc0ZZzRu//EjK/WFvkpCc2GcTHF9p2tsAvTQ=;\n\tb=UdMmexJndBtHpRtW2gevSPonQVkYxyBvP3us7IFfgpN6Zm6lvspyHx7+YX9mx4b3/y\n\tKoZ3MdKFH+3ctN/++MRRaRsvnn6ImUqslpzPCsEjHBPjFiz4Z0DMfcqHghOMfUY5EHv0\n\ttbsC3lOV9/T+ehOBPINHNkABWdAx3RqhVQITjaJsAvw7vukEPltDiUKXNqt1/TNVFVfl\n\tFxW2zsJ989b35alRcVrA7yqkqnMXaE1Rll4FgYH55CYoIQNYO9sMrB6vMNStPDjSp7Zk\n\tsfnyLrXuqPocL4CtPsxLg7TH5ubwHEqap0Alk15/d5HZDDuuBcy52Oe0EQE65d9MfQCJ\n\tsFTA==","X-Gm-Message-State":"AHPjjUjy4uAO1wsbXwWAIJni4exAe4dc5A25oR0Wn+Nr0UACr/Q2ymAW\n\tbBpyHvdjJcMRq2efFSMEEA==","X-Google-Smtp-Source":"ADKCNb61Si1wWYDuz+m0L+8D1ktfVAUPk5rNvkh4vcpExAOMlsTsqnip/YV2O6Y0HaiwMP/AcdWmQg==","X-Received":"by 10.223.149.35 with SMTP id 32mr2217170wrs.289.1504605819923; \n\tTue, 05 Sep 2017 03:03:39 -0700 (PDT)","From":"Aleksander Morgado ","To":"buildroot@buildroot.org","Date":"Tue, 5 Sep 2017 12:03:27 +0200","Message-Id":"<20170905100327.21421-1-aleksander@aleksander.es>","X-Mailer":"git-send-email 2.13.1","Cc":"thomas.petazzoni@free-electrons.com,\n\tAleksander Morgado ","Subject":"[Buildroot] [PATCH] libqmi: udev and qmi-over-mbim are optional","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "},"content":"Don't always build without udev, as qmi-firmware-update would be very\nvery limited in that case. Instead, make it optional: if there is udev\nsupport in the setup, require libgudev and configure using --with-udev\nexplicitly; otherwise just --without-udev.\n\nAlso, add the qmi-over-mbim feature as optional, and require libmbim\nif we're building with it enabled.\n\nSigned-off-by: Aleksander Morgado \n---\n package/libqmi/Config.in | 18 ++++++++++++++++++\n package/libqmi/libqmi.mk | 18 ++++++++++++++++--\n 2 files changed, 34 insertions(+), 2 deletions(-)","diff":"diff --git a/package/libqmi/Config.in b/package/libqmi/Config.in\nindex f1d111b7c..a536650b5 100644\n--- a/package/libqmi/Config.in\n+++ b/package/libqmi/Config.in\n@@ -10,6 +10,24 @@ config BR2_PACKAGE_LIBQMI\n \n \t http://www.freedesktop.org/wiki/Software/libqmi/\n \n+if BR2_PACKAGE_LIBQMI\n+\n+config BR2_PACKAGE_LIBQMI_UDEV\n+\tbool \"qmi-firmware-update udev support\"\n+\tdepends on BR2_PACKAGE_HAS_UDEV\n+\tselect BR2_PACKAGE_LIBGUDEV\n+\thelp\n+\t This option enables udev support in the qmi-firmware-update tool\n+\n+config BR2_PACKAGE_LIBQMI_MBIM_QMUX\n+\tbool \"QMI-over-MBIM support\"\n+\tselect BR2_PACKAGE_LIBMBIM\n+\thelp\n+\t This option enables support to use the QMI protocol over MBIM\n+\t for modems with MBIM_SERVICE_QMI capabilities\n+\n+endif\n+\n comment \"libqmi needs a toolchain w/ wchar, threads\"\n \tdepends on BR2_USE_MMU\n \tdepends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS\ndiff --git a/package/libqmi/libqmi.mk b/package/libqmi/libqmi.mk\nindex 917265f4b..129fd0fb6 100644\n--- a/package/libqmi/libqmi.mk\n+++ b/package/libqmi/libqmi.mk\n@@ -15,7 +15,21 @@ LIBQMI_AUTORECONF = YES\n \n LIBQMI_DEPENDENCIES = libglib2\n \n-# we don't want -Werror and disable gudev Gobject bindings\n-LIBQMI_CONF_OPTS = --enable-more-warnings=no --without-udev\n+# we don't want -Werror\n+LIBQMI_CONF_OPTS = --enable-more-warnings=no\n+\n+ifeq ($(BR2_PACKAGE_LIBQMI_UDEV),y)\n+LIBQMI_DEPENDENCIES += libgudev\n+LIBQMI_CONF_OPTS += --with-udev\n+else\n+LIBQMI_CONF_OPTS += --without-udev\n+endif\n+\n+ifeq ($(BR2_PACKAGE_LIBQMI_MBIM_QMUX),y)\n+LIBQMI_DEPENDENCIES += libmbim\n+LIBQMI_CONF_OPTS += --enable-mbim-qmux\n+else\n+LIBQMI_CONF_OPTS += --disable-mbim-qmux\n+endif\n \n $(eval $(autotools-package))\n","prefixes":[]}