{"id":809881,"url":"http://patchwork.ozlabs.org/api/1.2/patches/809881/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1504573407-26293-1-git-send-email-vpai@akamai.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504573407-26293-1-git-send-email-vpai@akamai.com>","list_archive_url":null,"date":"2017-09-05T01:03:27","name":"netfilter: xt_hashlimit: fix 64 bit division compile error","commit_ref":null,"pull_url":null,"state":"awaiting-upstream","archived":true,"hash":"82a107248088515fb6e25c048e622bcfdfd03d84","submitter":{"id":66296,"url":"http://patchwork.ozlabs.org/api/1.2/people/66296/?format=json","name":"Vishwanath Pai","email":"vpai@akamai.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1504573407-26293-1-git-send-email-vpai@akamai.com/mbox/","series":[{"id":1472,"url":"http://patchwork.ozlabs.org/api/1.2/series/1472/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=1472","date":"2017-09-05T01:03:27","name":"netfilter: xt_hashlimit: fix 64 bit division compile error","version":1,"mbox":"http://patchwork.ozlabs.org/series/1472/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809881/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809881/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tsecure) header.d=akamai.com header.i=@akamai.com header.b=\"UDlW0yda\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmT4c0fHqz9s3T\n\tfor ;\n\tTue, 5 Sep 2017 11:04:00 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754094AbdIEBD5 (ORCPT );\n\tMon, 4 Sep 2017 21:03:57 -0400","from mx0a-00190b01.pphosted.com ([67.231.149.131]:50724 \"EHLO\n\tmx0a-00190b01.pphosted.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751155AbdIEBDy (ORCPT\n\t); Mon, 4 Sep 2017 21:03:54 -0400","from pps.filterd (m0122333.ppops.net [127.0.0.1])\n\tby mx0a-00190b01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv85131jI025935; Tue, 5 Sep 2017 02:03:29 +0100","from prod-mail-ppoint3 ([96.6.114.86])\n\tby mx0a-00190b01.pphosted.com with ESMTP id 2cqkw4ndpg-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Tue, 05 Sep 2017 02:03:29 +0100","from pps.filterd (prod-mail-ppoint3.akamai.com [127.0.0.1])\n\tby prod-mail-ppoint3.akamai.com (8.16.0.17/8.16.0.17) with SMTP id\n\tv8510qlf003358; Mon, 4 Sep 2017 21:03:28 -0400","from prod-mail-relay14.akamai.com ([172.27.17.39])\n\tby prod-mail-ppoint3.akamai.com with ESMTP id 2cqqyv9j54-1;\n\tMon, 04 Sep 2017 21:03:28 -0400","from bos-lpqrs.kendall.corp.akamai.com\n\t(bos-lpqrs.kendall.corp.akamai.com [172.28.13.81])\n\tby prod-mail-relay14.akamai.com (Postfix) with ESMTP id 1FF3080059;\n\tMon, 4 Sep 2017 19:03:28 -0600 (MDT)","from vpai by bos-lpqrs.kendall.corp.akamai.com with local (Exim\n\t4.82) (envelope-from )\n\tid 1dp2H1-0006qe-LD; Mon, 04 Sep 2017 21:03:27 -0400"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com;\n\th=from : to : cc :\n\tsubject : date : message-id; s=jan2016.eng;\n\tbh=l9K87dhWHpAB+XBNZFodOo2WGR1RmSrez/hpI8qxVLE=;\n\tb=UDlW0ydabtIpxPVzVdmKbdqXfabureN20OkSW/3nq6xigf40EkhYnL3umEDVdqNlTugp\n\tkHyDCyXp0eD/T0Rds+aI7IBl9dLgiuU+iS0Hl+Ab/bz+oi09m6HThgvjABTsSHDv067F\n\ti8zsx3slTavFzawDVcuwc0GzAhZd1MhuGc8R/K3vAn5gneZwnisgFzDAI+cSx/R56OOn\n\tHoubiQPPN5c8yZLXgtxLqSHWcZLFZt/8yGZW9Qsu2OixN95ftf084ptivWuujOn9a9FR\n\tabs4S7K5Z5C/erSv41ozZ1dTC94fCaR5PTwHCwN8EKxBAALoD5+0HJrUCzhkOPghh3z6\n\t6A== ","From":"Vishwanath Pai ","To":"pablo@netfilter.org, kadlec@blackhole.kfki.hu,\n\tnetfilter-devel@vger.kernel.org","Cc":"johunt@akamai.com, fw@strlen.de, netdev@vger.kernel.org,\n\tpai.vishwain@gmail.com","Subject":"[PATCH] netfilter: xt_hashlimit: fix 64 bit division compile error","Date":"Mon, 4 Sep 2017 21:03:27 -0400","Message-Id":"<1504573407-26293-1-git-send-email-vpai@akamai.com>","X-Mailer":"git-send-email 1.9.1","X-Proofpoint-Virus-Version":["vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-04_13:, , signatures=0","vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-04_13:, , signatures=0"],"X-Proofpoint-Spam-Details":["rule=notspam policy=default score=0 spamscore=0\n\tsuspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709050014","rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0\n\tsuspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011\n\tlowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam\n\tadjust=0\n\treason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709050015"],"Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"commit bea74641e378 (\"netfilter: xt_hashlimit: add rate match mode\")\nintroduced a line where we divide two 64bit unsigned integers. This\nbreaks on ARM processors with the error:\n\nERROR: \"__aeabi_uldivmod\" [net/netfilter/xt_hashlimit.ko] undefined!\n\nWe can fix it by using div64_u64 instead.\n\nFixes: bea74641e378 (\"netfilter: xt_hashlimit: add rate match mode\")\nSigned-off-by: Vishwanath Pai \n---\n net/netfilter/xt_hashlimit.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/net/netfilter/xt_hashlimit.c b/net/netfilter/xt_hashlimit.c\nindex 10d4823..fece7c2 100644\n--- a/net/netfilter/xt_hashlimit.c\n+++ b/net/netfilter/xt_hashlimit.c\n@@ -531,7 +531,7 @@ static u64 user2rate_bytes(u64 user)\n {\n \tu64 r;\n \n-\tr = user ? 0xFFFFFFFFULL / user : 0xFFFFFFFFULL;\n+\tr = user ? div64_u64(0xFFFFFFFFULL, user) : 0xFFFFFFFFULL;\n \tr = (r - 1) << 4;\n \treturn r;\n }\n","prefixes":[]}