{"id":809808,"url":"http://patchwork.ozlabs.org/api/1.2/patches/809808/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1504555874-4168-6-git-send-email-pablo@netfilter.org/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504555874-4168-6-git-send-email-pablo@netfilter.org>","list_archive_url":null,"date":"2017-09-04T20:11:07","name":"[05/12] netfilter: remove unused hooknum arg from packet functions","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"d98a468afae668ef3b01625409b2c504ef36aca5","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/1.2/people/1315/?format=json","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1504555874-4168-6-git-send-email-pablo@netfilter.org/mbox/","series":[{"id":1451,"url":"http://patchwork.ozlabs.org/api/1.2/series/1451/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=1451","date":"2017-09-04T20:11:02","name":"[01/12] netfilter: xt_hashlimit: add rate match mode","version":1,"mbox":"http://patchwork.ozlabs.org/series/1451/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809808/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809808/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmLbm3jk5z9t2R\n\tfor ;\n\tTue, 5 Sep 2017 06:12:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932083AbdIDUMB (ORCPT );\n\tMon, 4 Sep 2017 16:12:01 -0400","from mail.us.es ([193.147.175.20]:42178 \"EHLO mail.us.es\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1754687AbdIDULb (ORCPT );\n\tMon, 4 Sep 2017 16:11:31 -0400","from antivirus1-rhel7.int (unknown [192.168.2.11])\n\tby mail.us.es (Postfix) with ESMTP id 64BEC532F88\n\tfor ; Mon, 4 Sep 2017 22:11:03 +0200 (CEST)","from antivirus1-rhel7.int (localhost [127.0.0.1])\n\tby antivirus1-rhel7.int (Postfix) with ESMTP id 5199FB5041\n\tfor ; Mon, 4 Sep 2017 22:11:03 +0200 (CEST)","by antivirus1-rhel7.int (Postfix, from userid 99)\n\tid 473DFB502E; Mon, 4 Sep 2017 22:11:03 +0200 (CEST)","from antivirus1-rhel7.int (localhost [127.0.0.1])\n\tby antivirus1-rhel7.int (Postfix) with ESMTP id EFFFC8E52A;\n\tMon, 4 Sep 2017 22:10:58 +0200 (CEST)","from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int\n\t(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); \n\tMon, 04 Sep 2017 22:10:58 +0200 (CEST)","from salvia.here (129.166.216.87.static.jazztel.es\n\t[87.216.166.129]) (Authenticated sender: pneira@us.es)\n\tby entrada.int (Postfix) with ESMTPA id 9564F4265A22;\n\tMon, 4 Sep 2017 22:10:58 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.1 (2015-04-28) on\n\tantivirus1-rhel7.int","X-Spam-Level":"","X-Spam-Status":"No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50,\n\tSMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1","X-Virus-Status":"clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int)","X-SMTPAUTHUS":"auth mail.us.es","From":"Pablo Neira Ayuso ","To":"netfilter-devel@vger.kernel.org","Cc":"davem@davemloft.net, netdev@vger.kernel.org","Subject":"[PATCH 05/12] netfilter: remove unused hooknum arg from packet\n\tfunctions","Date":"Mon, 4 Sep 2017 22:11:07 +0200","Message-Id":"<1504555874-4168-6-git-send-email-pablo@netfilter.org>","X-Mailer":"git-send-email 2.1.4","In-Reply-To":"<1504555874-4168-1-git-send-email-pablo@netfilter.org>","References":"<1504555874-4168-1-git-send-email-pablo@netfilter.org>","X-Virus-Scanned":"ClamAV using ClamSMTP","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Florian Westphal \n\ntested with allmodconfig build.\n\nSigned-off-by: Florian Westphal \n---\n include/net/netfilter/nf_conntrack_l4proto.h | 1 -\n net/ipv4/netfilter/nf_conntrack_proto_icmp.c | 1 -\n net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c | 6 ++----\n net/netfilter/nf_conntrack_core.c | 2 +-\n net/netfilter/nf_conntrack_proto_dccp.c | 2 +-\n net/netfilter/nf_conntrack_proto_generic.c | 1 -\n net/netfilter/nf_conntrack_proto_gre.c | 1 -\n net/netfilter/nf_conntrack_proto_sctp.c | 1 -\n net/netfilter/nf_conntrack_proto_tcp.c | 1 -\n net/netfilter/nf_conntrack_proto_udp.c | 1 -\n 10 files changed, 4 insertions(+), 13 deletions(-)","diff":"diff --git a/include/net/netfilter/nf_conntrack_l4proto.h b/include/net/netfilter/nf_conntrack_l4proto.h\nindex d4933d56809d..738a0307a96b 100644\n--- a/include/net/netfilter/nf_conntrack_l4proto.h\n+++ b/include/net/netfilter/nf_conntrack_l4proto.h\n@@ -43,7 +43,6 @@ struct nf_conntrack_l4proto {\n \t\t unsigned int dataoff,\n \t\t enum ip_conntrack_info ctinfo,\n \t\t u_int8_t pf,\n-\t\t unsigned int hooknum,\n \t\t unsigned int *timeouts);\n \n \t/* Called when a new connection for this protocol found;\ndiff --git a/net/ipv4/netfilter/nf_conntrack_proto_icmp.c b/net/ipv4/netfilter/nf_conntrack_proto_icmp.c\nindex 434b4e20f6db..ce108a996316 100644\n--- a/net/ipv4/netfilter/nf_conntrack_proto_icmp.c\n+++ b/net/ipv4/netfilter/nf_conntrack_proto_icmp.c\n@@ -82,7 +82,6 @@ static int icmp_packet(struct nf_conn *ct,\n \t\t unsigned int dataoff,\n \t\t enum ip_conntrack_info ctinfo,\n \t\t u_int8_t pf,\n-\t\t unsigned int hooknum,\n \t\t unsigned int *timeout)\n {\n \t/* Do not immediately delete the connection after the first\ndiff --git a/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c b/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c\nindex 43544b975eae..30e34c4de003 100644\n--- a/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c\n+++ b/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c\n@@ -95,7 +95,6 @@ static int icmpv6_packet(struct nf_conn *ct,\n \t\t unsigned int dataoff,\n \t\t enum ip_conntrack_info ctinfo,\n \t\t u_int8_t pf,\n-\t\t unsigned int hooknum,\n \t\t unsigned int *timeout)\n {\n \t/* Do not immediately delete the connection after the first\n@@ -129,8 +128,7 @@ static bool icmpv6_new(struct nf_conn *ct, const struct sk_buff *skb,\n static int\n icmpv6_error_message(struct net *net, struct nf_conn *tmpl,\n \t\t struct sk_buff *skb,\n-\t\t unsigned int icmp6off,\n-\t\t unsigned int hooknum)\n+\t\t unsigned int icmp6off)\n {\n \tstruct nf_conntrack_tuple intuple, origtuple;\n \tconst struct nf_conntrack_tuple_hash *h;\n@@ -214,7 +212,7 @@ icmpv6_error(struct net *net, struct nf_conn *tmpl,\n \tif (icmp6h->icmp6_type >= 128)\n \t\treturn NF_ACCEPT;\n \n-\treturn icmpv6_error_message(net, tmpl, skb, dataoff, hooknum);\n+\treturn icmpv6_error_message(net, tmpl, skb, dataoff);\n }\n \n #if IS_ENABLED(CONFIG_NF_CT_NETLINK)\ndiff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c\nindex c23df7c9cd59..ee5555dd7ebc 100644\n--- a/net/netfilter/nf_conntrack_core.c\n+++ b/net/netfilter/nf_conntrack_core.c\n@@ -1414,7 +1414,7 @@ nf_conntrack_in(struct net *net, u_int8_t pf, unsigned int hooknum,\n \t/* Decide what timeout policy we want to apply to this flow. */\n \ttimeouts = nf_ct_timeout_lookup(net, ct, l4proto);\n \n-\tret = l4proto->packet(ct, skb, dataoff, ctinfo, pf, hooknum, timeouts);\n+\tret = l4proto->packet(ct, skb, dataoff, ctinfo, pf, timeouts);\n \tif (ret <= 0) {\n \t\t/* Invalid: inverse of the return code tells\n \t\t * the netfilter core what to do */\ndiff --git a/net/netfilter/nf_conntrack_proto_dccp.c b/net/netfilter/nf_conntrack_proto_dccp.c\nindex 188347571fc7..0f5a4d79f6b8 100644\n--- a/net/netfilter/nf_conntrack_proto_dccp.c\n+++ b/net/netfilter/nf_conntrack_proto_dccp.c\n@@ -469,7 +469,7 @@ static unsigned int *dccp_get_timeouts(struct net *net)\n \n static int dccp_packet(struct nf_conn *ct, const struct sk_buff *skb,\n \t\t unsigned int dataoff, enum ip_conntrack_info ctinfo,\n-\t\t u_int8_t pf, unsigned int hooknum,\n+\t\t u_int8_t pf,\n \t\t unsigned int *timeouts)\n {\n \tstruct net *net = nf_ct_net(ct);\ndiff --git a/net/netfilter/nf_conntrack_proto_generic.c b/net/netfilter/nf_conntrack_proto_generic.c\nindex 2993995b690d..9cd40700842e 100644\n--- a/net/netfilter/nf_conntrack_proto_generic.c\n+++ b/net/netfilter/nf_conntrack_proto_generic.c\n@@ -61,7 +61,6 @@ static int generic_packet(struct nf_conn *ct,\n \t\t\t unsigned int dataoff,\n \t\t\t enum ip_conntrack_info ctinfo,\n \t\t\t u_int8_t pf,\n-\t\t\t unsigned int hooknum,\n \t\t\t unsigned int *timeout)\n {\n \tnf_ct_refresh_acct(ct, ctinfo, skb, *timeout);\ndiff --git a/net/netfilter/nf_conntrack_proto_gre.c b/net/netfilter/nf_conntrack_proto_gre.c\nindex c0e3a23ac23a..09a90484c27d 100644\n--- a/net/netfilter/nf_conntrack_proto_gre.c\n+++ b/net/netfilter/nf_conntrack_proto_gre.c\n@@ -245,7 +245,6 @@ static int gre_packet(struct nf_conn *ct,\n \t\t unsigned int dataoff,\n \t\t enum ip_conntrack_info ctinfo,\n \t\t u_int8_t pf,\n-\t\t unsigned int hooknum,\n \t\t unsigned int *timeouts)\n {\n \t/* If we've seen traffic both ways, this is a GRE connection.\ndiff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c\nindex 890b5c73368d..6303a88af12b 100644\n--- a/net/netfilter/nf_conntrack_proto_sctp.c\n+++ b/net/netfilter/nf_conntrack_proto_sctp.c\n@@ -307,7 +307,6 @@ static int sctp_packet(struct nf_conn *ct,\n \t\t unsigned int dataoff,\n \t\t enum ip_conntrack_info ctinfo,\n \t\t u_int8_t pf,\n-\t\t unsigned int hooknum,\n \t\t unsigned int *timeouts)\n {\n \tenum sctp_conntrack new_state, old_state;\ndiff --git a/net/netfilter/nf_conntrack_proto_tcp.c b/net/netfilter/nf_conntrack_proto_tcp.c\nindex 33c52d9ab2f5..cba1c6ffe51a 100644\n--- a/net/netfilter/nf_conntrack_proto_tcp.c\n+++ b/net/netfilter/nf_conntrack_proto_tcp.c\n@@ -803,7 +803,6 @@ static int tcp_packet(struct nf_conn *ct,\n \t\t unsigned int dataoff,\n \t\t enum ip_conntrack_info ctinfo,\n \t\t u_int8_t pf,\n-\t\t unsigned int hooknum,\n \t\t unsigned int *timeouts)\n {\n \tstruct net *net = nf_ct_net(ct);\ndiff --git a/net/netfilter/nf_conntrack_proto_udp.c b/net/netfilter/nf_conntrack_proto_udp.c\nindex dcf3030d2226..8af734cd1a94 100644\n--- a/net/netfilter/nf_conntrack_proto_udp.c\n+++ b/net/netfilter/nf_conntrack_proto_udp.c\n@@ -74,7 +74,6 @@ static int udp_packet(struct nf_conn *ct,\n \t\t unsigned int dataoff,\n \t\t enum ip_conntrack_info ctinfo,\n \t\t u_int8_t pf,\n-\t\t unsigned int hooknum,\n \t\t unsigned int *timeouts)\n {\n \t/* If we've seen traffic both ways, this is some kind of UDP\n","prefixes":["05/12"]}