{"id":809350,"url":"http://patchwork.ozlabs.org/api/1.2/patches/809350/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/patch/20170903183546.16749-1-rosenp@gmail.com/","project":{"id":54,"url":"http://patchwork.ozlabs.org/api/1.2/projects/54/?format=json","name":"LEDE development","link_name":"lede","list_id":"lede-dev.lists.infradead.org","list_email":"lede-dev@lists.infradead.org","web_url":"http://lede-project.org/","scm_url":"","webscm_url":"http://git.lede-project.org/","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170903183546.16749-1-rosenp@gmail.com>","list_archive_url":null,"date":"2017-09-03T18:35:46","name":"[LEDE-DEV] ar71xx: Add GRO support to ag71xx","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c2371a112fdbd4898a0efb602ded2f259860ffaf","submitter":{"id":70304,"url":"http://patchwork.ozlabs.org/api/1.2/people/70304/?format=json","name":"Rosen Penev","email":"rosenp@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/lede/patch/20170903183546.16749-1-rosenp@gmail.com/mbox/","series":[{"id":1269,"url":"http://patchwork.ozlabs.org/api/1.2/series/1269/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/list/?series=1269","date":"2017-09-03T18:35:46","name":"[LEDE-DEV] ar71xx: Add GRO support to ag71xx","version":1,"mbox":"http://patchwork.ozlabs.org/series/1269/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809350/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809350/checks/","tags":{},"related":[],"headers":{"Return-Path":"<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"jcYP0OHU\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"UOLaZjsm\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlhWr3RJ8z9sPs\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon,  4 Sep 2017 04:36:24 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1doZkl-0007uR-1u; Sun, 03 Sep 2017 18:36:15 +0000","from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1doZkh-0007tc-Vk\n\tfor lede-dev@lists.infradead.org; Sun, 03 Sep 2017 18:36:13 +0000","by mail-pg0-x244.google.com with SMTP id 83so3190542pgb.3\n\tfor <lede-dev@lists.infradead.org>;\n\tSun, 03 Sep 2017 11:35:50 -0700 (PDT)","from mangix.lan ([2001:470:1f05:c3e::8ce])\n\tby smtp.gmail.com with ESMTPSA id\n\td12sm8206625pgn.53.2017.09.03.11.35.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 03 Sep 2017 11:35:49 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:\n\tDate:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=aZe1qBr7hPpb2WW1TXAeon8m++npM92dyZW8nH1XZYY=;\n\tb=jcYP0OHUnVWu8T\n\tpIlR92rVBDQfAOkoI753X5r13F74Zkx22E+8+2nHt/kb/3HK9Ic4iu/7KJw8vRdMf5UeCKmPwHmOk\n\tOO64k8zi7CetJFsmS+Q7i7wLaMG/JFfFswIUy/sel7nBzIs1ezVbFYxnyv53NtTkK+IqfPidQQ8m1\n\t7/3zgxOEMEm8zMa35K170vK6jBJWUG3TyEd2GhhZnNH1ufpWclkP6GmbRSgjZiberD09vfeBYx9AU\n\t/Q+trlccd4pbLMJXFJQuAfqSj5v31u/z1FmegSiF7bWt64beDlNrL0h7D+cwPHZLa4B2BlmXHY4Ob\n\tFtfWY95KUVqWrtg5rX6w==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=tQDaXQ2lyAWEwZoj66VAAGzCGJjm5Ef6lS4GuYKJQoo=;\n\tb=UOLaZjsmKxsdkFG7NGqy4rF+gcGxYtNpemEEUZFy4cXDRNKzqhGez8A0n9AunKr7H7\n\teLWzLWiY1XcjGtZElAddqCitRUV9AN2aNmlgeNl0sIF09y0y+NYCjW+AR+LNrXzHCY6B\n\t2nzvxoeB5Y9UhQGnYdvOk6MOKnqZzAZiaAXO6W0c+dvKrLY4oBf8SBroOgdeBlhrSH1l\n\tPXetYAG/haPS9eJmKmMgb3ePCoyExg+MIa/Io2+9WAjcnDD1ZXzjvJ8WzEzBbCC45x3P\n\t3SIUNtESQsrLloqTqmLhoAAMBCd84TSKHnWSTew6FwVrfYg1Xemt/T6PRy5S2cnw4ZEx\n\tm+ag=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=tQDaXQ2lyAWEwZoj66VAAGzCGJjm5Ef6lS4GuYKJQoo=;\n\tb=Vi6telCz/aDWOpbn5Va/iYeoMvik5cyFYu0SOitjrzQHTiswmNBr170TNHHPiZ2+9E\n\tw7Capac3oP/V57M3cfFCXFQ2Zx04tsyAVfIJr22gMtMBW5T91Sa7q3e0DfuAJD/AYcOj\n\t8oGOGJSMGuycIy3w/womw57aD/ilrY+vTMKbVs/1qLClmcf6DSOZoAaqg0bDLQoWJlQj\n\t4Mq53LvOr600LyPYFPf8qtdBdYW+oMVXe94piOBJABE0x7s34D+9nMqPQ77hC2WnsvyQ\n\tAk2Io9yR9NRc9mwEOwTy8J1FfGRwcfiZ49e7drTXwaS/8sGadHD1eN5o8gWW0OO7k3ih\n\thWKw==","X-Gm-Message-State":"AHPjjUjiK+VVTFdG4QmoXAXmJWt4ChqGU/uK1RtCBPjAfiatkmf68lIu\n\tfr/NvKWEu7dKewC4SUk=","X-Google-Smtp-Source":"ADKCNb765vjfvojU0ZaBLimCtbZR6wNgdeW+yZRmHiYus6o0LbYCfLSYbZ8FfT0629kCqLWksOusSA==","X-Received":"by 10.84.197.69 with SMTP id m63mr5476690pld.345.1504463750407; \n\tSun, 03 Sep 2017 11:35:50 -0700 (PDT)","From":"Rosen Penev <rosenp@gmail.com>","To":"lede-dev@lists.infradead.org","Date":"Sun,  3 Sep 2017 11:35:46 -0700","Message-Id":"<20170903183546.16749-1-rosenp@gmail.com>","X-Mailer":"git-send-email 2.13.5","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170903_113612_078730_71314C0D ","X-CRM114-Status":"UNSURE (   8.16  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c05:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (rosenp[at]gmail.com)\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"[LEDE-DEV] [PATCH] ar71xx: Add GRO support to ag71xx","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<lede-dev.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/lede-dev/>","List-Post":"<mailto:lede-dev@lists.infradead.org>","List-Help":"<mailto:lede-dev-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>","Cc":"Rosen Penev <rosenp@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"On a TL-WN710N, this patch increases iperf performance from ~92.5 to ~93.5 mbps. Keep in mind the WN710N is a 100mbps device. I expect greater numbers from gigabit devices.\n\nSigned-off-by: Rosen Penev <rosenp@gmail.com>\n---\n .../ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c  | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c\nindex 566e9513d8..ae1bdf6066 100644\n--- a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c\n+++ b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c\n@@ -1089,7 +1089,7 @@ next:\n \n \twhile ((skb = __skb_dequeue(&queue)) != NULL) {\n \t\tskb->protocol = eth_type_trans(skb, dev);\n-\t\tnetif_receive_skb(skb);\n+\t\tnapi_gro_receive(&ag->napi, skb);\n \t}\n \n \tDBG(\"%s: rx finish, curr=%u, dirty=%u, done=%d\\n\",\n@@ -1141,7 +1141,7 @@ static int ag71xx_poll(struct napi_struct *napi, int limit)\n \t\tDBG(\"%s: disable polling mode, rx=%d, tx=%d,limit=%d\\n\",\n \t\t\tdev->name, rx_done, tx_done, limit);\n \n-\t\tnapi_complete(napi);\n+\t\tnapi_complete_done(napi, rx_done);\n \n \t\t/* enable interrupts */\n \t\tspin_lock_irqsave(&ag->lock, flags);\n@@ -1160,7 +1160,7 @@ oom:\n \t\tpr_info(\"%s: out of memory\\n\", dev->name);\n \n \tmod_timer(&ag->oom_timer, jiffies + AG71XX_OOM_REFILL);\n-\tnapi_complete(napi);\n+\tnapi_complete_done(napi, rx_done);\n \treturn 0;\n }\n \n","prefixes":["LEDE-DEV"]}