{"id":809241,"url":"http://patchwork.ozlabs.org/api/1.2/patches/809241/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/patch/a9dc18ece6b62e3ac4ce274b708081a9d16bb6aa.1504431850.git.yann.morin.1998@free.fr/","project":{"id":27,"url":"http://patchwork.ozlabs.org/api/1.2/projects/27/?format=json","name":"Buildroot development","link_name":"buildroot","list_id":"buildroot.buildroot.org","list_email":"buildroot@buildroot.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-03T09:44:29","name":"[3/8] toolchain/external-custom: hide versions too old for the current arch","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0e8a881d72143ac910e81e9c9d90e2ce8b0e9e35","submitter":{"id":13903,"url":"http://patchwork.ozlabs.org/api/1.2/people/13903/?format=json","name":"Yann E. MORIN","email":"yann.morin.1998@free.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/buildroot/patch/a9dc18ece6b62e3ac4ce274b708081a9d16bb6aa.1504431850.git.yann.morin.1998@free.fr/mbox/","series":[{"id":1206,"url":"http://patchwork.ozlabs.org/api/1.2/series/1206/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/list/?series=1206","date":"2017-09-03T09:44:27","name":"[1/8] arch: introduce minimal required gcc version","version":1,"mbox":"http://patchwork.ozlabs.org/series/1206/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809241/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809241/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"shWi/hg8\"; dkim-atps=neutral"],"Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlSkT660cz9s71\n\tfor ;\n\tSun, 3 Sep 2017 19:44:49 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3837887048;\n\tSun, 3 Sep 2017 09:44:48 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BXEP8-5jWIi7; Sun, 3 Sep 2017 09:44:45 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BAEEC86F77;\n\tSun, 3 Sep 2017 09:44:45 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3DAAA1C41C7\n\tfor ;\n\tSun, 3 Sep 2017 09:44:43 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3708382165\n\tfor ;\n\tSun, 3 Sep 2017 09:44:43 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Buq79be6Bss6 for ;\n\tSun, 3 Sep 2017 09:44:42 +0000 (UTC)","from mail-wr0-f193.google.com (mail-wr0-f193.google.com\n\t[209.85.128.193])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 618B1820F5\n\tfor ; Sun, 3 Sep 2017 09:44:42 +0000 (UTC)","by mail-wr0-f193.google.com with SMTP id 40so2012914wrv.3\n\tfor ; Sun, 03 Sep 2017 02:44:42 -0700 (PDT)","from localhost.localdomain\n\t(2a01cb08861073004cc40c703ef54565.ipv6.abo.wanadoo.fr.\n\t[2a01:cb08:8610:7300:4cc4:c70:3ef5:4565])\n\tby smtp.gmail.com with ESMTPSA id\n\tt135sm1972938wmt.30.2017.09.03.02.44.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 03 Sep 2017 02:44:39 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=deYeDywe7Zasc7gReSt0sg5JML9UNJwLGkSQmOoLbyE=;\n\tb=shWi/hg85cpZmNMPbW7xPx3gIexR9ZLeQJRvF2rND+F0hgQ6EJYfqS9qirhkjVviyu\n\tyf8032gNq0utcQbuA19Af18amttZjsAXm5ZPZACXI9sBCNyRRiixP9F6ciYQfTKVaGFl\n\t3g+B7RXcYbZjU641leEJH7vYloRCBY9PcAynj2NBOEz8TbVaLRKBNlIiU7TGaCV/zgMz\n\tr+Q7YzOIvAGotvCm5TSoW5+LayZP/vih4hmBxey0YspRNZ+d7wlvsJqwPEgDaY6RIqC+\n\tFYjWtbalh/7oWWRXG/BCoSpJT9gRAxbjpjVWYsWzXTXB9Koye93hkAModVvQ8iX/2vfa\n\tQ3kA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=deYeDywe7Zasc7gReSt0sg5JML9UNJwLGkSQmOoLbyE=;\n\tb=TDpSKsWS323Tc/tSANoBFG9fm6daN6jA0kKrh4xPWwv1aRUNyhZPFVMZXcmHuU3H+l\n\tRkhC8FSUQGjbQrIQER2wLPYxspMco0fDMF49FLMot/IgpTGQijvOYY9ARgeHeeaJj2ml\n\tfrilLK0F9ybfquk+VPj1aPMc2vfVxNHT5tXkvOQ3BLarjKDg33NgB2dbrZ+/ohh+B+Rg\n\tfk4fer6YvnhJc+/EYh+PniA32e/TfF8a6NA4yqcBzxcpq5k+VE0HVQeNVeTtmT5mVaSp\n\tMaY1PufMINUBvxl1N0m4mtYbedPtK1yq8HCwAYJL8ZpE/0t3edyjU4U8PswN4C5HIP13\n\tJ+zw==","X-Gm-Message-State":"AHPjjUgxJu6isPAv7RNgOEJIGZCUOA1wycXhzGIwAcEeVWGsjMZENQAU\n\t6G0YvcZEroqkH82R","X-Google-Smtp-Source":"ADKCNb4LIua7W1GLSdalgZ5m/tRvLZ0l4ajWEbTrsBrbXEQayd6b5NNM3p4ixJRTlRpdN3Gx9zXAcA==","X-Received":"by 10.223.153.106 with SMTP id x97mr665910wrb.87.1504431880689; \n\tSun, 03 Sep 2017 02:44:40 -0700 (PDT)","From":"\"Yann E. MORIN\" ","To":"buildroot@buildroot.org","Date":"Sun, 3 Sep 2017 11:44:29 +0200","Message-Id":"","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"","References":"","Cc":"Thomas Petazzoni ,\n\t\"Yann E. MORIN\" ","Subject":"[Buildroot] [PATCH 3/8] toolchain/external-custom: hide versions\n\ttoo old for the current arch","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "},"content":"When an architecture expresses a requirement on the gcc version, limit\nthe version choice in the custom external toolchain.\n\nThe ratioanle being that there is no point in offering that version to\nthe user if we know before-hand that the gcc version will not work for\nthat architecture.\n\nAll versions below the minimum we support is just made conditional to\nthat minimum as well, including the \"older\" entry.\n\nHowever, this means that the \"older\" entry is no longer available when\nthe architecture requires a minimum gcc version. A user who wants to use\na toolchain with a gcc older than the minimum will have no choice but to\nrealise the toolchain is not suitable (or lie and we would catch that\nwhen checking the gcc version anyway).\n\nSigned-off-by: \"Yann E. MORIN\" \nCc: Thomas Petazzoni \n\n---\nNote: this implies that it is no longer possible to use a custom\nexternal toolchain in which a specific core has been back-ported\nThus, this patch may cause regressions in very specific and rare\ncorner cases. Do we want to support those cases? If yes, then we\nshould drop this patch.\n---\n .../toolchain-external-custom/Config.in.options | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)","diff":"diff --git a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options\nindex ae343ddad5..eb7c30f171 100644\n--- a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options\n+++ b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options\n@@ -18,6 +18,11 @@ config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX\n \n choice\n \tbool \"External toolchain gcc version\"\n+\tdefault BR2_TOOLCHAIN_EXTERNAL_GCC_7 if BR2_ARCH_NEEDS_GCC_AT_LEAST_7\n+\tdefault BR2_TOOLCHAIN_EXTERNAL_GCC_6 if BR2_ARCH_NEEDS_GCC_AT_LEAST_6\n+\tdefault BR2_TOOLCHAIN_EXTERNAL_GCC_5 if BR2_ARCH_NEEDS_GCC_AT_LEAST_5\n+\tdefault BR2_TOOLCHAIN_EXTERNAL_GCC_4_9 if BR2_ARCH_NEEDS_GCC_AT_LEAST_4_9\n+\tdefault BR2_TOOLCHAIN_EXTERNAL_GCC_4_8 if BR2_ARCH_NEEDS_GCC_AT_LEAST_4_8\n \tdefault BR2_TOOLCHAIN_EXTERNAL_GCC_4_3\n \thelp\n \t Set to the gcc version that is used by your external\n@@ -29,42 +34,52 @@ config BR2_TOOLCHAIN_EXTERNAL_GCC_7\n \n config BR2_TOOLCHAIN_EXTERNAL_GCC_6\n \tbool \"6.x\"\n+\tdepends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_7\n \tselect BR2_TOOLCHAIN_GCC_AT_LEAST_6\n \n config BR2_TOOLCHAIN_EXTERNAL_GCC_5\n \tbool \"5.x\"\n+\tdepends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_6\n \tselect BR2_TOOLCHAIN_GCC_AT_LEAST_5\n \n config BR2_TOOLCHAIN_EXTERNAL_GCC_4_9\n \tbool \"4.9.x\"\n+\tdepends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_5\n \tselect BR2_TOOLCHAIN_GCC_AT_LEAST_4_9\n \n config BR2_TOOLCHAIN_EXTERNAL_GCC_4_8\n \tbool \"4.8.x\"\n+\tdepends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_4_9\n \tselect BR2_TOOLCHAIN_GCC_AT_LEAST_4_8\n \n config BR2_TOOLCHAIN_EXTERNAL_GCC_4_7\n \tbool \"4.7.x\"\n+\tdepends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_4_8\n \tselect BR2_TOOLCHAIN_GCC_AT_LEAST_4_7\n \n config BR2_TOOLCHAIN_EXTERNAL_GCC_4_6\n \tbool \"4.6.x\"\n+\tdepends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_4_8\n \tselect BR2_TOOLCHAIN_GCC_AT_LEAST_4_6\n \n config BR2_TOOLCHAIN_EXTERNAL_GCC_4_5\n \tbool \"4.5.x\"\n+\tdepends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_4_8\n \tselect BR2_TOOLCHAIN_GCC_AT_LEAST_4_5\n \n config BR2_TOOLCHAIN_EXTERNAL_GCC_4_4\n \tbool \"4.4.x\"\n+\tdepends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_4_8\n \tselect BR2_TOOLCHAIN_GCC_AT_LEAST_4_4\n \n config BR2_TOOLCHAIN_EXTERNAL_GCC_4_3\n \tbool \"4.3.x\"\n+\tdepends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_4_8\n \tselect BR2_TOOLCHAIN_GCC_AT_LEAST_4_3\n \n config BR2_TOOLCHAIN_EXTERNAL_GCC_OLD\n \tbool \"older\"\n+\tdepends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_4_8\n \thelp\n \t Use this option if your GCC version is older than any of the\n \t above.\n","prefixes":["3/8"]}