{"id":809213,"url":"http://patchwork.ozlabs.org/api/1.2/patches/809213/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170903042117.28923-7-saeedm@mellanox.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170903042117.28923-7-saeedm@mellanox.com>","list_archive_url":null,"date":"2017-09-03T04:21:06","name":"[net-next,06/17] net/mlx5e: NAPI busy-poll when UMR post is in progress","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"44f8e14467abf5b99db61f3be4c34fa7d10da408","submitter":{"id":65299,"url":"http://patchwork.ozlabs.org/api/1.2/people/65299/?format=json","name":"Saeed Mahameed","email":"saeedm@mellanox.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170903042117.28923-7-saeedm@mellanox.com/mbox/","series":[{"id":1196,"url":"http://patchwork.ozlabs.org/api/1.2/series/1196/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=1196","date":"2017-09-03T04:21:09","name":"[net-next,01/17] net/mlx5e: Reorganize struct mlx5e_rq","version":1,"mbox":"http://patchwork.ozlabs.org/series/1196/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809213/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809213/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlKbq3VdDz9s7C\n\tfor ;\n\tSun, 3 Sep 2017 14:23:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752372AbdICEXT (ORCPT );\n\tSun, 3 Sep 2017 00:23:19 -0400","from mail-il-dmz.mellanox.com ([193.47.165.129]:60016 \"EHLO\n\tmellanox.co.il\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1751071AbdICEWL (ORCPT\n\t); Sun, 3 Sep 2017 00:22:11 -0400","from Internal Mail-Server by MTLPINE1 (envelope-from\n\tsaeedm@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 3 Sep 2017 07:22:06 +0300","from sws.mtl.labs.mlnx (reg-l-vrt-045-015.mtl.labs.mlnx\n\t[10.135.45.15])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v834M5l7017672;\n\tSun, 3 Sep 2017 07:22:06 +0300"],"From":"Saeed Mahameed ","To":"\"David S. Miller\" ","Cc":"netdev@vger.kernel.org, kernel-team@fb.com,\n\tTariq Toukan , Saeed Mahameed ","Subject":"[net-next 06/17] net/mlx5e: NAPI busy-poll when UMR post is in\n\tprogress","Date":"Sun, 3 Sep 2017 07:21:06 +0300","Message-Id":"<20170903042117.28923-7-saeedm@mellanox.com>","X-Mailer":"git-send-email 2.13.0","In-Reply-To":"<20170903042117.28923-1-saeedm@mellanox.com>","References":"<20170903042117.28923-1-saeedm@mellanox.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Tariq Toukan \n\nIf a UMR post is in progress, it means that there's a missing\nWQE in RQ, and that a completion will be shortly available in\nICO SQ completion queue. Prefer busy-poll to handle it as soon\nas possible.\n\nSigned-off-by: Tariq Toukan \nSigned-off-by: Saeed Mahameed \n---\n drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c\nindex fb3b83609aea..8af6577b7501 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c\n@@ -456,17 +456,16 @@ void mlx5e_dealloc_rx_mpwqe(struct mlx5e_rq *rq, u16 ix)\n \tmlx5e_free_rx_mpwqe(rq, wi);\n }\n \n-#define RQ_CANNOT_POST(rq) \\\n-\t(!test_bit(MLX5E_RQ_STATE_ENABLED, &rq->state) || \\\n-\t test_bit(MLX5E_RQ_STATE_UMR_WQE_IN_PROGRESS, &rq->state))\n-\n bool mlx5e_post_rx_wqes(struct mlx5e_rq *rq)\n {\n \tstruct mlx5_wq_ll *wq = &rq->wq;\n \n-\tif (unlikely(RQ_CANNOT_POST(rq)))\n+\tif (unlikely(!test_bit(MLX5E_RQ_STATE_ENABLED, &rq->state)))\n \t\treturn false;\n \n+\tif (test_bit(MLX5E_RQ_STATE_UMR_WQE_IN_PROGRESS, &rq->state))\n+\t\treturn true;\n+\n \twhile (!mlx5_wq_ll_is_full(wq)) {\n \t\tstruct mlx5e_rx_wqe *wqe = mlx5_wq_ll_get_wqe(wq, wq->head);\n \t\tint err;\n","prefixes":["net-next","06/17"]}