{"id":809025,"url":"http://patchwork.ozlabs.org/api/1.2/patches/809025/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1504303424-28452-1-git-send-email-mpe@ellerman.id.au/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<1504303424-28452-1-git-send-email-mpe@ellerman.id.au>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/1504303424-28452-1-git-send-email-mpe@ellerman.id.au/","date":"2017-09-01T22:03:44","name":"powerpc/sstep: Avoid used uninitialized error","commit_ref":"3b79b26101936bbdb7a5c69161c69d65a1108fb0","pull_url":null,"state":"accepted","archived":false,"hash":"da3be9f57368ceda6791396547ff55e63c67ecd4","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/1.2/people/46580/?format=json","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1504303424-28452-1-git-send-email-mpe@ellerman.id.au/mbox/","series":[{"id":1126,"url":"http://patchwork.ozlabs.org/api/1.2/series/1126/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=1126","date":"2017-09-01T22:03:44","name":"powerpc/sstep: Avoid used uninitialized error","version":1,"mbox":"http://patchwork.ozlabs.org/series/1126/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/809025/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/809025/checks/","tags":{},"related":[],"headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkYFS4dDCz9sPt\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat,  2 Sep 2017 08:05:00 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xkYFS3k3szDr2m\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat,  2 Sep 2017 08:05:00 +1000 (AEST)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xkYD913t8zDqZf\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSat,  2 Sep 2017 08:03:53 +1000 (AEST)","by ozlabs.org (Postfix)\n\tid 3xkYD86SXyz9sQl; Sat,  2 Sep 2017 08:03:52 +1000 (AEST)","by ozlabs.org (Postfix, from userid 1034)\n\tid 3xkYD85zZzz9sRV; Sat,  2 Sep 2017 08:03:52 +1000 (AEST)"],"From":"Michael Ellerman <mpe@ellerman.id.au>","To":"linuxppc-dev@ozlabs.org","Subject":"[PATCH] powerpc/sstep: Avoid used uninitialized error","Date":"Sat,  2 Sep 2017 08:03:44 +1000","Message-Id":"<1504303424-28452-1-git-send-email-mpe@ellerman.id.au>","X-Mailer":"git-send-email 2.7.4","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Cc":"paulus@samba.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"},"content":"Older compilers think val may be used uninitialized:\n\n  arch/powerpc/lib/sstep.c: In function 'emulate_loadstore':\n  arch/powerpc/lib/sstep.c:2758:23: error: 'val' may be used uninitialized in this function\n\nWe know better, but initialise val to 0 to avoid breaking the build.\n\nSigned-off-by: Michael Ellerman <mpe@ellerman.id.au>\n---\n arch/powerpc/lib/sstep.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c\nindex 06dd61d8d48b..fb9f58b868e7 100644\n--- a/arch/powerpc/lib/sstep.c\n+++ b/arch/powerpc/lib/sstep.c\n@@ -2727,6 +2727,7 @@ int emulate_loadstore(struct pt_regs *regs, struct instruction_op *op)\n \t\tif (!address_ok(regs, ea, size))\n \t\t\treturn -EFAULT;\n \t\terr = 0;\n+\t\tval = 0;\n \t\tswitch (size) {\n #ifdef __powerpc64__\n \t\tcase 1:\n","prefixes":[]}