{"id":808377,"url":"http://patchwork.ozlabs.org/api/1.2/patches/808377/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/1504201930-3617-7-git-send-email-fabio.estevam@nxp.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.2/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504201930-3617-7-git-send-email-fabio.estevam@nxp.com>","list_archive_url":null,"date":"2017-08-31T17:52:07","name":"[07/10] PCI: altera-msi: Fix platform_get_irq() error handling","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"6f30cc13bfcdfe2b396157bb9108fcb8722ce77e","submitter":{"id":67998,"url":"http://patchwork.ozlabs.org/api/1.2/people/67998/?format=json","name":"Fabio Estevam","email":"fabio.estevam@nxp.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/1504201930-3617-7-git-send-email-fabio.estevam@nxp.com/mbox/","series":[{"id":888,"url":"http://patchwork.ozlabs.org/api/1.2/series/888/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=888","date":"2017-08-31T17:52:05","name":"[01/10] PCI: exynos: Fix platform_get_irq() error handling","version":1,"mbox":"http://patchwork.ozlabs.org/series/888/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808377/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808377/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","spf=fail (sender IP is 192.88.168.50)\n\tsmtp.mailfrom=nxp.com; altera.com; dkim=none (message not signed)\n\theader.d=none; altera.com; dmarc=fail action=none header.from=nxp.com;"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjqj63bM6z9s7c\n\tfor ;\n\tFri, 1 Sep 2017 03:52:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751040AbdHaRwz (ORCPT );\n\tThu, 31 Aug 2017 13:52:55 -0400","from mail-dm3nam03on0057.outbound.protection.outlook.com\n\t([104.47.41.57]:63776\n\t\"EHLO NAM03-DM3-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751410AbdHaRws (ORCPT );\n\tThu, 31 Aug 2017 13:52:48 -0400","from BN6PR03CA0014.namprd03.prod.outlook.com (10.168.230.152) by\n\tCY1PR03MB2265.namprd03.prod.outlook.com (10.166.207.17) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.13.10; Thu, 31 Aug 2017 17:52:46 +0000","from BN1BFFO11FD021.protection.gbl (2a01:111:f400:7c10::1:131) by\n\tBN6PR03CA0014.outlook.office365.com (2603:10b6:404:23::24) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10 via\n\tFrontend Transport; Thu, 31 Aug 2017 17:52:46 +0000","from tx30smr01.am.freescale.net (192.88.168.50) by\n\tBN1BFFO11FD021.mail.protection.outlook.com (10.58.144.84) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1385.11\n\tvia Frontend Transport; Thu, 31 Aug 2017 17:52:46 +0000","from r49496.am.freescale.net (r49496.am.freescale.net\n\t[10.29.244.202])\n\tby tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id\n\tv7VHqajO026181; Thu, 31 Aug 2017 10:52:44 -0700"],"Received-SPF":"Fail (protection.outlook.com: domain of nxp.com does not\n\tdesignate 192.88.168.50 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;","From":"Fabio Estevam ","To":"","CC":", Fabio Estevam ,\n\tLey Foon Tan ","Subject":"[PATCH 07/10] PCI: altera-msi: Fix platform_get_irq() error handling","Date":"Thu, 31 Aug 2017 14:52:07 -0300","Message-ID":"<1504201930-3617-7-git-send-email-fabio.estevam@nxp.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1504201930-3617-1-git-send-email-fabio.estevam@nxp.com>","References":"<1504201930-3617-1-git-send-email-fabio.estevam@nxp.com>","X-EOPAttributedMessage":"0","X-Matching-Connectors":"131486755662344334;\n\t(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()","X-Forefront-Antispam-Report":"CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(498600001)(626005)(356003)(305945005)(33646002)(105606002)(2351001)(106466001)(189998001)(8676002)(76176999)(50986999)(50226002)(104016004)(81166006)(81156014)(2906002)(77096006)(8936002)(68736007)(8656003)(53936002)(8666007)(54906002)(97736004)(36756003)(2950100002)(6916009)(6666003)(5003940100001)(4326008)(47776003)(50466002)(86362001)(85426001)(48376002)(5660300001)(110136004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2265;\n\tH:tx30smr01.am.freescale.net; FPR:; SPF:Fail;\n\tPTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; ","X-Microsoft-Exchange-Diagnostics":["1; BN1BFFO11FD021;\n\t1:OjjCKFfvQdx3yN+ODEIQFPvaLdVVq+5qRGDi6anWqOq3fkEMGlWuwurhmcJ11BMeC4dz2h6Y3HFQw7QxiYEPPAByB7xJ9GYDcc0b3vFMW4lDtPf2ByGk7gHinJJIJ+ll","1; CY1PR03MB2265;\n\t3:eZ+GGIEZRhrEppJnFOgKleZwXvYyqxr5HIPZx/CCFC3SFw0ZZmfjwtqQLBcWI62lNzsv1QoMXqNI5zNGpoRAhby1ENG0EhzfDayDvzclHW692Dww9BDZJ4PPbv+08hBJVegt4tRnecXxAVbXe4mUskCj6Ovufhvga0SqeC9Ri+Q9brPJMEU6h/3t4D7b5mAh/Kdl56I/3AVsP+dINT8hfcWqQlBwUSRm4eOmLCs8C2TIcEMMeUUwpa4LOPh4WMQf3NZcwfEa2wIMH4X9nSxBioCltrhhcjvByJaJg0EjBZYrnmxD2PxyKk0kyiaCLOP22IMF3FUPK2tJojt14lPWc6LUB+VCrmdjFCZ8N/plwjY=;\n\t25:Eu/QGsxtkpaiZVkMt9MAo+CXecF/WBipJDtEANbCChoUZPAjYki2xuH8VvdU8r4BkK/PXSCHgPfBWLI13muxettvN3w4+teNZ0ilsiKzGAdxMUkkq1v0zvIwuDytKGnllmHSitlF9owYVB8krx/JzKSaOFLWNjuUZDMB/8nsMl4dRDXAOjhmSOw0DFFGWOOD3Qz1ro5dJkzl/azENzhMIxMdMNhcvQEpfiuBFVn4z/vsx/4GpywxAL2jheJ6hB1++8wRqARGji0QmmhMEHEtAXZubB3ipG7dk8owIHuvuAfqQyUUrPKg4LiEANqqPN649/xmFvrUBX4Bytzh37c9fA==","1; CY1PR03MB2265;\n\t31:9b80MrhdZxqmKb5oO83VRM3hIxrXgEppR65ZmRoChUWUeIB1ee056XkPDCkRK4NNmJtuWsw2xWxrc47PaXLViJXdpfzD3IH9PMAE5Xe7xAByQhv6435xsTqNTjkEzS05Fbbcfn2o0tOHrXoqHBK4zekzhz5w9qTm7a8OyPKgAe0htqg6jBPN3mSHpd/RH/QsZLo+vgY/4/ONKQidkPo7qNs6hYzaSjXIrztRokVAR68=;\n\t4:4F+UoqchJsaOnXP8uSXRv6V90pe+mgs03xfPgc9YAah6w6QpUQGF28FC64gdPvef31nhEVSjKkpJFSi1khgRWH9hcATvY35+83B6XvRJFQgpqpMVPT21Rlv0KHxqfq9LON3Io+i+w9UjFl+Sc31XsJXZFFvfigHqB9QsqLyCKr1crs5wv6xIxEdNC58tpOdky8Zd/3VtOwRe5r0F9wZAB5taU9uobWJsxmK1nKI+cWWxVXMpsyFeYb4lWt3RLl9rYLTxy7lAXdYT1Jd2M6hcq783ytLyHcNE7Dj+l6uhnWao3m5+pRMHRf7rUpcEn1bQEm2ggRKwC+KjDpBDHfukNg==","1; CY1PR03MB2265;\n\t23:t10jf7Jx9zBW7dmr9YxQnZGFKkX/EmrZgYUtL/uHng0aJ/iznWHkZpbmHM0jl4mtfq4S1YC1njaTT38NOe8wHn+zZzp44sI5bDod2q0j+4BRLoSmAiX+TxUXPzfTuXyCo1W1foCoq2/FYrp35B+lqxDtwAPaDe0+YDAuVV+SUvG7XzTL1k8UjXKX43+aQogWwS//Ri7xbFtR7U8p+1eTtGfEYK4gn5wTXiOffVSAALOorW5mo56IKWP4sluGuMUXJl2vU82toSBMT4N5PafpPMQwZB8BC2XqqZlZ8FbD9oPHBvgAnF1PfLRj2CTNoVO4CR4Rp+cU5LOy2z0a+7CqBIG5rFEBJhTUa5YPAL0JonMwDQ8M8hzrE883bo41b9vCnfnnAutkeZFCXdaS/1v8pAusKTIz+90OXeGHoEVDBK75VQwn9XXp5ej2EuzZkva3ZtEcJ7I6B8/oeWn+GSDR+wBjUh6RpBl/qjWkMhnR3oc8QwTg8b0Gwyg128ksk5j/k9fvxFVnlq1m/PYRJyeDxwbc6cysMqNMJ6vBjgZpE2hw7oUwWKpLv6CQBKTzXCw+5ZK7jYX62p4MKytElZvvvRy0uH+IR52yXbI7Io5G8HPCWwKZQKOIGcy9bzPBwHUz2F0NN/QRzuUilO5nBYKyBKnoB0M9P8rSfbua08G70chtqdkY9C863m9cBR5v+TREqA+fv0ArHmpz3aAK5VBdQdW2ICfx+T41i4PircdhLwbQ62HFwXK+pLOwrc7yTIrH10A3/7gyhG843mb3IER7fM6B3SSdDb+U4qsGrLFVwwgyerB9CRMbZC3YXEPP0z1NFzbzOxdB/1il8rpAMQTvHfwooommNiX8Ytqn70fJYgNh8xq8QhgnjgrN80F4Yvwtcsj4YnyY+KoLPJlvS+VGs8zkti0vAvVKAeg6YUMhDzGQZ0jlMxJpo1oCc2dFaxZKaFoZHNP9GSKdKn6b6lsSNEWiKNkyt/4qseuyHz67cdc8PT7hx1dXN8T0N6Br1UJLggFuSrxQyfEcGk5AJ+JvdrPumsns8Unga/YAomfGVmJyNLdetpFOv+I46QaTEmVekXFEvIO3gtX+OHv1x7JX32EP2HaAHICZfIfTyZxMJ9ilS7PuxMg2pLI22XCbdxfn","1; CY1PR03MB2265;\n\t6:IwP+EqVOWi79NLBlHqcpGs9LhrzDQL6a1rO6fz+b4UkdbyH2vLNwXggDLq3lfXPrJB5ZmUI3I/3z9eSBLSVbkjrWzdt3XuCdFVD2OnfAR9r/TfYW05OCd+qCZ3LvAqTL4mM/YGn/LGjW6Su3VKlFRruQT3AvwyI/jU0lfUEaYXFyEqvk3aNQ7rZ+OHTLCb2NV7m8ylstgHqPriTRFKxayI0XetcMQeFB49Ar18lUsC4C3xiWWg7Bd1SnEwd1Ok82ZbqQQpn4ZVchJSdODS+auJlsLT0xgbFaW/vh0xXXR+s8Dm5jFNMoPPrSGHwhyrVuBX87RneYLjeDsfOtHU0AZA==;\n\t5:KkqaOSVtmLc8c3A8sAX4o+HHKCmz2bTpMPUgnslQCm2HWticHrhzRdsSWyVvTYeGpbJxo++6KCXOvhPsz9VtCjlEMttiLUsGVaZGXsMWU40+lrhkoUiwrrbEAglSF4vxRMhOe9SpFiW5v7R6iGF9ig==;\n\t24:YGdIypaEONw+fZm3BtXLjIFS6mDrSZCnHtMH26nl0mDfSLQ6KLkVcxdtQGL19yG0TrQ5Dgfz2nbucGO9KrAVr2tOnK+mcPdTfQhMUBsh5ac=;\n\t7:JeCUhfMthw+gIJskdd9Tkv6ApAo2ujudOcOqwRyqvP5jALZx6ci1v8UcgF8bd4/y62Rw050uzPS+/u0a3oPNj8/dW+e4MPkq2kilrzE/otvHTUdIzLZKkKw7NlKd68Nw5fn9EzwnnOP8vBhiA5/+U9HnQGJtux+zTRHc2LgrJWpM2qYKW5U9IyZkb6QxSwfkldoiMByQUdZu8torrfsoqWTynEnfqxEamQSX2a4P79I="],"MIME-Version":"1.0","Content-Type":"text/plain","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"ae015f6f-36c8-49b7-cf2f-08d4f0991660","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:CY1PR03MB2265; ","X-MS-TrafficTypeDiagnostic":"CY1PR03MB2265:","X-Exchange-Antispam-Report-Test":"UriScan:(185117386973197)(80048183373757);","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(5005006)(13018025)(13016025)(8121501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6096035)(20161123561025)(20161123563025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123559100)(20161123565025)(20161123556025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:CY1PR03MB2265; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:CY1PR03MB2265; ","X-Forefront-PRVS":"04163EF38A","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"31 Aug 2017 17:52:46.0316\n\t(UTC)","X-MS-Exchange-CrossTenant-Id":"5afe0b00-7697-4969-b663-5eab37d5f47e","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;\n\tIp=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net]","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CY1PR03MB2265","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"},"content":"platform_get_irq() returns a negative number on failure, so\nadjust the logic to detect such condition and propagate\nthe real error value on failure.\n\nCc: Ley Foon Tan \nSigned-off-by: Fabio Estevam \n---\n drivers/pci/host/pcie-altera-msi.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/pci/host/pcie-altera-msi.c b/drivers/pci/host/pcie-altera-msi.c\nindex 2864030..d8141f4 100644\n--- a/drivers/pci/host/pcie-altera-msi.c\n+++ b/drivers/pci/host/pcie-altera-msi.c\n@@ -265,9 +265,9 @@ static int altera_msi_probe(struct platform_device *pdev)\n \t\treturn ret;\n \n \tmsi->irq = platform_get_irq(pdev, 0);\n-\tif (msi->irq <= 0) {\n+\tif (msi->irq < 0) {\n \t\tdev_err(&pdev->dev, \"failed to map IRQ: %d\\n\", msi->irq);\n-\t\tret = -ENODEV;\n+\t\tret = msi->irq;\n \t\tgoto err;\n \t}\n \n","prefixes":["07/10"]}