{"id":808373,"url":"http://patchwork.ozlabs.org/api/1.2/patches/808373/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/1504201930-3617-4-git-send-email-fabio.estevam@nxp.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.2/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504201930-3617-4-git-send-email-fabio.estevam@nxp.com>","list_archive_url":null,"date":"2017-08-31T17:52:04","name":"[04/10] PCI: artpec6: Fix platform_get_irq() error handling","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"495d92d76b3a90db4605970cf631d1d05127289b","submitter":{"id":67998,"url":"http://patchwork.ozlabs.org/api/1.2/people/67998/?format=json","name":"Fabio Estevam","email":"fabio.estevam@nxp.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/1504201930-3617-4-git-send-email-fabio.estevam@nxp.com/mbox/","series":[{"id":888,"url":"http://patchwork.ozlabs.org/api/1.2/series/888/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=888","date":"2017-08-31T17:52:05","name":"[01/10] PCI: exynos: Fix platform_get_irq() error handling","version":1,"mbox":"http://patchwork.ozlabs.org/series/888/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808373/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808373/checks/","tags":{},"related":[],"headers":{"Return-Path":"<linux-pci-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","spf=fail (sender IP is 192.88.168.50)\n\tsmtp.mailfrom=nxp.com; axis.com; dkim=none (message not signed)\n\theader.d=none;axis.com; dmarc=fail action=none header.from=nxp.com;"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjqj05hkHz9s83\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 03:52:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751417AbdHaRwu (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tThu, 31 Aug 2017 13:52:50 -0400","from mail-dm3nam03on0085.outbound.protection.outlook.com\n\t([104.47.41.85]:64224\n\t\"EHLO NAM03-DM3-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751040AbdHaRwp (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tThu, 31 Aug 2017 13:52:45 -0400","from BN6PR03CA0092.namprd03.prod.outlook.com (10.164.122.158) by\n\tDM5PR03MB3321.namprd03.prod.outlook.com (10.174.241.142) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.13.10; Thu, 31 Aug 2017 17:52:43 +0000","from BN1BFFO11FD033.protection.gbl (2a01:111:f400:7c10::1:164) by\n\tBN6PR03CA0092.outlook.office365.com (2603:10b6:405:6f::30) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9 via\n\tFrontend Transport; Thu, 31 Aug 2017 17:52:43 +0000","from tx30smr01.am.freescale.net (192.88.168.50) by\n\tBN1BFFO11FD033.mail.protection.outlook.com (10.58.144.96) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1385.11\n\tvia Frontend Transport; Thu, 31 Aug 2017 17:52:42 +0000","from r49496.am.freescale.net (r49496.am.freescale.net\n\t[10.29.244.202])\n\tby tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id\n\tv7VHqajL026181; Thu, 31 Aug 2017 10:52:40 -0700"],"Received-SPF":"Fail (protection.outlook.com: domain of nxp.com does not\n\tdesignate 192.88.168.50 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;","From":"Fabio Estevam <fabio.estevam@nxp.com>","To":"<bhelgaas@google.com>","CC":"<linux-pci@vger.kernel.org>, Fabio Estevam <fabio.estevam@nxp.com>,\n\tNiklas Cassel <niklas.cassel@axis.com>","Subject":"[PATCH 04/10] PCI: artpec6: Fix platform_get_irq() error handling","Date":"Thu, 31 Aug 2017 14:52:04 -0300","Message-ID":"<1504201930-3617-4-git-send-email-fabio.estevam@nxp.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1504201930-3617-1-git-send-email-fabio.estevam@nxp.com>","References":"<1504201930-3617-1-git-send-email-fabio.estevam@nxp.com>","X-EOPAttributedMessage":"0","X-Matching-Connectors":"131486755625279506;\n\t(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()","X-Forefront-Antispam-Report":"CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(68736007)(54906002)(50466002)(8676002)(81156014)(8936002)(189998001)(50226002)(356003)(626005)(6916009)(4326008)(77096006)(6666003)(48376002)(2950100002)(305945005)(76176999)(81166006)(50986999)(5003940100001)(105606002)(106466001)(33646002)(104016004)(2906002)(2351001)(36756003)(110136004)(97736004)(53936002)(5660300001)(85426001)(8656003)(498600001)(86362001)(47776003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB3321;\n\tH:tx30smr01.am.freescale.net; FPR:; SPF:Fail;\n\tPTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; ","X-Microsoft-Exchange-Diagnostics":["1; BN1BFFO11FD033;\n\t1:TfGJLu3LN7fcjzoN5+P38UqyXMn3r2ed3qULIHsWvCYaOaIoDmAVtH3K+lElQsXIl0CHTxopB3Ipdlm9SwaWUeKo51taiU/Azu+jyz1iWNBpxmxkeLy44DJTB8diyMns","1; DM5PR03MB3321;\n\t3:lXnlvEB+5KYeHFBo7fWxTPmoxGYXp+BIkkWxU4qTJz+TgXIHzZmYsqKLK5IG6pofmtv2+VNbWNBwfeC66IVTUQFJzBRzSdwI7gCHU/M20E9Kopj3PIktylPwnOXdUl/lHMs681gmfjcjrMNsw2GEQ81TSewyeUdmqX1eLjjgtHSx9qp9YTGv9MBgIR5zoXtbtgDzPfESsFKtSD1zyjeFsRURodfGjFtVEfmwTuYtRjx7VlISQYht855YKhll6Z/iSfIZ9SsqQz6glfwS5qH6ksHxYH0p9mFoTPLDCkrnvKYCLxvOSutvgg9HWBgy/vLBgXvFvgafKL0hxyES2U4Gt8+u7TmiYD/tO9byPf5f9sM=;\n\t25:fKNwZIqGTFK2CL8tCOAZS3PjLvKg/k8vR7xyaqYGN9JfMt6mA4epRQ/dmlhGhkKMyK2k/+L0gz99jxW+ydlgfphe07A5DWLkel4VJSdf2pjjmh2/NFZmIq7YSWpatdjlfXADpj8YAqaVZ2v+KQE/0iZFO/fxKKwzX1VS4Fw6Ow5dI31gC4YsNGxXJUCpEuysskrbrXKKnxRgnexPNb44fbzqsHWOuPvapN8eJu90mn6LlsqSiEjYIE3zX6KGUc0AV728xE9GHkX6ck/MVbqLBtpFM5vpz+3udvcZEwj9wOmkfVSE6KTB9UkEinlNYoq6ozMuPofGybCcrlb7kpMZAQ==","1; DM5PR03MB3321;\n\t31:riMb7JCYh2hF7YH1u/eNbbnK677PpVQ11f0vmzWvK7BK6L2HvkCOn1yZSUl1unyYNXmM0DA91XNBEmVzprDbFVAJxmxNcOjSmIw2W6RpTFgQH3YlUTNOwqnujRt92dUVpJduPVngbziULdJwxX29VEKCDBZDmxzTJS+Oj91yohE+fQr8Rf3TnEdRGH/6NhYQ806SaNmn3h/T5P2WXiwspUmtRZjhsbMLteLkkMylmOA=;\n\t4:iGEdNMfOso79lHfqG95Yur5j4Cyb4esCkvlE18y2czd0WbCx3UTIa+bMSKL43w6lX+wP4XCArLsslatS/OXkeUSPWsrYMP5g2L//9ShFH1UrcXICnOhSliyHnhxJjsl+79bjVr3sQaZOn1uSEeu41MS4B9rVVAKfQVwDgbmSUz7a8xo+ExCQzlKNfooEHA0OVmHR6RxzlZyKpb0ZUoEAeup+wFWhzxKN28JwIoeHmDFaJhLXagaYF8lIygZ2VZyZTAQ2+IsnH3BMo2yhH3dRJOkPBaJ648/amvc75RoDT2g=","1; DM5PR03MB3321;\n\t23:ZL+Nt58WAREpWdQ++sw1WIkwK+hGP3CWwKQxulHor4yvuToIBhz6wz4TLNRLKHfDp6JzldwtHlbNJX5NdGsCgtymnIQiK+Nw5P1VP7MosJMmtkQW3C1wpWSTORcqhbOJ6w+jr1gH/xjcCDcztzDFtiKxWYN5zHW1Uhegd3c0HqfBne5NLpz71lAeeFLtpqf8j+gMnYzIEUlunXvVFr7lwzbrtr9xJ1auKAYD8M5ytdLkRY1TpnWMTsiOZtXWYO0U1uLMGyKb744b70aiAQ3HtGSnV+UtO5cIEEiCSwU+/SDQZMfclyVQGEFGF/ZYESENf/IDdzYntf3OCAfqqjRgXyjbMBSCI/xq7tk+YkmxAjOSXHiywZkMZt8Z4882hJPB2Vwy2OVX6rOzXXL2BEWtmXhIWHESpB1ZD6uQEcDLPahZzYsN970Z7UBoSv+VKBIJlPoyWuLzOL+GT1DnjJFfrpHQo4eCks9nA10DEb8E+Yc4waXzIZojDXwvjG4QW2FnqZEbwu0OW2it7QFFlZK9Ksx66tuwFMweoFLCeWI7gBWVzX+RWlQAdfeJcNgvsSBRvuQOIb9rsWcgtmfDTkFzwaTQCDXzICAP6BGL/b9xmY5YhwKE9BcwKaZecGi/uJiwo0NIRCaLezRqt93ubQ3ZTrwPO4gJOZM4FiLW81mMDOIhcsrHuAZeD+I7bRKfKuTMlnqStYxTySYjkXr7T4Ic0PCBjuIXI0a5HDezGIzL2cvJxDIwzsOqb9ysDd7VMt8hClXB44nmRFKXG1n0utCwIcHNq5IRuanEjmJcQ8ev26pLCT9X4bEASM8By5wlsL+2MeXt9GWS065p/Gy9KuRqwETiYNmh3ZIXg66kDMtwB279W798gx5u4tB/YYp4jWmqCBy1BO7pfxQerIxDW2KdHb+dCVStkKkhQ23wLWHLpQKyehHUypYQqU8K4Sic9BWkMVxnkegybhELpG10Knf/0GWYL8lEhXCJ2Manr262gu74j7PuqiS702beJLiFpORDbCkCjwcXuFmxL1UJL1byZstTt2NBRNp7tN3jHcXS08SHxeqMniQma4boXiNNyI/UUUn8NrsFXX3Oqff1isOQKZbNLe2qiS97JW7JOVFnbzHxNnasnT1HmWzIfkwqJj/U","1; DM5PR03MB3321;\n\t6:qyx2aabEnHFRzSVNOJLpCiHLRl1M+i0iX/Twl7H6azA58r9mMgn+yHoJXz6NqXns6hLu5ZLLpQej+pCUS4CFEAjMlNlrC5rmuymnQZ/fBY5zvlDlv/It8M4J35AeXtWXiwEVzOS/KgWrXzbxiuWKY1XvRbTFE1U+DOn5bRNGJe1yC33Rb9u4rXYWVcl957fDuwysY3/kRMO2/CWI5HlQBAyYuAQi1hE4N8IB7mOXf3aObGsGVulm0LSaiyV1O3Flt+IyZJyx4ymPCdVJ8rYyAU88g4RJ8Ean6uONLuy/tj+PRtUwkB16CQRZXoyPUuCS84fkO/QMzw06E2sNH6/OZg==;\n\t5:5PqnjmSMcIv9XB2+Hs8OtjRIRjCBBdLvkXNxELgdjVJtBd1aM4N/dnfLDDihMqU/5rhqJg2r8LGloe/zan5dlCgD7Ae2ae9JLyfv6bsgzwwQP+G9b9nnGaSB1+CCca1xsS30+rTavfSsuGP86f0rRA==;\n\t24:ovW/HHk+WoDA1Z/H1J4CbOPN+cfZszL8whcbSsh/m7WmIZwfqrnlzqXCvrfSk288ssdM0Hv00Tu0XQtEz2Zsoy60Jc9R3EQ6VMJTw8A2eZo=;\n\t7:iTebDSF1eJMiOMDgeQn3saD/gDenyiVlnu8x+l5uRBWFuVk3tgc2fupKHxtRqmNu9dTSQy6TgiWh5ta6kij6yMn+WLzPM2I9Lq9TTECV8CFZcXFCbi40CHRh1AN4pSsvoVEz+LPioFDGMlMZPI/7nQt5floa0/BSFXOZ1Gk2DrQqEKDWzOhH8Kw3KjUokDIGcAINQXAZKtXk8C8YbNbboM4S3+fE306eDUo7GJv4YOg="],"MIME-Version":"1.0","Content-Type":"text/plain","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"21fde2a9-55fd-4285-3eb1-08d4f099142b","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:DM5PR03MB3321; ","X-MS-TrafficTypeDiagnostic":"DM5PR03MB3321:","X-Exchange-Antispam-Report-Test":"UriScan:(185117386973197);","X-Microsoft-Antispam-PRVS":"<DM5PR03MB3321DFCBFFD41CF09CBE8D2DE39D0@DM5PR03MB3321.namprd03.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(5005006)(8121501046)(13018025)(13016025)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6096035)(20161123561025)(20161123563025)(20161123565025)(20161123556025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123559100)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DM5PR03MB3321; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DM5PR03MB3321; ","X-Forefront-PRVS":"04163EF38A","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"31 Aug 2017 17:52:42.3407\n\t(UTC)","X-MS-Exchange-CrossTenant-Id":"5afe0b00-7697-4969-b663-5eab37d5f47e","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;\n\tIp=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net]","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DM5PR03MB3321","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-pci.vger.kernel.org>","X-Mailing-List":"linux-pci@vger.kernel.org"},"content":"platform_get_irq() returns a negative number on failure, so\nadjust the logic to detect such condition and propagate\nthe real error value on failure.\n\nCc: Niklas Cassel <niklas.cassel@axis.com>\nSigned-off-by: Fabio Estevam <fabio.estevam@nxp.com>\n---\n drivers/pci/dwc/pcie-artpec6.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c\nindex 5d81f1d..83d6ee0 100644\n--- a/drivers/pci/dwc/pcie-artpec6.c\n+++ b/drivers/pci/dwc/pcie-artpec6.c\n@@ -209,9 +209,9 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie,\n \n \tif (IS_ENABLED(CONFIG_PCI_MSI)) {\n \t\tpp->msi_irq = platform_get_irq_byname(pdev, \"msi\");\n-\t\tif (pp->msi_irq <= 0) {\n+\t\tif (pp->msi_irq < 0) {\n \t\t\tdev_err(dev, \"failed to get MSI irq\\n\");\n-\t\t\treturn -ENODEV;\n+\t\t\treturn pp->msi_irq;\n \t\t}\n \n \t\tret = devm_request_irq(dev, pp->msi_irq,\n","prefixes":["04/10"]}