{"id":808242,"url":"http://patchwork.ozlabs.org/api/1.2/patches/808242/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/alpine.LSU.2.20.1708311511430.14191@zhemvz.fhfr.qr/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.2/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<alpine.LSU.2.20.1708311511430.14191@zhemvz.fhfr.qr>","list_archive_url":null,"date":"2017-08-31T13:13:20","name":"Early LTO debug TODO","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fb7e9b578ed375c52cf91a12f2fe0cb58d770ec1","submitter":{"id":4338,"url":"http://patchwork.ozlabs.org/api/1.2/people/4338/?format=json","name":"Richard Biener","email":"rguenther@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/alpine.LSU.2.20.1708311511430.14191@zhemvz.fhfr.qr/mbox/","series":[{"id":824,"url":"http://patchwork.ozlabs.org/api/1.2/series/824/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=824","date":"2017-08-31T13:13:20","name":"Early LTO debug TODO","version":1,"mbox":"http://patchwork.ozlabs.org/series/824/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808242/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808242/checks/","tags":{},"related":[],"headers":{"Return-Path":"<gcc-patches-return-461206-incoming=patchwork.ozlabs.org@gcc.gnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461206-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"cvwxF+zb\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjjVt26jvz9sMN\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 23:13:41 +1000 (AEST)","(qmail 36834 invoked by alias); 31 Aug 2017 13:13:33 -0000","(qmail 36825 invoked by uid 89); 31 Aug 2017 13:13:32 -0000","from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tThu, 31 Aug 2017 13:13:22 +0000","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\tby\n\tmx1.suse.de (Postfix) with ESMTP id 7AD45AAD0\tfor\n\t<gcc-patches@gcc.gnu.org>; Thu, 31 Aug 2017 13:13:20 +0000 (UTC)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:subject:message-id:mime-version:content-type; q=dns; s=\n\tdefault; b=vD8E/fbJqewaz0nvO4XSeg1bjY7A9wkAez0VM25QfO3mFoLAychYI\n\tBiYdSbNXC6yQ3q6l/CFHClVph4hdoLXuDlyNtHhCmELmACqEqKW5Ba5ZVrTbQuSK\n\t3m399jBbGaxBdZBL0MBqFLHyFkGmqKze/uzg7lmpmqHhjbnoTffJI0=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:subject:message-id:mime-version:content-type; s=\n\tdefault; bh=Twy7GqBW+tM37DLsWeuJBTazHPg=; b=cvwxF+zb8mESbBEKs4Hn\n\tCGAU/2UUKNDk8a/uoPxLfeghzWnD6pr9G/EocnHcm8YIalpGNzNkXIo9xvgkNefp\n\tHEXKruACD3qTkIM0dcbjTrD2gNNlq0JL2Z4K3W+CGcNuuYwliR35ZSFSUMDEsukm\n\tzysToTOJerLZaOv5q8cKjGY=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"<gcc-patches.gcc.gnu.org>","List-Unsubscribe":"<mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>","List-Archive":"<http://gcc.gnu.org/ml/gcc-patches/>","List-Post":"<mailto:gcc-patches@gcc.gnu.org>","List-Help":"<mailto:gcc-patches-help@gcc.gnu.org>","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2,\n\tGIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=suspected,\n\tHx-languages-length:1569","X-HELO":"mx1.suse.de","Date":"Thu, 31 Aug 2017 15:13:20 +0200 (CEST)","From":"Richard Biener <rguenther@suse.de>","To":"gcc-patches@gcc.gnu.org","Subject":"[PATCH] Early LTO debug TODO","Message-ID":"<alpine.LSU.2.20.1708311511430.14191@zhemvz.fhfr.qr>","User-Agent":"Alpine 2.20 (LSU 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII"},"content":"As suspected during review the DECL_ABSTRACT_P handling in\ngen_formal_parameter_die is no longer necessary so the following\npatch removes it.\n\n[LTO] bootstrapped on x86_64-unknown-linux-gnu, testing in progress.\nThe gdb testsuite shows no regression.\n\nWill apply after testing finished.\n\nRichard.\n\n2017-08-31  Richard Biener  <rguenther@suse.de>\n\n\t* dwarf2out.c (gen_formal_parameter_die): Remove no longer\n\tneeded DECL_ABSTRACT_P handling.","diff":"Index: gcc/dwarf2out.c\n===================================================================\n--- gcc/dwarf2out.c\t(revision 251559)\n+++ gcc/dwarf2out.c\t(working copy)\n@@ -21288,28 +21288,9 @@ gen_formal_parameter_die (tree node, tre\n   tree ultimate_origin;\n   dw_die_ref parm_die = NULL;\n   \n-  if (TREE_CODE_CLASS (TREE_CODE (node_or_origin)) == tcc_declaration)\n+  if (DECL_P (node_or_origin))\n     {\n       parm_die = lookup_decl_die (node);\n-\n-      /* If the contexts differ, we may not be talking about the same\n-\t thing.\n-\t ???  When in LTO the DIE parent is the \"abstract\" copy and the\n-\t context_die is the specification \"copy\".  But this whole block\n-\t should eventually be no longer needed.  */\n-      if (parm_die && parm_die->die_parent != context_die && !in_lto_p)\n-\t{\n-\t  if (!DECL_ABSTRACT_P (node))\n-\t    {\n-\t      /* This can happen when creating an inlined instance, in\n-\t\t which case we need to create a new DIE that will get\n-\t\t annotated with DW_AT_abstract_origin.  */\n-\t      parm_die = NULL;\n-\t    }\n-\t  else\n-\t    gcc_unreachable ();\n-\t}\n-\n       if (parm_die && parm_die->die_parent == NULL)\n \t{\n \t  /* Check that parm_die already has the right attributes that\n","prefixes":[]}