{"id":807808,"url":"http://patchwork.ozlabs.org/api/1.2/patches/807808/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/patch/1504115040-27121-1-git-send-email-karlp@etactica.com/","project":{"id":54,"url":"http://patchwork.ozlabs.org/api/1.2/projects/54/?format=json","name":"LEDE development","link_name":"lede","list_id":"lede-dev.lists.infradead.org","list_email":"lede-dev@lists.infradead.org","web_url":"http://lede-project.org/","scm_url":"","webscm_url":"http://git.lede-project.org/","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504115040-27121-1-git-send-email-karlp@etactica.com>","list_archive_url":null,"date":"2017-08-30T17:44:00","name":"[LEDE-DEV] procd: mdns: Support txt values with spaces","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"db2f0b8a11505173554c2087812465a4f86101a6","submitter":{"id":70060,"url":"http://patchwork.ozlabs.org/api/1.2/people/70060/?format=json","name":"Karl Palsson","email":"karlp@etactica.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/lede/patch/1504115040-27121-1-git-send-email-karlp@etactica.com/mbox/","series":[{"id":671,"url":"http://patchwork.ozlabs.org/api/1.2/series/671/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/list/?series=671","date":"2017-08-30T17:44:00","name":"[LEDE-DEV] procd: mdns: Support txt values with spaces","version":1,"mbox":"http://patchwork.ozlabs.org/series/671/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807808/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807808/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"ecA7YDhi\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjCZs46j9z9sN5\n\tfor ;\n\tThu, 31 Aug 2017 03:45:25 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dn736-0007Zc-BA; Wed, 30 Aug 2017 17:45:08 +0000","from palmtree.beeroclock.net ([2a01:7e00::f03c:91ff:fe93:f66c])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dn731-0006fk-54\n\tfor lede-dev@lists.infradead.org; Wed, 30 Aug 2017 17:45:05 +0000","from cuth.localdomain.localdomain (rtr1.dogg-hlidasmara14.sip.is\n\t[178.19.53.178])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: karlp)\n\tby palmtree.beeroclock.net (Postfix) with ESMTPSA id 381AA102A7;\n\tWed, 30 Aug 2017 17:44:17 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:\n\tDate:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=s6SNicyuTfhbLRzz+8a9A56OjLumdhTSLqJF2BV1Mes=;\n\tb=ecA7YDhiXzrAh9\n\tSesKL4xJGWVXgFP+LaXxIlJJqrXMtX3yroAd/a1xxXSOVFxLG3Y2GEbQJCWQsjwmsOEFAIHRMTMPe\n\tfYzQ6ZqEFel+UQpIpA0kj6aj8Dl/oWUT4KdKhq0GJaum4YUHLLAQzLKN5KCBNxEYcod6z1S0EV52c\n\txpsgon3gKpwpHpB0M5AcWU6zDWeugqCW40doerMtHyDHUjaONbbry2Y8pBC1FMA2X/Pu9IX7SISUs\n\tqVXuqQOWA+ZOlrOyySH79vSucwa8FWhvAsSqYlQtTzyFwgNxwGuMh5DWmCj29Zitq+yvx3sD9H5Q4\n\tQPUyOhqJHmX/A79BzdyA==;","From":"Karl Palsson ","To":"lede-dev@lists.infradead.org","Date":"Wed, 30 Aug 2017 17:44:00 +0000","Message-Id":"<1504115040-27121-1-git-send-email-karlp@etactica.com>","X-Mailer":"git-send-email 2.4.11","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170830_104503_358077_0AD0E133 ","X-CRM114-Status":"UNSURE ( 6.10 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t0.0 SPF_FAIL SPF: sender does not match SPF record (fail)\n\t[SPF failed: Please see http://www.openspf.org/Why?s=mfrom;\n\tid=karlp%40etactica.com; ip=2a01%3A7e00%3A%3Af03c%3A91ff%3Afe93%3Af66c;\n\tr=bombadil.infradead.org]\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","Subject":"[LEDE-DEV] [PATCH] procd: mdns: Support txt values with spaces","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Karl Palsson ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"Properly quote the arguments so that you can register a service with TXT\nentries that contains spaces.\n\nExample:\n procd_add_mdns myservice tcp 9999 \"key=descriptive text field 1\" \\\n \"another=something equally verbose\"\n\nOutput before:\n$ avahi-browse -r -v _myservice._tcp\n_myservice._tcp local\n hostname = [blah.local]\n address = [192.168.255.74]\n port = [9999]\n txt = [\"verbose\" \"equally\" \"another=something\" \"1\" \"field\" \"text\" \"key=descriptive\"]\n\nOutput now:\n$ avahi-browse -r -v _myservice._tcp\n_myservice._tcp local\n hostname = [blah.local]\n address = [192.168.255.74]\n port = [9999]\n txt = [\"another=something equally verbose\" \"key=descriptive text field 1\"]\n\nSigned-off-by: Karl Palsson \n---\n package/system/procd/files/procd.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/package/system/procd/files/procd.sh b/package/system/procd/files/procd.sh\nindex 00d754d16ff0..c23c37b83f00 100644\n--- a/package/system/procd/files/procd.sh\n+++ b/package/system/procd/files/procd.sh\n@@ -423,7 +423,7 @@ procd_add_mdns_service() {\n \tjson_add_int port \"$port\"\n \t[ -n \"$1\" ] && {\n \t\tjson_add_array txt\n-\t\tfor txt in $@; do json_add_string \"\" $txt; done\n+\t\tfor txt in \"$@\"; do json_add_string \"\" \"$txt\"; done\n \t\tjson_select ..\n \t}\n \tjson_select ..\n@@ -432,7 +432,7 @@ procd_add_mdns_service() {\n procd_add_mdns() {\n \tprocd_open_data\n \tjson_add_object \"mdns\"\n-\tprocd_add_mdns_service $@\n+\tprocd_add_mdns_service \"$@\"\n \tjson_close_object\n \tprocd_close_data\n }\n","prefixes":["LEDE-DEV"]}