{"id":807664,"url":"http://patchwork.ozlabs.org/api/1.2/patches/807664/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/1504104641-8369-1-git-send-email-vladimir.murzin@arm.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.2/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504104641-8369-1-git-send-email-vladimir.murzin@arm.com>","list_archive_url":null,"date":"2017-08-30T14:50:41","name":"gpio: syscon: do not use raw \"set\" callback in syscon_gpio_dir_out","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a470ee1d4df60e58bab43a51f1a1f795c17571fa","submitter":{"id":65248,"url":"http://patchwork.ozlabs.org/api/1.2/people/65248/?format=json","name":"Vladimir Murzin","email":"vladimir.murzin@arm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/1504104641-8369-1-git-send-email-vladimir.murzin@arm.com/mbox/","series":[{"id":630,"url":"http://patchwork.ozlabs.org/api/1.2/series/630/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=630","date":"2017-08-30T14:50:41","name":"gpio: syscon: do not use raw \"set\" callback in syscon_gpio_dir_out","version":1,"mbox":"http://patchwork.ozlabs.org/series/630/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807664/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807664/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj7jX53wKz9s9Y\n\tfor ;\n\tThu, 31 Aug 2017 00:50:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751375AbdH3Ouz (ORCPT );\n\tWed, 30 Aug 2017 10:50:55 -0400","from foss.arm.com ([217.140.101.70]:45752 \"EHLO foss.arm.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751372AbdH3Ouz (ORCPT );\n\tWed, 30 Aug 2017 10:50:55 -0400","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1C0D080D;\n\tWed, 30 Aug 2017 07:50:55 -0700 (PDT)","from login2.euhpc.arm.com (login2.euhpc.arm.com [10.6.26.144])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\t472963F483; Wed, 30 Aug 2017 07:50:54 -0700 (PDT)"],"From":"Vladimir Murzin ","To":"linux-gpio@vger.kernel.org","Cc":"linus.walleij@linaro.org, grygorii.strashko@ti.com","Subject":"[PATCH] gpio: syscon: do not use raw \"set\" callback in\n\tsyscon_gpio_dir_out","Date":"Wed, 30 Aug 2017 15:50:41 +0100","Message-Id":"<1504104641-8369-1-git-send-email-vladimir.murzin@arm.com>","X-Mailer":"git-send-email 2.0.0","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"},"content":"\"set\" callback is optional and can be NULL, instead use chip->set\nwhich always points at proper callback function.\n\nFixes 2c341d62eb4b (\"gpio: syscon: add soc specific callback to assign output value\")\n\nSigned-off-by: Vladimir Murzin \n---\n drivers/gpio/gpio-syscon.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c\nindex 537cec7..cf88a0b 100644\n--- a/drivers/gpio/gpio-syscon.c\n+++ b/drivers/gpio/gpio-syscon.c\n@@ -122,7 +122,7 @@ static int syscon_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int val)\n \t\t\t\t BIT(offs % SYSCON_REG_BITS));\n \t}\n \n-\tpriv->data->set(chip, offset, val);\n+\tchip->set(chip, offset, val);\n \n \treturn 0;\n }\n","prefixes":[]}