{"id":807585,"url":"http://patchwork.ozlabs.org/api/1.2/patches/807585/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/alpine.LSU.2.20.1708301238330.14191@zhemvz.fhfr.qr/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.2/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-08-30T10:39:31","name":"Fix last dwarf2out change with pubnames","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d11c036616c72342a7175d03f592470181767350","submitter":{"id":4338,"url":"http://patchwork.ozlabs.org/api/1.2/people/4338/?format=json","name":"Richard Biener","email":"rguenther@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/alpine.LSU.2.20.1708301238330.14191@zhemvz.fhfr.qr/mbox/","series":[{"id":584,"url":"http://patchwork.ozlabs.org/api/1.2/series/584/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=584","date":"2017-08-30T10:39:31","name":"Fix last dwarf2out change with pubnames","version":1,"mbox":"http://patchwork.ozlabs.org/series/584/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807585/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807585/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461147-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"xoGYqbAw\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj27k0fQQz9s7c\n\tfor ;\n\tWed, 30 Aug 2017 20:39:45 +1000 (AEST)","(qmail 51967 invoked by alias); 30 Aug 2017 10:39:36 -0000","(qmail 51121 invoked by uid 89); 30 Aug 2017 10:39:35 -0000","from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tWed, 30 Aug 2017 10:39:34 +0000","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\tby\n\tmx1.suse.de (Postfix) with ESMTP id D3505AB1E\tfor\n\t; Wed, 30 Aug 2017 10:39:31 +0000 (UTC)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:subject:message-id:mime-version:content-type; q=dns; s=\n\tdefault; b=xMMNb3xt0FwApBSguSzYi0sRdXuKxCp8pcFgcdJ3EBUfaP03SsVUF\n\twvXeM6xqEaiUFe5Zunm8okMsDY1CBl+KIlIYWmRbv2QZhF7WrZ4vl54D9+eA9126\n\tHjNjbcRa893e+kdvubwaohS+Y1/MVndkTpOOkV6w3BOWqe+smqFsqw=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:subject:message-id:mime-version:content-type; s=\n\tdefault; bh=iDMyr/w78dxp57TxuumEPvpF5mU=; b=xoGYqbAwt3BI7ykvkFNI\n\tBoVeZYNCPtah4sv5mQ8IgYvYhL7YEedsGYFMmmNOYzp/SWKmYIfRxhB81fJsmYnT\n\tlmwpJrlvm8TGHpPqNFWav1HHXgVvO1UBFe115ciVO3AaC76LVlAhKQzi4HgRnjGW\n\tzur7rTgyQ3fFL6pGI2GSFWI=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2,\n\tGIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2141","X-HELO":"mx1.suse.de","Date":"Wed, 30 Aug 2017 12:39:31 +0200 (CEST)","From":"Richard Biener ","To":"gcc-patches@gcc.gnu.org","Subject":"[PATCH] Fix last dwarf2out change with pubnames","Message-ID":"","User-Agent":"Alpine 2.20 (LSU 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII"},"content":"Noticed when trying to do sth on Darwin. Lightly tested, committed\nas obvious.\n\nRichard.\n\n2017-08-30 Richard Biener \n\n\t* dwarf2out.c (dwarf2out_finish): Remove setting AT_pubnames.\n\t(dwarf2out_early_finish): Move setting of AT_pubnames from\n\tearly debug output to early finish.","diff":"Index: gcc/dwarf2out.c\n===================================================================\n--- gcc/dwarf2out.c\t(revision 251449)\n+++ gcc/dwarf2out.c\t(working copy)\n@@ -29965,13 +29965,6 @@ dwarf2out_finish (const char *)\n *slot = ctnode;\n }\n \n- /* The AT_pubnames attribute needs to go in all skeleton dies, including\n- both the main_cu and all skeleton TUs. Making this call unconditional\n- would end up either adding a second copy of the AT_pubnames attribute, or\n- requiring a special case in add_top_level_skeleton_die_attrs. */\n- if (!dwarf_split_debug_info)\n- add_AT_pubnames (comp_unit_die ());\n-\n if (dwarf_split_debug_info)\n {\n int mark;\n@@ -30521,6 +30514,13 @@ dwarf2out_early_finish (const char *file\n for (limbo_die_node *node = limbo_die_list; node; node = node->next)\n note_variable_value (node->die);\n \n+ /* The AT_pubnames attribute needs to go in all skeleton dies, including\n+ both the main_cu and all skeleton TUs. Making this call unconditional\n+ would end up either adding a second copy of the AT_pubnames attribute, or\n+ requiring a special case in add_top_level_skeleton_die_attrs. */\n+ if (!dwarf_split_debug_info)\n+ add_AT_pubnames (comp_unit_die ());\n+\n /* The early debug phase is now finished. */\n early_dwarf_finished = true;\n \n@@ -30581,13 +30581,6 @@ dwarf2out_early_finish (const char *file\n *slot = ctnode;\n }\n \n- /* The AT_pubnames attribute needs to go in all skeleton dies, including\n- both the main_cu and all skeleton TUs. Making this call unconditional\n- would end up either adding a second copy of the AT_pubnames attribute, or\n- requiring a special case in add_top_level_skeleton_die_attrs. */\n- if (!dwarf_split_debug_info)\n- add_AT_pubnames (comp_unit_die ());\n-\n /* Stick a unique symbol to the main debuginfo section. */\n compute_comp_unit_symbol (comp_unit_die ());\n \n","prefixes":[]}